[Bug 17477] New: Duplicating a subfield yields an empty subfield tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 Bug ID: 17477 Summary: Duplicating a subfield yields an empty subfield tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Bug 17152 made the subfield cloning function delete the contents of the cloned subfield. But it makes the subfield tag empty too, and this is causing troubles for people re-opening the records for edition. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 56697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56697&action=edit No subfield tag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Steps to reproduce: - On the cataloging screen, create a new record - Go to the 5xx fields - Put something on the 521$a subfield - Clone the subfield => FAIL: The subfield correctly doesn't include the original data, BUT it doesn't have the subtield tag either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17152 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152 [Bug 17152] Duplicating a subfield should not copy the data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 56700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56700&action=edit Bug 17477 - Duplicating a subfield yields an empty subfield tag The problem only when clone a textareas in 5XX Steps to reproduce error: - On the cataloging screen (basic screen), create a new record - Go to the 5xx fields - Put something on the 521$a subfield or other textareas (e.g. 520$u or 583$x) - Clone the subfield => FAIL: The subfield correctly doesn't include the original data, BUT it doesn't have the subtield tag either. - Apply patch - Clean cache browser and reload page - Repeat steps above - Verify that works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |hector.hecaxmmx@gmail.com CC| |hector.hecaxmmx@gmail.com, | |jonathan.druart@bugs.koha-c | |ommunity.org, | |nick@bywatersolutions.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Severity|major |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56700|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 56704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56704&action=edit Bug 17477: Duplicating a subfield yields an empty subfield tag The problem only when clone a textareas in 5XX Steps to reproduce error: - On the cataloging screen (basic screen), create a new record - Go to the 5xx fields - Put something on the 521$a subfield or other textareas (e.g. 520$u or 583$x) - Clone the subfield => FAIL: The subfield correctly doesn't include the original data, BUT it doesn't have the subtield tag either. - Apply patch - Clean cache browser and reload page - Repeat steps above - Verify that works as expected Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56704|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 56722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56722&action=edit Bug 17477: Duplicating a subfield yields an empty subfield tag The problem only when clone a textareas in 5XX Steps to reproduce error: - On the cataloging screen (basic screen), create a new record - Go to the 5xx fields - Put something on the 521$a subfield or other textareas (e.g. 520$u or 583$x) - Clone the subfield => FAIL: The subfield correctly doesn't include the original data, BUT it doesn't have the subtield tag either. - Apply patch - Clean cache browser and reload page - Repeat steps above - Verify that works as expected Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Hector! Kyle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |16.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed in 3.22.x, will be in 3.22.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17818 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19503 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org