[Bug 23486] New: Date last seen should be set upon registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Bug ID: 23486 Summary: Date last seen should be set upon registration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When a patron is registered, via staff or self registration we should fill in the 'lastseen' field -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Also on issuing an item? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Christofer Zorn <christofer.zorn@ajaxlibrary.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christofer.zorn@ajaxlibrary | |.ca --- Comment #2 from Christofer Zorn <christofer.zorn@ajaxlibrary.ca> --- I'd like to bump this change. We were under reporting our active users because our report was counting when the lastseen date was between two dates, however we had 3000+ active users in the system missed because of the null. If the lastseen date is updated on a SIP connection or CKO, it certainly should be updated when the patron registers. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131657&action=edit Bug 23486: Set lastseen to default to current timestamp Generally, a patron is not registered without some action from the patron Defaulting the lastseen upon creation seems a reasonable way to set the initial value TO test: Apply patches Update database Create a patron Check their lastseen date -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131658&action=edit Bug 23486: DO NOT PUSH Schema update -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |severine.queune@bulac.fr --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- Hi Nick ! I get this error message when I apply the patch in a devbox : Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23486: Set lastseen to default to current timestamp Applying: Bug 23486: DO NOT PUSH Schema update Using index info to reconstruct a base tree... M Koha/Schema/Result/Borrower.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/Borrower.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Borrower.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23486: DO NOT PUSH Schema update hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23486-DO-NOT-PUSH-Schema-update-1WltcW.patch I'll be happy to test it when it's fixed, thanks ! Séverine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131658|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132222&action=edit Bug 23486: DO NOT PUSH Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Séverine Queune <severine.queune@bulac.fr> --- Sorry Nick, I wasn't quick enough to test the first rebase, I have the same error in my DevBox :/ Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23486: Set lastseen to default to current timestamp Applying: Bug 23486: DO NOT PUSH Schema update Using index info to reconstruct a base tree... M Koha/Schema/Result/Borrower.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/Borrower.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Borrower.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23486: DO NOT PUSH Schema update hint: Use 'git am --show-current-patch=diff' to see the failed patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132222|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134540&action=edit Bug 23486: DO NOT PUSH Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134547&action=edit Bug 23486: (follow-up) Correct Schema It seems the generated schema handles timestamp incorrectly - this will allow for testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131657|0 |1 is obsolete| | --- Comment #10 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 134549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134549&action=edit Bug 23486: Set lastseen to default to current timestamp Generally, a patron is not registered without some action from the patron Defaulting the lastseen upon creation seems a reasonable way to set the initial value TO test: Apply patches Update database Create a patron Check their lastseen date Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134540|0 |1 is obsolete| | --- Comment #11 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 134550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134550&action=edit Bug 23486: DO NOT PUSH Schema update Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134547|0 |1 is obsolete| | --- Comment #12 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 134551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134551&action=edit Bug 23486: (follow-up) Correct Schema It seems the generated schema handles timestamp incorrectly - this will allow for testing Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Séverine Queune <severine.queune@bulac.fr> --- Works nice, well done Nick !! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Patch doesn't apply --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please fix the DBIx stuff and submit it in one patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134549|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134963&action=edit Bug 23486: Set lastseen to default to current timestamp Generally, a patron is not registered without some action from the patron Defaulting the lastseen upon creation seems a reasonable way to set the initial value TO test: Apply patches Update database Create a patron Check their lastseen date Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134550|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134964&action=edit Bug 23486: DO NOT PUSH Schema update RM note - manual changes needed to generate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- There's something really odd going on here.. I don't understand why current_timestamp is coming out wrong.. though I do have vague recollections of such an issue in the past. However.. I also query.. should the column be updated to 'NOT NULL' too if we're giving it a DEFAULT? Also.. sha1 issues trying to apply the follow-up.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- I think if we are going to make it 'NOT NULL' we are going to need to add a DB update, and set any currently null to the dateenrolled. That was we don't 'see' a number of patrons at upgrade -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134551|0 |1 is obsolete| | Attachment #134963|0 |1 is obsolete| | Attachment #134964|0 |1 is obsolete| | --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148780&action=edit Bug 23486: Set lastseen to default to current timestamp Generally, a patron is not registered without some action from the patron Defaulting the lastseen upon creation seems a reasonable way to set the initial value. This patch also makes the column NOT NULL to avoid any future data issues. To handle any currently NULL, we either set them to dateenrolled, or updated_on - the latter is already NOT NULL so is the bast fallback we have (assuming patron was also seen when they were updated) TO test: Apply patches Update database Create a patron Check their lastseen date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148781&action=edit Bug 23486: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #21 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- After applying the patch I was unable to create a new patron. I received the message, "The following fields are wrong. Please fix them." even though all the required fields were completed and no fields were being marked as incorrect. Even after filling in all the optional fields the patron could still not be created. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148780|0 |1 is obsolete| | Attachment #148781|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 149273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149273&action=edit Bug 23486: Set lastseen to default to current timestamp Generally, a patron is not registered without some action from the patron Defaulting the lastseen upon creation seems a reasonable way to set the initial value. This patch also makes the column NOT NULL to avoid any future data issues. To handle any currently NULL, we either set them to dateenrolled, or updated_on - the latter is already NOT NULL so is the bast fallback we have (assuming patron was also seen when they were updated) TO test: Apply patches Update database Create a patron Check their lastseen date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 149274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149274&action=edit Bug 23486: DO NOT PUSH - Schema updates Note that the fields must be manually updated after generation as generated syntax us invalid: default_value: 'current_timestamp()' First occurence: default_value: 'current_timestamp' Second occurence: default_value => \"current_timestamp", -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149273|0 |1 is obsolete| | --- Comment #24 from David Nind <david@davidnind.com> --- Created attachment 150119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150119&action=edit Bug 23486: Set lastseen to default to current timestamp Generally, a patron is not registered without some action from the patron Defaulting the lastseen upon creation seems a reasonable way to set the initial value. This patch also makes the column NOT NULL to avoid any future data issues. To handle any currently NULL, we either set them to dateenrolled, or updated_on - the latter is already NOT NULL so is the bast fallback we have (assuming patron was also seen when they were updated) TO test: Apply patches Update database Create a patron Check their lastseen date Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149274|0 |1 is obsolete| | --- Comment #25 from David Nind <david@davidnind.com> --- Created attachment 150120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150120&action=edit Bug 23486: DO NOT PUSH - Schema updates Note that the fields must be manually updated after generation as generated syntax us invalid: default_value: 'current_timestamp()' First occurence: default_value: 'current_timestamp' Second occurence: default_value => \"current_timestamp", Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #26 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. To check the lastseen field in the database: - koha-mysql kohadev - SQL query (where XXX = borrower number for newly created patron): select * from borrowers where borrowernumber = XXX; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- "Generally, a patron is not registered without some action from the patron Defaulting the lastseen upon creation seems a reasonable way to set the initial value" I believe this is a wrong assumption. It works for self registrations and manual registration, but not for patron imports. Often an institution will import all their users so they can log into the OPAC when they need to, but a lot of them never will. For this use case setting the date and assuming them as active won't be correct. This is also true when migrating data using the patron import tool, also common. I think we cannot handle that on database level for this reason, we need to handle the different types of registration somehow. Also, right now documentation would be wrong: last time a patron has been seen (connected at the OPAC or staff interface) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I agree with Katrin here I'm afraid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We could add patron creation to the list of actions in TrackLastPatronActivityTriggers to resolve this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Inkeri Hakulinen <inkeri.hakulinen+bugz@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |inkeri.hakulinen+bugz@helsi | |nki.fi --- Comment #30 from Inkeri Hakulinen <inkeri.hakulinen+bugz@helsinki.fi> --- I think that Katrin's suggestion is good. It lets every library then decide, do they want adding a patron to set a date to "lastseen" or not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #31 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150119|0 |1 is obsolete| | Attachment #150120|0 |1 is obsolete| | --- Comment #32 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 171829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171829&action=edit Bug 23486: Add creation to TrackLasPatronActivity triggers Some libraries would like to update the last seen when a patron is created to avoid NULL values and ensure new users are marked as 'active' To test: 1 - Apply patch 2 - Create a new patron, confirm their lastseen date is null SELECT lastseen FROM borrowers WHERE cardnumber={their cardnumber} 3 - Update preference 'TrackLastPatronActivity' to include 'Patron creation' 4 - Create a second patron, confirm their lastseen is set 5 - Update preference 'TrackLastPatronActivity' to include 'Checking out an item' 6 - Checkout an item to the second patron 7 - Confirm their lastseen is not updated (We only update once per day) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Date last seen should be |TrackLastPatronActivityTrig |set upon registration |gers should have an option | |for patron creation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from Owen Leonard <oleonard@myacpl.org> --- I keep getting an error when adding a patron. It seems only happen if I have "Patron creation" checked under the TrackLastPatronActivity. When I fill out the patron creation form and submit I get an error message at the top of the page, "The following fields are wrong. Please fix them." But no fields are listed and no fields appear to be filled out incorrectly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171829|0 |1 is obsolete| | --- Comment #34 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172820&action=edit Bug 23486: Add creation to TrackLasPatronActivity triggers Some libraries would like to update the last seen when a patron is created to avoid NULL values and ensure new users are marked as 'active' To test: 1 - Apply patch 2 - Create a new patron, confirm their lastseen date is null SELECT lastseen FROM borrowers WHERE cardnumber={their cardnumber} 3 - Update preference 'TrackLastPatronActivity' to include 'Patron creation' 4 - Create a second patron, confirm their lastseen is set 5 - Update preference 'TrackLastPatronActivity' to include 'Checking out an item' 6 - Checkout an item to the second patron 7 - Confirm their lastseen is not updated (We only update once per day) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #35 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Owen Leonard from comment #33)
I keep getting an error when adding a patron. It seems only happen if I have "Patron creation" checked under the TrackLastPatronActivity.
When I fill out the patron creation form and submit I get an error message at the top of the page, "The following fields are wrong. Please fix them." But no fields are listed and no fields appear to be filled out incorrectly.
updated_on was beign returned as 'current_timestamp', I had to add a refetch of the patron to ensure we got the value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172820|0 |1 is obsolete| | --- Comment #36 from David Nind <david@davidnind.com> --- Created attachment 172927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172927&action=edit Bug 23486: Add creation to TrackLasPatronActivity triggers Some libraries would like to update the last seen when a patron is created to avoid NULL values and ensure new users are marked as 'active' To test: 1 - Apply patch 2 - Create a new patron, confirm their lastseen date is null SELECT lastseen FROM borrowers WHERE cardnumber={their cardnumber} 3 - Update preference 'TrackLastPatronActivity' to include 'Patron creation' 4 - Create a second patron, confirm their lastseen is set 5 - Update preference 'TrackLastPatronActivity' to include 'Checking out an item' 6 - Checkout an item to the second patron 7 - Confirm their lastseen is not updated (We only update once per day) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #37 from David Nind <david@davidnind.com> --- Created attachment 172928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172928&action=edit Bug 23486: (follow-up) Display text for new option Change display text for creation option from "Patron creation" to "Creating a patron" - for consistency with other values. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |creating a patron as an | |option for updating the | |last seen date when using | |the | |TrackLastPatronActivityTrig | |gers system preference. | |Previously, creating a | |patron was not an option | |for updating the last seen | |date - this could | |understate reports about | |active patrons. Severity|normal |enhancement --- Comment #38 from David Nind <david@davidnind.com> --- I updated the display text for the new option to "Creating a patron" (instead of "Patron creation") for consistency with the other options (Checking out an item, Logging in, and so on). Feel free to remove the follow-up patch if you don't agree. I think this is an enhancement/improvement, so changed to an enhancement. But perhaps it should have tracked this from the start, so maybe is a bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172927|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 174080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174080&action=edit Bug 23486: Add creation to TrackLasPatronActivity triggers Some libraries would like to update the last seen when a patron is created to avoid NULL values and ensure new users are marked as 'active' To test: 1 - Apply patch 2 - Create a new patron, confirm their lastseen date is null SELECT lastseen FROM borrowers WHERE cardnumber={their cardnumber} 3 - Update preference 'TrackLastPatronActivity' to include 'Patron creation' 4 - Create a second patron, confirm their lastseen is set 5 - Update preference 'TrackLastPatronActivity' to include 'Checking out an item' 6 - Checkout an item to the second patron 7 - Confirm their lastseen is not updated (We only update once per day) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172928|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 174081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174081&action=edit Bug 23486: (follow-up) Display text for new option Change display text for creation option from "Patron creation" to "Creating a patron" - for consistency with other values. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds |This enhancement adds release notes|creating a patron as an |'Creating a patron' as an |option for updating the |option for the |last seen date when using |TrackLastPatronActivityTrig |the |gers system preference - |TrackLastPatronActivityTrig |for updating the last seen |gers system preference. |date. Previously, creating |Previously, creating a |a patron was not an option |patron was not an option |for updating the last seen |for updating the last seen |date - this could |date - this could |understate reports about |understate reports about |active patrons. |active patrons. | Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds |This enhancement adds release notes|'Creating a patron' as an |'Creating a patron' as an |option for the |option to the |TrackLastPatronActivityTrig |TrackLastPatronActivityTrig |gers system preference - |gers system preference (for |for updating the last seen |updating the last seen |date. Previously, creating |date). Previously, creating |a patron was not an option |a patron was not an option |for updating the last seen |for updating the last seen |date - this could |date - this could |understate reports about |understate reports about |active patrons. |active patrons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #42 from Christofer Zorn <christofer.zorn@ajaxlibrary.ca> --- Thank you everyone! Is a backport possible to 24.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #43 from David Nind <david@davidnind.com> --- (In reply to Christofer Zorn from comment #42)
Thank you everyone! Is a backport possible to 24.05?
I changed it from a normal bug to an enhancement (see comment #38). Bugs would normally be considered by the Release Maintainer for back porting, generally enhancements aren't. So the question is whether it is an enhancement or not: - Enhancement: adds to or improves a feature, but is not fixing something broken or not working as intended - Bug: something is broken or doesn't work as originally intended I'm not really sure for this one - I can see the case for both! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #44 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk Documentation| |Aude Charillon contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1046 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39014 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39014 [Bug 39014] Storing a guarantee fails due to TrackLastPatronActivityTriggers "creating a patron" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #45 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Koha Manual updated. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org