[Bug 20667] New: Update two-column templates with Bootstrap grid: Acquisitions part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Bug ID: 20667 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 14546, 20654 This patch will convert several acquisitions templates to use the Bootstrap grid: acqui/acqui-home.tt acqui/basketgroup.tt acqui/booksellers.tt acqui/edifactmsgs.tt acqui/edimsg.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client templates responsive https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74891&action=edit Bug 20667: Update two-column templates with Bootstrap grid: Acquisitions part 1 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Acquisitions -> Home page - Acquisitions -> Vendor search results - Acquisitions -> Vendor -> Basket groups -> Edit - Acquisitions -> EDIFACT messages -> View EDIFACT message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Hi Owen, On 'Edit basket group',label for "Baskets in this group:" is not on the grid. It's something we already have, I'm not sure your patch is supposed to fix it, but as the gap is bigger now, I prefer mention it. I didn't test for Edifact messages. Except these 2 points, display seemed good to me. I prefer not sign the patch to let someone else test it too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74891|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74948&action=edit Bug 20667: Update two-column templates with Bootstrap grid: Acquisitions part 1 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Acquisitions -> Home page - Acquisitions -> Vendor search results - Acquisitions -> Vendor -> Basket groups -> Edit - Acquisitions -> EDIFACT messages -> View EDIFACT message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Séverine Queune from comment #2)
On 'Edit basket group',label for "Baskets in this group:" is not on the grid. It's something we already have, I'm not sure your patch is supposed to fix it
My patch is not intended to fix it. There are other pending patches for this template and I want to limit what areas I modify. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74948|0 |1 is obsolete| | --- Comment #5 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 74959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74959&action=edit Bug 20667: Update two-column templates with Bootstrap grid: Acquisitions part 1 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Acquisitions -> Home page - Acquisitions -> Vendor search results - Acquisitions -> Vendor -> Basket groups -> Edit - Acquisitions -> EDIFACT messages -> View EDIFACT message Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74959|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 75748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75748&action=edit Bug 20667: Update two-column templates with Bootstrap grid: Acquisitions part 1 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Acquisitions -> Home page - Acquisitions -> Vendor search results - Acquisitions -> Vendor -> Basket groups -> Edit - Acquisitions -> EDIFACT messages -> View EDIFACT message Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Found a permission problem while testing this, filed and fixed on bug 20861. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I love this update :) Enhancement, not backporting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21163 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 [Bug 21163] Basket group detail page layout is broken -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org