[Bug 23196] New: Reindent tools/batch_record_modification.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 Bug ID: 23196 Summary: Reindent tools/batch_record_modification.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- I would like to reindent tools/batch_record_modification.tt: Remove correct indentation, add some comments to clarify the structure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 90965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90965&action=edit Bug 23196: Reindent tools/batch_record_modification.tt This patch re-indents the template for batch record modifications. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master There should be no changes reported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 90966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90966&action=edit Bug 23196: (follow-up) Add comments to highlight structure This follow-up adds a few comments to the markup in order to highlight and clarify the the HTML structure. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master You should only see the addition of HTML comments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90965|0 |1 is obsolete| | Attachment #90966|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90972&action=edit Bug 23196: Reindent tools/batch_record_modification.tt This patch re-indents the template for batch record modifications. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master There should be no changes reported. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90973&action=edit Bug 23196: (follow-up) Add comments to highlight structure This follow-up adds a few comments to the markup in order to highlight and clarify the the HTML structure. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master You should only see the addition of HTML comments. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- If the file is correctly indented, do we really need the comments? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've found them very helpful in the past. The issue probably is that it won't stay that way and in a big file it can really help orientation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #5)
If the file is correctly indented, do we really need the comments?
I also find the comments helpful when viewing source in the browser. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90972|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91036&action=edit Bug 23196: Reindent tools/batch_record_modification.tt This patch re-indents the template for batch record modifications. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master There should be no changes reported. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90973|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91037&action=edit Bug 23196: (follow-up) Add comments to highlight structure This follow-up adds a few comments to the markup in order to highlight and clarify the the HTML structure. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master You should only see the addition of HTML comments. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 Refactoring with only spaces so I choose to backport in order to minimize future conflicts with master commits ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23196 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- tried to backport, but quite a few merge conflicts and since this is an enhancement I am choosing to skip for 18.11.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org