http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 --- Comment #1 from Amit <amitddng135@gmail.com> --- Created attachment 40722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40722&action=edit Wrong search index -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 --- Comment #2 from Amit <amitddng135@gmail.com> --- Created attachment 40724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40724&action=edit Bug 14472 - Wrong ISSN search index in record matching rules -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40724|0 |1 is obsolete| | Attachment #40725|0 |1 is obsolete| | CC| |amitddng135@gmail.com --- Comment #5 from Amit <amitddng135@gmail.com> --- Created attachment 40801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40801&action=edit Bug 14472 - Squashed Wrong ISSN search index in matching rules Thanks IDG for comments I squashed two patches for simplicity. Bug 14472 - Wrong ISSN search index in record matching rules TEST PLAN --------- 1) Apply the patch 2) Export some MARC bibliographic records from Koha 3) Import those same MARC bibliographic records using the "ISSN(022$a)" record matching rule. 4) The incoming records should match perfectly 5) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. For new Koha installation 1) create the koha database 2) Go to the staff client page, and do a "fresh" install making sure to select lots of optional marc 21 matching rules so the .../marc21/optional/marc21_default_matching_rules.sql gets triggered. 3) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 --- Comment #7 from Amit Gupta <amitddng135@gmail.com> --- Hi Mark, Thanks for comments

How do you know the matcher_id is 2 for everyone? Yes you are right matcher_id is 2 not for everyone.

------------------------------------------------------- update marc_matchers set search_index ='issn' where matcher_id = (select matcher_id from marc_matchers where code = 'ISSN'); -------------------------------------------------------

Your fresh install modifications change isbn to issn, is that correct?

Currently if you upload MARC records using "ISSN(022$a)" record matching rule. It will not match any record due to wrong search index. After applying this patch the incoming records should match perfectly using ("ISSN(022$a)" record matching rule). Will resend patch again. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40801|0 |1 is obsolete| | --- Comment #9 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 40840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40840&action=edit Bug 14472 - Wrong ISSN search index in record matching rules Bug 14472 - Wrong ISSN search index in record matching rules TEST PLAN --------- 1) Apply the patch 2) Export some MARC bibliographic records from Koha 3) Import those same MARC bibliographic records using the "ISSN(022$a)" record matching rule. 4) The incoming records should match perfectly 5) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. For new Koha installation 1) create the koha database 2) Go to the staff client page, and do a "fresh" install making sure to select lots of optional marc 21 matching rules so the .../marc21/optional/marc21_default_matching_rules.sql gets triggered. 3) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. Fix SQL: UPDATE matchpoints SET search_index ='issn' where matcher_id = (SELECT matcher_id FROM marc_matchers WHERE code = 'ISSN'); -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40840|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 42256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42256&action=edit Bug 14472 - Wrong ISSN search index in record matching rules To Test --------- 1) Apply the patch 2) Export some MARC bibliographic records from Koha 3) Import those same MARC bibliographic records using the "ISSN(022$a)" record matching rule. 4) The incoming records should match perfectly 5) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. For new Koha installation 1) create the koha database 2) Go to the staff client page, and do a "fresh" install making sure to select lots of optional marc 21 matching rules so the .../marc21/optional/marc21_default_matching_rules.sql gets triggered. 3) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. Bug 14472 - Added Atomic Update to fix wrong issn search index - Fix comments Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42256|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42275&action=edit Bug 14472 - Wrong ISSN search index in record matching rules To Test --------- 1) Apply the patch 2) Export some MARC bibliographic records from Koha 3) Import those same MARC bibliographic records using the "ISSN(022$a)" record matching rule. 4) The incoming records should match perfectly 5) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. For new Koha installation 1) create the koha database 2) Go to the staff client page, and do a "fresh" install making sure to select lots of optional marc 21 matching rules so the .../marc21/optional/marc21_default_matching_rules.sql gets triggered. 3) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. Bug 14472 - Added Atomic Update to fix wrong issn search index - Fix comments Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson@biblibre.com --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note that this file does not exist for fr-FR unimarc. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 42710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42710&action=edit Bug 14472: (QA followup) fix updatedatabase.pl for multiple ISSN rules If (for some reason) the user has created more than one matching rule with the 'ISSN' code, the updatedabase.pl script fails, because it was written with the default data in mind, and didn't consider the scenario described above. Thanks Liz for pointing this out! Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.