[Bug 8509] New: Allowing the Expected status even if another status has been saved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8509 Priority: P5 - low Change sponsored?: --- Bug ID: 8509 CC: colin.campbell@ptfs-europe.com Assignee: adrien.saurat@biblibre.com Summary: Allowing the Expected status even if another status has been saved Severity: enhancement Classification: Unclassified OS: All Reporter: adrien.saurat@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Serials Product: Koha When receiving Serials, if a librarian selects a status like "Arrived" or something else, it's later impossible to go back to the initial "Expected" status. This makes mistakes impossible to correct. Maybe would it be better to display the "Expected" status in the modification selectbox. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8509 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 12396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12396&action=edit proposed patch TEST PLAN Receive serials. Change a serial from Expected to another status. Come back to the receive page. Before patch : the serial cannot be set to Expected anymore After patch : the Expected status still appear in the select box and can be used -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8509 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8509 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12396|0 |1 is obsolete| | --- Comment #2 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 13327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13327&action=edit [Signed off] Bug 8509: allows the Expected status to be chosen back If a serial has been marked as received by mistake, it's now possible to set it as an "Expected" serial again. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8509 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melia@bywatersolutions.com --- Comment #3 from Melia Meggs <melia@bywatersolutions.com> --- Before applying the patch, I selected the status "arrived." I then went back to the receive page, clicked on edit, and found it was not possible for me to go back to "expected" because it did not appear as a choice in the status dropdown menu. After applying the patch, I can go back to "expected." I am signing off. One question I'd like to ask, though: After changing back to status "expected," if you go back to the receive page, the Date Received is still filled in there. Is this correct? I would think if you were going back to "expected" it would be because you had accidentally marked it "arrived." Perhaps when you go back to "expected," the date received should go back to XXX like it was before I marked it "arrived." I am not 100% sure about use cases here, so I'll go ahead and sign off. Maybe the date received could be fixed (if necessary) in a follow up patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8509 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de Patch complexity|--- |Trivial patch --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Adrien, there is a small conflict with the patch, could you rebase? I am a bit worried about the problem Melia noticed and I wonder what will happen when you create items with your subscription. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8509 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8509 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13327|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14739&action=edit Bug 8509: allows the Expected status to be chosen back If a serial has been marked as received by mistake, it's now possible to set it as an "Expected" serial again. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8509 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8509 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14739|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16550&action=edit [PASSED QA] Bug 8509: allows the Expected status to be chosen back If a serial has been marked as received by mistake, it's now possible to set it as an "Expected" serial again. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. I did varoius tests on a subscription switching between the different status (expected, arrived, late) and couldn't find a bad side effect of this patch. Note: The date arrived/date expected is not automatically reset, but you can enter the date manually in the template, so I think this could be handled in a separate bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8509 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org