[Bug 43313] New: Item's permanent location not shown when item's location is set to CART
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43313 Bug ID: 43313 Summary: Item's permanent location not shown when item's location is set to CART Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Keywords: regression Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- In 25.11 and previous, when items.location and items.permanent_location do not match, Koha shows the permanent_location value followed by the location value in parentheses. This is most often due to the library using UpdateItemLocationOnCheckin to set the location to CART at checkin. In 26.05 and later, the permanent_location value is not displayed. Instead, one is shown only the location in parentheses. So where we would have seen Adult fiction (Shelving cart) We now see (Shelving cart) We should show both values. Inserting a line break between them while we're at it would be nice: Adult fiction (Shelving cart) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43313 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |olivia.reynolds@openfifth.c |ity.org |o.uk Comma delimited| |Open Fifth list of Sponsors| | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43313 --- Comment #1 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203740&action=edit Bug 43313: Fix catalogue detail shelving location display During the tidying up of Bug 41566, av_loc was accidentally changed to map descriptions to codes, rather than vice-versa. This broke the formatting of item permanent locations. Test plan (for KTD): 1. Navigate to an catalogue detail page, for example http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=262 2. Run the following SQL, replacing 262 with the biblionumber of your chosen page: UPDATE items SET location='CHILD' SET permanent_location='GEN' WHERE biblionumber=262; 3. Refresh the page and verify the items' shelving locations display "(Children's area)" only. 4. Apply patch and force refresh. 5. Verify the shelving location now correctly displays "General stacks" and "(Children's area)" on separate lines. Sponsored-by: Open Fifth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43313 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=43331 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43313 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from John Vinke <jvinke@austinseminary.edu> --- live from Koha-US -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43313 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203740|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43313 --- Comment #3 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 203762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203762&action=edit Bug 43313: Fix catalogue detail shelving location display During the tidying up of Bug 41566, av_loc was accidentally changed to map descriptions to codes, rather than vice-versa. This broke the formatting of item permanent locations. Test plan (for KTD): 1. Navigate to an catalogue detail page, for example http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=262 2. Run the following SQL, replacing 262 with the biblionumber of your chosen page: UPDATE items SET location='CHILD' SET permanent_location='GEN' WHERE biblionumber=262; 3. Refresh the page and verify the items' shelving locations display "(Children's area)" only. 4. Apply patch and force refresh. 5. Verify the shelving location now correctly displays "General stacks" and "(Children's area)" on separate lines. Sponsored-by: Open Fifth Signed-off-by: John Vinke <jvinke@austinseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43313 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43313 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43313 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 203769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203769&action=edit Bug 43313: Fix catalogue detail shelving location display During the tidying up of Bug 41566, av_loc was accidentally changed to map descriptions to codes, rather than vice-versa. This broke the formatting of item permanent locations. Test plan (for KTD): 1. Navigate to an catalogue detail page, for example http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=262 2. Run the following SQL, replacing 262 with the biblionumber of your chosen page: UPDATE items SET location='CHILD' SET permanent_location='GEN' WHERE biblionumber=262; 3. Refresh the page and verify the items' shelving locations display "(Children's area)" only. 4. Apply patch and force refresh. 5. Verify the shelving location now correctly displays "General stacks" and "(Children's area)" on separate lines. Sponsored-by: Open Fifth Signed-off-by: John Vinke <jvinke@austinseminary.edu> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43313 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43313 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org