http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se --- Comment #1 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Hear hear. This would be highly useful. And not too complicated I imagine. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 --- Comment #2 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Created attachment 28926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28926&action=edit Bug 7843 Create an RSS feed for news in Opac This patch introduces two new files: opac-news-rss.pl and opac-news-rss.tt. The files create an RSS feed for news in the opac between them, and to access the feed you go to opac-news-rss.pl in the opac. I intentionally waited with creating a RSS icon on opac-main.pl since I think we might want to discuss a few issues before exposing the feeds publicly even if the patch is pushed. Issues I know would be good to discuss is: * The news items have no individual links since there is no graphical view of individual news items in the way that a blog would have. Is this a problem for RSS-readers? * Should we add additional metadata like author, administrator, publishing dates etc? * Currently the feed will display news for all libraries + your home branch if you access it while logged in. Would only "all libraries" be better? Or maybe all libraries + every item for individual branches? Test plan: * Install patch a * Make shure there is news in the Opac. * Go to the page opac-news-rss.pl in your Opac. * Verify that an RSS feed shows up with the same news as in opac-main.pl * Validate the RSS-feed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |viktor.sarge@regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 --- Comment #4 from Viktor Sarge <viktor.sarge@regionhalland.se> --- (In reply to Owen Leonard from comment #3)

(In reply to Viktor Sarge from comment #2)

...

* The news items have no individual links since there is no graphical view of individual news items in the way that a blog would have. Is this a problem for RSS-readers?

I think it could be potentially confusing. Maybe we should add an id to each news item header row and link to that as an in-page anchor? opac-main.pl#newsitem4

If we use an id that stays unique over time that would work quite well. I would however like it better if we could create a view where news article are displayed as single page items. Then we could also create a news archive where news items are migrated as the time out.

...

* Should we add additional metadata like author, administrator, publishing dates etc?

I would add publish date. We don't store author or administrator information with individual news items so we can't show anything relevant there.

* I'll look into picking up publish date. I do think that the possibility of auto displaying author would be great. If you run with that thought you might even end up with auto created staff pages and a tab for "Our staff" you could enable.

...

* Currently the feed will display news for all libraries + your home branch if you access it while logged in. Would only "all libraries" be better? Or maybe all libraries + every item for individual branches?

I would assume that anyone who was looking at the RSS feed would be doing so in a feed reader outside the context of a logged-in session, so I'm not sure the home branch items are going to get seen. I don't like that the feed a logged-in user would see in their RSS reader would be different from the news they see on the site, but I'm not sure there's a better way to handle it. A feed for all libraries might be inappropriate or simply too much data. One option might be to offer the user a choice?

- "All libraries" news plus the user's library - "All libraries" news plus news for all libraries

I don't know how savvy users are with multiple RSS feeds.

* This is a bit of a problem. The quickest solution might be to only display news that is for all libraries. But I think the actual problem is that you have to log in to see news that should be public from the start. If we use the news to customize the opac to be used as websites for all the different branches then there should be a public way to navigate between branches. My suggestion would be to only display "all libraries" in the RSS if we want to push this functionality quick. Would looking (and searching) another branch than the home branch you have on your account mess with anything? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #7 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Thanks for pointing it out Bernardo and I do plan to do the last parts too Owen. I just quite quickly came to a halt in development when the vacation started. So let me just find the horse and I'll get right back up on it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Ok first of all - sorry I forgot about this one for a long time. But here's a new patch. Validation of the feed is ok but it still wants an unique identifier. I chose however to rather keep it a small patch and update if people are ok with the additional changes to news. Especially since I'd like to have a newsarchive + a view for single newsitems to link to. The text "RSS for the librarys general newsfeed." on opac-main.pl is there to try and explain to people will se only news directed to all libraries and will not get the news they might be seeing if they are logged in to a branch. We will need a way to switch between branches since both news, CSS and other content might be different on the branches. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13729 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35733|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 36017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36017&action=edit Bug 7843 Create an RSS feed for news in Opac Test plan: * Install the patch * Make shure there is news in the Opac * Go to the Opac (opac-main.pl) * Make shure you see an RSS icon below the news and a short text. * Click the RSS icon and verify that you get an RSS feed that validates. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> I took the liberty of fixing the copyright statement when signing it off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36017|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36023&action=edit Bug 7843 Create an RSS feed for news in Opac Test plan: * Install the patch * Make shure there is news in the Opac * Go to the Opac (opac-main.pl) * Make shure you see an RSS icon below the news and a short text. * Click the RSS icon and verify that you get an RSS feed that validates. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> I took the liberty of fixing the copyright statement when signing it off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36025&action=edit Bug 7843: (qa-followup) Create an RSS feed for news in Opac 1/ use strict and warnings are useless, Modern::Perl is used 2/ Prefer to use the interface and theme TT var instead of the hard coded path -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13774 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13782 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 --- Comment #16 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 36390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36390&action=edit (follow up) Improve RSS feed language The RSS button used to read ' RSS for the librarys general newsfeed.' This included one grammatical error and I think included more words than most average people would read. This patch simplifies it to say 'RSS for Library News.' To test: * Apply all patches * Review RSS feed button's text on main page under news -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 --- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 36403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36403&action=edit Bug 7843: Followup - fix broken url This patch fixes an invalid URL when clicking on RSS feed. To test: 1) Using Nicole words :) If you visit : http://mykoha/cgi-bin/koha/opac-main.pl then the RSS feed works. If you're on http://mykoha and you click the rss icon you get : http://mykoha/opac-news-rss.pl which is a 404 page. 2) Apply the patch 3) Repeat 1, error is now fixed -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #18 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Pierre <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36024|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36390|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 --- Comment #19 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 36414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36414&action=edit Bug 7843 Create an RSS feed for news in Opac Test plan: * Install the patch * Make shure there is news in the Opac * Go to the Opac (opac-main.pl) * Make shure you see an RSS icon below the news and a short text. * Click the RSS icon and verify that you get an RSS feed that validates. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> I took the liberty of fixing the copyright statement when signing it off Signed-off-by: Pierre <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 --- Comment #21 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 36416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36416&action=edit Bug 7843: (qa-followup) Create an RSS feed for news in Opac 1/ use strict and warnings are useless, Modern::Perl is used 2/ Prefer to use the interface and theme TT var instead of the hard coded path Signed-off-by: Pierre <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 --- Comment #23 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 36418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36418&action=edit Bug 7843: Followup - fix broken url This patch fixes an invalid URL when clicking on RSS feed. To test: 1) Using Nicole words :) If you visit : http://mykoha/cgi-bin/koha/opac-main.pl then the RSS feed works. If you're on http://mykoha and you click the rss icon you get : http://mykoha/opac-news-rss.pl which is a 404 page. 2) Apply the patch 3) Repeat 1, error is now fixed Signed-off-by: Pierre <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36414|0 |1 is obsolete| | Attachment #36415|0 |1 is obsolete| | Attachment #36416|0 |1 is obsolete| | Attachment #36417|0 |1 is obsolete| | Attachment #36418|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36651&action=edit [PASSED-QA] Bug 7843 Create an RSS feed for news in Opac Test plan: * Install the patch * Make shure there is news in the Opac * Go to the Opac (opac-main.pl) * Make shure you see an RSS icon below the news and a short text. * Click the RSS icon and verify that you get an RSS feed that validates. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> I took the liberty of fixing the copyright statement when signing it off Signed-off-by: Pierre <tredok.pierre@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36653&action=edit [PASSED-QA] Bug 7843: (qa-followup) Create an RSS feed for news in Opac 1/ use strict and warnings are useless, Modern::Perl is used 2/ Prefer to use the interface and theme TT var instead of the hard coded path Signed-off-by: Pierre <tredok.pierre@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36655&action=edit [PASSED-QA] Bug 7843: Followup - fix broken url This patch fixes an invalid URL when clicking on RSS feed. To test: 1) Using Nicole words :) If you visit : http://mykoha/cgi-bin/koha/opac-main.pl then the RSS feed works. If you're on http://mykoha and you click the rss icon you get : http://mykoha/opac-news-rss.pl which is a 404 page. 2) Apply the patch 3) Repeat 1, error is now fixed Signed-off-by: Pierre <tredok.pierre@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Viktor! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Create RSS for OPAC news |Add RSS feeds for OPAC news CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.