[Bug 8296] New: Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Priority: P5 - low Change sponsored?: --- Bug ID: 8296 CC: colin.campbell@ptfs-europe.com Assignee: julian.maurice@biblibre.com Summary: Add descriptive (text) published date field for serials Severity: enhancement Classification: Unclassified OS: All Reporter: julian.maurice@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Serials Product: Koha This development add a new text field for serials which allow librarians to enter a published date in the format he wants (displayed in full subscription history at OPAC, and in each page displaying published date at staff interface) Example: for a monthly subscription, we can enter "January 2012", "February 2012" instead of having "01/20/2012", "02/20/2012". If not filled, displayed text is the published date. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 10435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10435&action=edit Bug 8296: Add descriptive (text) published date field for serials Add a new field serial.publisheddatetext for displaying published date in another format that dateformat syspref permit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10435|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 10582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10582&action=edit Bug 8296: Add descriptive (text) published date field for serials Add a new field serial.publisheddatetext for displaying published date in another format that dateformat syspref permit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Patch reformatted so it applies, I haven't tested well enough to sign off though, but this should help someone else -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #4 from delaye <stephane.delaye@biblibre.com> --- i test with a sandbox .it work. In the opac with have the two dates shown(AAAA-MM-JJ and text) *** an automatic mode for managing the date formats through authorised values activated in subscriptions records would also a idea ... but this does not mean the same developement..... *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10582|0 |1 is obsolete| | --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11552&action=edit Bug 8296: Add descriptive (text) published date field for serials Add a new field serial.publisheddatetext for displaying published date in another format that dateformat syspref permit. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Why do you add a limitation of 15 chars in the tt file and 100 chars for the sql column ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Hmm I suspect a copy/paste error... Fix is coming. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12228&action=edit Bug 8296: set input maxlength to the same of sql field length -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11552|Bug 8296: Add descriptive |[SIGNED-OFF] Bug 8296: Add description|(text) published date field |descriptive (text) |for serials |published date field for | |serials -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11552|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12229&action=edit [SIGNED-OFF] Bug 8296: Add descriptive (text) published date field for serials -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12228|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12230&action=edit Bug 8296: set input maxlength to the same of sql field length -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Both patch rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12230|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12233&action=edit Bug 8296: set input maxlength to the same of sql field length Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: * serials/serials-collection.pl FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: tabulation character at line 2 + my $sth = $dbh->prepare("; valid OK critic OK * serials/serials-edit.pl FAIL forbidden patterns OK valid FAIL "my" variable @publisheddates masks earlier declaration in same scope critic OK 1 tabulation character and 1 redefined variable. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12240&action=edit [SIGNED-OFF] Bug 8296: Follow up for QA 1 tab replaced by space 1 redefined variable removed Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Please resolve merge conflict for serials-collection.pl on current master. Thank you very much. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12229|0 |1 is obsolete| | --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13079&action=edit Bug 8296: Add descriptive (text) published date field for serials Add a new field serial.publisheddatetext for displaying published date in another format that dateformat syspref permit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12233|0 |1 is obsolete| | --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13080&action=edit Bug 8296: set input maxlength to the same of sql field length -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12240|0 |1 is obsolete| | --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13081&action=edit Bug 8296: Follow up for QA 1 redefined variable removed Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> --- All patches rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|m.de.rooy@rijksmuseum.nl |jonathan.druart@biblibre.co | |m --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: Add a new DB field serial.publisheddatetext. The patch adds this new field to the serials update routines and to the serial templates (serials-collection, serials-edit, subscription-detail and opac-full-serial-issues). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I would like to get a second QA team sign-off on these patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- In fact there is no sign-off on these patchs. Switch back to "Needs Signoff" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 cedric.vita@dracenie.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |cedric.vita@dracenie.com --- Comment #23 from cedric.vita@dracenie.com --- Something went wrong ! Applying: Bug 8296: Add descriptive (text) published date field for serials Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Serials.pm Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tt Auto-merging misc/cronjobs/serialsUpdate.pl Auto-merging serials/serials-collection.pl Auto-merging serials/serials-edit.pl Failed to merge in the changes. Patch failed at 0001 Bug 8296: Add descriptive (text) published date field for serials When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 8296 - Add descriptive (text) published date field for serials Bug 8296: Add descriptive (text) published date field for serials Apply? [yn] Patch left in /tmp/Bug-8296-Add-descriptive-text-published-date-field-ZKRcFi.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13079|0 |1 is obsolete| | --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16315&action=edit Bug 8296: Add descriptive (text) published date field for serials Add a new field serial.publisheddatetext for displaying published date in another format that dateformat syspref permit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13080|0 |1 is obsolete| | --- Comment #25 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16316&action=edit Bug 8296: set input maxlength to the same of sql field length -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13081|0 |1 is obsolete| | --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16317&action=edit Bug 8296: Follow up for QA 1 redefined variable removed Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois@bibl | |ibre.com --- Comment #27 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- ok for me the patch applies correctly, you can test -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #28 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #29 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16406&action=edit Bug 8296: Follow up for QA 1 redefined variable removed Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16315|0 |1 is obsolete| | --- Comment #30 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 16420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16420&action=edit Bug 8296: Add descriptive (text) published date field for serials Patch signed of with sandbox by Cédric Vita -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16316|0 |1 is obsolete| | --- Comment #31 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 16421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16421&action=edit Bug 8296: set input maxlength to the same of sql field length Patch signed off by Cédric Vita -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16317|0 |1 is obsolete| | Attachment #16406|0 |1 is obsolete| | --- Comment #32 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 16422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16422&action=edit Bug 8296: Follow up for QA Patch signed off by Cédric Vita -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16420|0 |1 is obsolete| | --- Comment #33 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18796&action=edit Bug 8296: Add descriptive (text) published date field for serials Add a new field serial.publisheddatetext for displaying published date in another format that dateformat syspref permit. Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16421|0 |1 is obsolete| | --- Comment #34 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18797&action=edit Bug 8296: set input maxlength to the same of sql field length Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16422|0 |1 is obsolete| | --- Comment #35 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18798&action=edit Bug 8296: Follow up for QA 1 redefined variable removed Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #36 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- One warning, no complaints from qa-tools. Argument "" isn't numeric in numeric lt (<) at /usr/share/koha/testclone/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt line 241. Seems not to be introduced by your patches, though. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #37 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I actually miss a test plan for this report. I have the impresssion that the opac change is only visible under specific circumstances (pref value and/or unimarc??) This needs more information/documentation. Please add. Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #38 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- See this in the rebase of kohastructure: + `itemnumber` text default NULL, Should not be reintroduced.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18796|0 |1 is obsolete| | --- Comment #39 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 18811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18811&action=edit [SIGNED-OFF] Bug 8296: Add descriptive (text) published date field for serials Add a new field serial.publisheddatetext for displaying published date in another format that dateformat syspref permit. Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18797|0 |1 is obsolete| | --- Comment #40 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 18812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18812&action=edit [SIGNED-OFF] Bug 8296: set input maxlength to the same of sql field length Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18798|0 |1 is obsolete| | --- Comment #41 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 18813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18813&action=edit [SIGNED-OFF] Bug 8296: Follow up for QA 1 redefined variable removed Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #42 from Julian Maurice <julian.maurice@biblibre.com> --- Patches rebased on master serials.itemnumber is no longer added by these patches Test plan: - Search for a subscription and go to serial collection page - check some serials and click edit - modify text under "published on (text)" column and save - in opac, go to record detail, then click "subscriptions" tab » "More details" » "Full history" tab - you should see the text you entered. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have started testing this yesterday and after sleeping over it, there is something that worries me: 1) After update, the new column publisheddatetext is empty in the database for all existing issues, but when you receive new issues, the field is always filled with the publisheddate if you don't change it manually. My feeling is, that we should not fill the field, when there is no new information in it. Also, is it helpful if you have to delete the date first before you can type in "April 2013"? In the templates that would work nicely as they already fall back to the publisheddate when the new field is empty: [% newserialloo.publisheddatetext || newserialloo.publisheddate %] 2) If you are going to touch the patches - could you also add the bug number to the updatedatabase? 3) The table in serials-edit.pl is a little broken, when you are adding items for each issue. The colspan needs to be increased to 6 there now in the last row. <td colspan="5"> <a id="label[% serialslis.subscriptionid %]..."> Click to add item</a> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart@biblibre.co |testopia@bugs.koha-communit |m |y.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #44 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 19860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19860&action=edit Bug 8296: Don't fill text field automatically + minor fixes: * Add bug number to updatedatabase * Fix colspan in serials-edit.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #45 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Katrin, thank you for the review. This patch fixes 1) 2) and 3) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #46 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 8296: Add descriptive (text) published date field for serials Using index info to reconstruct a base tree... M C4/Serials.pm M installer/data/mysql/kohastructure.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt M koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tt M serials/serials-edit.pl Falling back to patching base and 3-way merge... Auto-merging serials/serials-edit.pl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Serials.pm Patch failed at 0001 Bug 8296: Add descriptive (text) published date field for serials The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18811|0 |1 is obsolete| | --- Comment #47 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21341&action=edit [SIGNED-OFF] Bug 8296: Add descriptive (text) published date field for serials Add a new field serial.publisheddatetext for displaying published date in another format that dateformat syspref permit. Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18812|0 |1 is obsolete| | --- Comment #48 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21342&action=edit [SIGNED-OFF] Bug 8296: set input maxlength to the same of sql field length Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18813|0 |1 is obsolete| | --- Comment #49 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21343&action=edit [SIGNED-OFF] Bug 8296: Follow up for QA 1 redefined variable removed Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19860|0 |1 is obsolete| | --- Comment #50 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21344&action=edit Bug 8296: Don't fill text field automatically + minor fixes: * Add bug number to updatedatabase * Fix colspan in serials-edit.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #51 from Julian Maurice <julian.maurice@biblibre.com> --- All patches rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-24 last check this| | --- Comment #52 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot|2013-09-24 00:00:00 |2013-10-25 last check this| | --- Comment #53 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 8296: Add descriptive (text) published date field for serials Using index info to reconstruct a base tree... M C4/Serials.pm M installer/data/mysql/kohastructure.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt M misc/cronjobs/serialsUpdate.pl Falling back to patching base and 3-way merge... Auto-merging misc/cronjobs/serialsUpdate.pl CONFLICT (content): Merge conflict in misc/cronjobs/serialsUpdate.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Serials.pm Patch failed at 0001 Bug 8296: Add descriptive (text) published date field for serials The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21341|0 |1 is obsolete| | --- Comment #54 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22727&action=edit [SIGNED-OFF] Bug 8296: Add descriptive (text) published date field for serials Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21342|0 |1 is obsolete| | --- Comment #55 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22728&action=edit [SIGNED-OFF] Bug 8296: set input maxlength to the same of sql field length Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21343|0 |1 is obsolete| | --- Comment #56 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22729&action=edit [SIGNED-OFF] Bug 8296: Follow up for QA Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21344|0 |1 is obsolete| | --- Comment #57 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22730&action=edit Bug 8296: Don't fill text field automatically Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha@univ-lyon3.fr --- Comment #58 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- h1>Something went wrong !</h1>Applying: Bug 8296: Add descriptive (text) published date field for serials Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Serials.pm CONFLICT (content): Merge conflict in C4/Serials.pm Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tt Auto-merging misc/cronjobs/serialsUpdate.pl Auto-merging serials/serials-collection.pl Failed to merge in the changes. Patch failed at 0001 Bug 8296: Add descriptive (text) published date field for serials When you have resolved this problem run git bz apply --continue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22727|0 |1 is obsolete| | --- Comment #59 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 28974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28974&action=edit Bug 8296: Add descriptive (text) published date field for serials Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22728|0 |1 is obsolete| | --- Comment #60 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 28975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28975&action=edit Bug 8296: set input maxlength to the same of sql field length Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22729|0 |1 is obsolete| | --- Comment #61 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 28976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28976&action=edit Bug 8296: Follow up for QA Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22730|0 |1 is obsolete| | --- Comment #62 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 28977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28977&action=edit Bug 8296: Don't fill text field automatically Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #63 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I add a text formatted date in the Serial collection page like this : Date published Date published (text) 01/04/2014 mai 2014 but the date at the opac (moredetails/fullhistory/date column) remains 01/04/2014. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28974|0 |1 is obsolete| | --- Comment #64 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30379&action=edit Bug 8296: Add descriptive (text) published date field for serials Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28975|0 |1 is obsolete| | --- Comment #65 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30380&action=edit Bug 8296: set input maxlength to the same of sql field length Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28976|0 |1 is obsolete| | --- Comment #66 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30381&action=edit Bug 8296: Follow up for QA Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28977|0 |1 is obsolete| | --- Comment #67 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30382&action=edit Bug 8296: Don't fill text field automatically Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #68 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30383&action=edit Bug 8296: Display publisheddatetext in OPAC bootstrap theme and remove modifications for OPAC prog theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30381|0 |1 is obsolete| | --- Comment #69 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30483&action=edit Bug 8296: Follow up for QA 1 redefined variable removed Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30383|0 |1 is obsolete| | --- Comment #70 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30484&action=edit Bug 8296: Display publisheddatetext in OPAC bootstrap theme and remove modifications for OPAC prog theme Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30382|0 |1 is obsolete| | --- Comment #71 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30485&action=edit Bug 8296: Don't fill text field automatically + minor fixes: * Add bug number to updatedatabase * Fix colspan in serials-edit.tt Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #72 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've applied the patches, ran the database update and then tried to run the unit tests specific for serials, sadly, they are failing with these patches, but are ok on master: Test Summary Report ------------------- t/db_dependent/Serials.t (Wstat: 1024 Tests: 44 Failed: 4) Failed tests: 39-40, 42-43 Non-zero exit status: 4 The QA script was ok, no problems there. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #73 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 32124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32124&action=edit Bug 8296: Fix unit tests in t/db_dependent/Serials.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but I am having problems to get this to apply :( I fixed a conflict in the first patch but then got stuck later on number 5. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30379|0 |1 is obsolete| | --- Comment #75 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 32903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32903&action=edit Bug 8296: Add descriptive (text) published date field for serials Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30380|0 |1 is obsolete| | --- Comment #76 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 32904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32904&action=edit Bug 8296: set input maxlength to the same of sql field length Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30483|0 |1 is obsolete| | --- Comment #77 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 32905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32905&action=edit Bug 8296: Follow up for QA Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30485|0 |1 is obsolete| | --- Comment #78 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 32906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32906&action=edit Bug 8296: Don't fill text field automatically Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30484|0 |1 is obsolete| | --- Comment #79 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 32907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32907&action=edit Bug 8296: Display publisheddatetext in OPAC bootstrap theme Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32124|0 |1 is obsolete| | --- Comment #80 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 32908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32908&action=edit Bug 8296: Fix unit tests in t/db_dependent/Serials.t Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #81 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, I have a few questions about this: For the OPAC, you only change the full history: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt Why not the normal one on opac-detail.tt? If we only change one view, the displayed dates seem to be inconsistent. I am also wondering about you display the publisheddate in staff, when there is nothing set for publisheddate. This way it's really hard to see in the lists, where you have entered custom data and where not. I am suggesting to change that and only display publisheddatetext when we have both columns next to each other. I will attach a patch with that suggestion - but not sure what to do about the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #82 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah, also applying rebaesd patches - I removed the prog theme OPAC files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32903|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32904|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32905|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32906|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32907|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32908|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #83 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33006&action=edit Bug 8296: Add descriptive (text) published date field for serials Add a new field serial.publisheddatetext for displaying published date in another format that dateformat syspref permit. Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #84 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33007&action=edit Bug 8296: set input maxlength to the same of sql field length Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #85 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33008&action=edit Bug 8296: Follow up for QA 1 redefined variable removed Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #86 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33009&action=edit Bug 8296: Don't fill text field automatically + minor fixes: * Add bug number to updatedatabase * Fix colspan in serials-edit.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #87 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33010&action=edit Bug 8296: Display publisheddatetext in OPAC bootstrap theme and remove modifications for OPAC prog theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #88 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33011&action=edit Bug 8296: Fix unit tests in t/db_dependent/Serials.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #89 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33012&action=edit Bug 8296: Follow-up - don't display publisheddate when publisheddatetext is empty To test: - make sure you have a subscription where only some fields have a published date (text) set - check the subscription detail page, issues tab - check the serial collection page - both pages should show an empty field, when published date (text) has not been set -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #90 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- After 'sleeping over it' I think the duplication of the 'published date' into 'published date (text)' was maybe done for sorting purposes? Maybe we could make it visually more clear, using a different text color (grey?) for a published date in a published date (text) column? I hope this makes any sense. Feel free to dislike and obsolete my follow-up :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #91 from Julian Maurice <julian.maurice@biblibre.com> --- Why is the bug status "Failed QA" ? Shouldn't it be "Needs Signoff" ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33006|0 |1 is obsolete| | --- Comment #92 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35865&action=edit Bug 8296: Add descriptive (text) published date field for serials Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33007|0 |1 is obsolete| | --- Comment #93 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35866&action=edit Bug 8296: set input maxlength to the same of sql field length Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33008|0 |1 is obsolete| | --- Comment #94 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35867&action=edit Bug 8296: Follow up for QA Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33009|0 |1 is obsolete| | --- Comment #95 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35868&action=edit Bug 8296: Don't fill text field automatically Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33010|0 |1 is obsolete| | --- Comment #96 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35869&action=edit Bug 8296: Display publisheddatetext in OPAC bootstrap theme Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33011|0 |1 is obsolete| | --- Comment #97 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35870&action=edit Bug 8296: Fix unit tests in t/db_dependent/Serials.t Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33012|0 |1 is obsolete| | --- Comment #98 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35871&action=edit Bug 8296: Follow-up - don't display publisheddate when publisheddatetext is empty Rebased on master and signed off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #99 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Going to work on this next. Julian - could you check the last patch if you like or hate it? I have no problem with either, but would be good to have your feedback. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #100 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Katrin, Your patch is ok, no problem at all, it is already signed off ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #101 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, I have started on this and so far it looks good, but I am a little confused about the general idea of this: - Could you maybe give some more explanation about the use case? - Why do we display it almost everywhere in staff, but only on a very hidden page in the OPAC? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #102 from Julian Maurice <julian.maurice@biblibre.com> --- 1/ The initial need was to "describe" the date in a more human-friendly format. For instance, if periodicity is "once every two months", instead of 2015-01-01 we can have "2015 January-February" 2/ I don't know very well the subscriptions part in OPAC. I can add this information in other pages as well, if you tell me where :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #103 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, I think the common "entry page" to subscriptions for parons in the OPAC is opac-detail > subscriptions tab. This view is labelled as 'Normal view' when you look at it from the the full history page. I think adding the information there the same way we have it on the full history page would make sense to me. I am a bit torn about the feature still, but I think with that follow-up it would make enough sense to me to pass QA. Patches tested ok so far. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35865|0 |1 is obsolete| | --- Comment #104 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41830&action=edit Bug 8296: Add descriptive (text) published date field for serials Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35866|0 |1 is obsolete| | --- Comment #105 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41831&action=edit Bug 8296: set input maxlength to the same of sql field length Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35867|0 |1 is obsolete| | --- Comment #106 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41832&action=edit Bug 8296: Follow up for QA Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35868|0 |1 is obsolete| | --- Comment #107 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41833&action=edit Bug 8296: Don't fill text field automatically Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35869|0 |1 is obsolete| | --- Comment #108 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41834&action=edit Bug 8296: Display publisheddatetext in OPAC bootstrap theme Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35870|0 |1 is obsolete| | --- Comment #109 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41835&action=edit Bug 8296: Fix unit tests in t/db_dependent/Serials.t Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35871|0 |1 is obsolete| | --- Comment #110 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41836&action=edit Bug 8296: Follow-up - don't display publisheddate when publisheddatetext is empty Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #111 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Katrin Fischer from comment #103)
Hi Julian,
I think the common "entry page" to subscriptions for parons in the OPAC is opac-detail > subscriptions tab. This view is labelled as 'Normal view' when you look at it from the the full history page. I think adding the information there the same way we have it on the full history page would make sense to me.
It appears that the date shown on this page is the 'planneddate' which is the date of reception. Should we change that and display the 'publisheddate' instead ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #112 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Julian Maurice from comment #111)
(In reply to Katrin Fischer from comment #103)
Hi Julian,
I think the common "entry page" to subscriptions for parons in the OPAC is opac-detail > subscriptions tab. This view is labelled as 'Normal view' when you look at it from the the full history page. I think adding the information there the same way we have it on the full history page would make sense to me.
It appears that the date shown on this page is the 'planneddate' which is the date of reception. Should we change that and display the 'publisheddate' instead ?
Sorry to come back to this so late - I feel like it is a little weird to not display in the OPAC, but not sure right now how best to fix. I will look at the patches again. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41830|0 |1 is obsolete| | Attachment #41831|0 |1 is obsolete| | Attachment #41832|0 |1 is obsolete| | Attachment #41833|0 |1 is obsolete| | Attachment #41834|0 |1 is obsolete| | Attachment #41835|0 |1 is obsolete| | Attachment #41836|0 |1 is obsolete| | --- Comment #113 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43665&action=edit [PASSED QA] Bug 8296: Add descriptive (text) published date field for serials Add a new field serial.publisheddatetext for displaying published date in another format that dateformat syspref permit. Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #114 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43666&action=edit [PASSED QA] Bug 8296: set input maxlength to the same of sql field length Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #115 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43667&action=edit [PASSED QA] Bug 8296: Follow up for QA 1 redefined variable removed Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #116 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43668&action=edit [PASSED QA] Bug 8296: Don't fill text field automatically + minor fixes: * Add bug number to updatedatabase * Fix colspan in serials-edit.tt Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #117 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43669&action=edit [PASSED QA] Bug 8296: Display publisheddatetext in OPAC bootstrap theme and remove modifications for OPAC prog theme Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #118 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43670&action=edit [PASSED QA] Bug 8296: Fix unit tests in t/db_dependent/Serials.t Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #119 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43671&action=edit [PASSED QA] Bug 8296: Follow-up - don't display publisheddate when publisheddatetext is empty To test: - make sure you have a subscription where only some fields have a published date (text) set - check the subscription detail page, issues tab - check the serial collection page - both pages should show an empty field, when published date (text) has not been set Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #120 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have to admit, I am not sure about the use case for this patch, but it works as described and shouldn't affect the existing workflows. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #121 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #122 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 45469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45469&action=edit serials area where text shows I'm documenting this and am wondering where the text displays other than in the serials module. Shouldn't is show in the holdings area? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #123 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nicole, 3 spots it shows are: Staff - subscription detail page, issues tab - serial collection page OPAC - full history There was some discussion about where else it should show - so there is probably some room for improvement :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org