[Bug 40262] New: ILL - Save the fact that copyright clearance has been confirmed by the patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 Bug ID: 40262 Summary: ILL - Save the fact that copyright clearance has been confirmed by the patron Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com, pedro.amorim@openfifth.co.uk, tomascohen@gmail.com The current functionality of ILLModuleCopyrightClearance blocks the patron from creating an ILL request in the OPAC unless they click 'Yes'. This is working like this by design but nowhere in the database this fact is recorded. Some libraries require this to be recorded in the database for legal and other purposes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk, | |n.halford-busby@lboro.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 183607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183607&action=edit Bug 40262: Save and display copyrightclearance_confirmed Test plan, k-t-d: 1) Enable ILLModule 2) Add a new HTML customization, visit: <staff_url>/cgi-bin/koha/tools/additional-contents.pl?op=add_form&category=html_customizations&editmode=wysiwyg 3) Pick ILLModuleCopyrightClearance as the 'Display location' 4) Pick a 'Publication date' in the past 5) Add a title and content. Save. 6) Create a new ILL request in the OPAC, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 7) Notice the copyright clearance step is shown. Click 'Yes'. 8) Enter a 'type' and (optionally) some metadata. Click 'Create'. 9) Go back to the module in Staff UI and pick the request just created through the OPAC, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 10) Notice the message 'Patron has confirmed copyright clearance for this request' is shown next to the patron in the the request details -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183607|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 183662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183662&action=edit Bug 40262: Save and display copyrightclearance_confirmed Test plan, k-t-d: 1) Enable ILLModule 2) Add a new HTML customization, visit: <staff_url>/cgi-bin/koha/tools/additional-contents.pl?op=add_form&category=html_customizations&editmode=wysiwyg 3) Pick ILLModuleCopyrightClearance as the 'Display location' 4) Pick a 'Publication date' in the past 5) Add a title and content. Save. 6) Create a new ILL request in the OPAC, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 7) Notice the copyright clearance step is shown. Click 'Yes'. 8) Enter a 'type' and (optionally) some metadata. Click 'Create'. 9) Go back to the module in Staff UI and pick the request just created through the OPAC, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 10) Notice the message 'Patron has confirmed copyright clearance for this request' is shown next to the patron in the the request details Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement to release notes| |copyright clearance for | |interlibrary loan requests: | |- records the copyright | |clearance in the database | |(it previously wasn't) | |- shows the message "Patron | |has confirmed copyright | |clearance for this request" | |on the request page | | | |(This requires text in the | |ILLModuleCopyrightClearance | |HTML customization.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185096&action=edit Bug 40262: (QA follow-up): Fix compatibility with ILLOpacUnauthenticatedRequest This patch fixes the copyrightclearance_confirmed not saving if submitting an unauthenticated ILL request. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I understand where this is coming from. But I'm now comfortable with this not being baked into a library and tested. Would you agree with a follow-up patch adding a dedicated method in `Koha::ILL::Request` to be called from the controller? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #4)
I understand where this is coming from. But I'm now comfortable with this not being baked into a library and tested. Would you agree with a follow-up patch adding a dedicated method in `Koha::ILL::Request` to be called from the controller?
Yes, of course. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183662|0 |1 is obsolete| | Attachment #185096|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186729&action=edit Bug 40262: Save and display copyrightclearance_confirmed Test plan, k-t-d: 1) Enable ILLModule 2) Add a new HTML customization, visit: <staff_url>/cgi-bin/koha/tools/additional-contents.pl?op=add_form&category=html_customizations&editmode=wysiwyg 3) Pick ILLModuleCopyrightClearance as the 'Display location' 4) Pick a 'Publication date' in the past 5) Add a title and content. Save. 6) Create a new ILL request in the OPAC, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 7) Notice the copyright clearance step is shown. Click 'Yes'. 8) Enter a 'type' and (optionally) some metadata. Click 'Create'. 9) Go back to the module in Staff UI and pick the request just created through the OPAC, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 10) Notice the message 'Patron has confirmed copyright clearance for this request' is shown next to the patron in the the request details Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 --- Comment #7 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186730&action=edit Bug 40262: (QA follow-up): Fix compatibility with ILLOpacUnauthenticatedRequest This patch fixes the copyrightclearance_confirmed not saving if submitting an unauthenticated ILL request. Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186731&action=edit Bug 40262: (follow-up) Refactor copyright clearance to use dedicated methods This patch refactors the copyright clearance confirmation functionality to follow proper separation of concerns by moving business logic from the controller to the model. Changes: - Add set_copyright_clearance_confirmed() method to Koha::ILL::Request - Add get_copyright_clearance_confirmed() method to Koha::ILL::Request - Update controller to use dedicated method instead of direct attribute manipulation - Update staff template to use the new dedicated accessor method - Add comprehensive test coverage for both methods Benefits: - Improved separation of concerns (business logic in model) - Consistency with existing patterns (get_type, get_type_disclaimer_value) - Better reusability and testability - Centralized attribute name management Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/ILL/Request/CopyrightClearance.t => SUCCESS: Tests pass! New methods work correctly 3. Test ILL copyright clearance workflow still works: - Enable ILLModule - Create HTML customization for ILLModuleCopyrightClearance - Create OPAC ILL request with copyright clearance - Verify confirmation is saved and displayed in staff interface 4. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 --- Comment #9 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Please confirm if you agree with the follow-up patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40850 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40850 [Bug 40850] Add `Koha::ILL::Request->add_or_update_attributes` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186731|0 |1 is obsolete| | --- Comment #10 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186824&action=edit Bug 40262: (follow-up) Refactor copyright clearance to use dedicated methods This patch refactors the copyright clearance confirmation functionality to follow proper separation of concerns by moving business logic from the controller to the model. Changes: - Add set_copyright_clearance_confirmed() method to Koha::ILL::Request - Add get_copyright_clearance_confirmed() method to Koha::ILL::Request - Update controller to use dedicated method instead of direct attribute manipulation - Update staff template to use the new dedicated accessor method - Add comprehensive test coverage for both methods Benefits: - Improved separation of concerns (business logic in model) - Consistency with existing patterns (get_type, get_type_disclaimer_value) - Better reusability and testability - Centralized attribute name management Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/ILL/Request.t => SUCCESS: Tests pass! New methods work correctly 3. Test ILL copyright clearance workflow still works: - Enable ILLModule - Create HTML customization for ILLModuleCopyrightClearance - Create OPAC ILL request with copyright clearance - Verify confirmation is saved and displayed in staff interface 4. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> PA amended: Test file name in commit message Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40262 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org