[Bug 23601] New: Middle clicking a title from search results creates two tabs or a new tab and a new window in Firefox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Bug ID: 23601 Summary: Middle clicking a title from search results creates two tabs or a new tab and a new window in Firefox Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: bdaeuber@cityoffargo.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When middle-clicking or ctrl-clicking a title in the results screen of the staff client, Firefox opens two new tabs. To reproduce: 1. Use a relatively recent version of Firefox (I've tested this on 68esr and 69) 2. Search for an item in the staff interface 3. From the results screen, middle click or control click a title. 4. Depending on your Firefox settings, Firefox will open an new window and a new tab or two new tabs. The popup blocker may also block the opening of these tabs. This appears to be related to the preventdefault() being used here, which Firefox handles differently than other browsers. There's the broader discussion of whether there's any need to use preventdefault() here at all. From the comments in the jquery it appears that someone thought it wasn't a good idea. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I've noticed this before too, but have never taken a hard look at a solution. It has something to do with the click handler added by the "browse search results" buttons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just tested and things seem to work ok now - please reopen if you can still see the buggy behavior! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Still happens for me -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 102089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102089&action=edit Bug 23601: Prevent default for auxclick The issue appears to be that the default action is not prevented for middle click because it registers an 'auxclick' event as opposed to a 'click' event To test: 1 - Perform a search in staff client 2 - Shift-click and hold on a result 3 - Note a new tab opens 4 - Release the click, no change 5 - Middle click and hold on a result 6 - New tab opens 7 - Release, a second new tab opens 8 - Apply patch 9 - Reload page 10 - Middle click and hold 11 - New tab opens 12 - Release 13 - No new tab -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Nick! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102089|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 102102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102102&action=edit Bug 23601: Prevent default for auxclick The issue appears to be that the default action is not prevented for middle click because it registers an 'auxclick' event as opposed to a 'click' event To test: 1 - Perform a search in staff client 2 - Shift-click and hold on a result 3 - Note a new tab opens 4 - Release the click, no change 5 - Middle click and hold on a result 6 - New tab opens 7 - Release, a second new tab opens 8 - Apply patch 9 - Reload page 10 - Middle click and hold 11 - New tab opens 12 - Release 13 - No new tab Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- Tested on Ubuntu 18.04 with Firefox 74.0 and Firefox Developer Edition 75.0b11 (64-bit editions). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I cannot recreate that (Firefox 68.4.1esr) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #8)
I cannot recreate that (Firefox 68.4.1esr)
I do on Firefox 74.0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #9)
(In reply to Jonathan Druart from comment #8)
I cannot recreate that (Firefox 68.4.1esr)
I do on Firefox 74.0
Wait, I actually do! Lucky me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102102|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102141&action=edit Bug 23601: Prevent default for auxclick The issue appears to be that the default action is not prevented for middle click because it registers an 'auxclick' event as opposed to a 'click' event To test: 1 - Perform a search in staff client 2 - Shift-click and hold on a result 3 - Note a new tab opens 4 - Release the click, no change 5 - Middle click and hold on a result 6 - New tab opens 7 - Release, a second new tab opens 8 - Apply patch 9 - Reload page 10 - Middle click and hold 11 - New tab opens 12 - Release 13 - No new tab Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25027 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Let's do fix that correctly, please? See bug 25027. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25027 [Bug 25027] Result browser should not overload onclick event -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue in release notes| |Firefox where | |middle-clicking or | |CTRL-clicking a title in | |the results screen of the | |staff client opens two new | |tabs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | --- Comment #14 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 Status|Pushed to stable |Pushed to oldstable --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org