[Bug 5503] New: comments shouldn't show patron's full name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Summary: comments shouldn't show patron's full name Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: OPAC Comments AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 When leaving comments in the OPAC it shows the patron's full name. This is done without asking the patron if they approve of sharing that info. Either it should show the first name last initial, patron initials, or should give the patrons a choose of what name to show (like on most blogging applications). No matter what we shouldn't show the full name of the patron on the OPAC for all to see without asking them if it's okay. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2010-12-15 15:33:50 UTC --- See also http://wiki.koha-community.org/wiki/OPAC_Comments_RFC, specifically this proposal: In the OPAC the name displays currently would like to change that to a system preference offering display choices: o First and last name, First name, Last name, First name with Last Initial, none, nick, or login ID. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-02-22 12:45:38 UTC --- Just for the record: In file "opac-details.tmpl", line 692 : <h5> Comment by <!-- TMPL_VAR NAME="title" --> <!-- TMPL_VAR NAME="firstname" --> <!-- TMPL_VAR NAME="surname" --> </h5> This is something I could probably tackle today (we'll see if I get distracted with other work). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC Comments |OPAC -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution| |DUPLICATE --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-13 15:13:07 UTC --- *** This bug has been marked as a duplicate of bug 5897 *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-12-13 15:14:37 UTC --- This is not a duplicate - this asks for an enhancement to the preference about showing names - allowing the library to choose how the name displays. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED AssignedTo|gmcharlt@gmail.com |oleonard@myacpl.org --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-12-16 21:38:23 UTC --- Created attachment 6844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6844 Proposed fix Adding a few choices for what information can be displayed alongside comments in the OPAC: - nothing - full name - first name - last name - first name and last name first initial - username -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6844|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-12-17 18:03:19 UTC --- Created attachment 6845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6845 [SIGNED-OFF] Bug 5503 - comments shouldn't show patron's full name Adding a few choices for what information can be displayed alongside comments in the OPAC: - nothing - full name - first name - last name - first name and last name first initial - username Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested by choosing each choice and previewing an individual title with a comment and confirming the name was displayed properly. Then choosing each option and prevewing the recent comments page. All tests passed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #7 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-21 22:13:17 UTC --- Mostly a template change, making use of SWITCH (which we may not have access to in Perl 5.10, but we do in T:T!). Provides a plethora of options, and is easily extensible should need others. Marking Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Severity|minor |enhancement --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-27 17:25:55 UTC --- Changing severity, it's more an ENH than a bugfix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Failed QA --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-10 22:23:45 UTC --- QA comment Well, it seems this patch has not be tested. When upgrading, I get a mySQL error: [Tue Jan 10 23:19:12 2012] updatedatabase.pl: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 's identity is presented alongside comments in the OPAC', `type` = 'Choice' WHER' at line 1 at /home/paul/koha.dev/koha-community/installer/data/mysql/updatedatabase.pl line 4610. [Tue Jan 10 23:19:12 2012] updatedatabase.pl: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 's identity is presented alongside comments in the OPAC', `type` = 'Choice' WHER' at line 1 at /home/paul/koha.dev/koha-community/installer/data/mysql/updatedatabase.pl line 4611. Looking at the code, I see : $dbh->do(" UPDATE `koha`.`systempreferences` SET `value` = 'none', `options` = 'none|full|first|surname|firstandinitial|username', `explanation` = 'Choose how a commenter\'s identity is presented alongside comments in the OPAC', `type` = 'Choice' WHERE `systempreferences`.`variable` = 'ShowReviewer' AND `systempreferences`.`variable` = 0"); Should be commenter''s I think. Also note, as you'll have to send a follow-up that ` should be removed from table & column names, it's a mysql-ism thx -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6845|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> 2012-01-17 20:00:07 UTC --- Created attachment 7202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7202 Proposed fix, revised -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |adrien.saurat@biblibre.com --- Comment #11 from Adrien SAURAT <adrien.saurat@biblibre.com> 2012-02-03 09:41:24 UTC --- The database name is mentionned in the updatedatabase, my DB has a different name and the update failed. Would be good to replace `koha`.`systempreferences` by systempreferences (and remove the others ` characters). I'll get back to sign off asap, but as I was testing the pre-patch fonctionnality, I couldn't see the commenter's name in OPAC even when the ShowReviewer systempreference was activated. Am I missing something needed to activate this? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7202|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> 2012-02-13 17:41:31 UTC --- Created attachment 7632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7632 Bug 5503 [REVISED] comments shouldn't show patron's full name Adding a few choices for what information can be displayed alongside comments in the OPAC: - nothing - full name - first name - last name - first name and last name first initial - username Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested by choosing each choice and previewing an individual title with a comment and confirming the name was displayed properly. Then choosing each option and prevewing the recent comments page. All tests passed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 --- Comment #13 from Nicole C. Engard <nengard@gmail.com> 2012-02-14 19:47:04 UTC --- Owen, Does the revised patch need a sign off again? It says I signed off on the patch that is attached so I'm confused. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> 2012-02-14 19:53:01 UTC --- (In reply to comment #13)
Does the revised patch need a sign off again? It says I signed off on the patch that is attached so I'm confused.
Sorry, that must have been my mistake during preparing the patch. The patch does include (minor) revisions, so another signoff is in order. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #15 from Nicole C. Engard <nengard@gmail.com> 2012-02-26 21:08:53 UTC --- Bug 5503 [REVISED] comments shouldn't show patron's full name Apply? [yn] y Applying: Bug 5503 [REVISED] comments shouldn't show patron's full name error: patch failed: installer/data/mysql/updatedatabase.pl:4678 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 Bug 5503 [REVISED] comments shouldn't show patron's full name When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-5503-REVISED-comments-shouldnt-show-patrons-fu-tt1qCP.patch nengard@kohavm:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7632|0 |1 is obsolete| | --- Comment #16 from Owen Leonard <oleonard@myacpl.org> 2012-02-27 13:32:56 UTC --- Created attachment 7900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7900 Bug 5503 [REVISED] comments shouldn't show patron's full name Adding a few choices for what information can be displayed alongside comments in the OPAC: - nothing - full name - first name - last name - first name and last name first initial - username Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested by choosing each choice and previewing an individual title with a comment and confirming the name was displayed properly. Then choosing each option and prevewing the recent comments page. All tests passed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #17 from Owen Leonard <oleonard@myacpl.org> 2012-02-27 13:36:57 UTC --- Okay, yeah, that still says signed off. Hm. Anyway, the conflict was a garden-variety updatedatabase conflict. The new patch has been rebased against current master. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7900|0 |1 is obsolete| | --- Comment #18 from Nicole C. Engard <nengard@gmail.com> 2012-02-27 14:00:51 UTC --- Created attachment 7902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7902 [SIGNED-OFF] Bug 5503 [REVISED] comments shouldn't show patron's full name Adding a few choices for what information can be displayed alongside comments in the OPAC: - nothing - full name - first name - last name - first name and last name first initial - username Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested by choosing each choice and previewing an individual title with a comment and confirming the name was displayed properly. Then choosing each option and prevewing the recent comments page. All tests passed. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Ran all tests again and it works as explained. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7902|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-03-01 15:23:20 UTC --- Created attachment 7968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7968 [SIGNED-OFF] Bug 5503 [REVISED] comments shouldn't show patron's full name Rebased patch (conflicts in updatedatabase.pl) marked as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org