[Bug 24612] New: expirationdate blank if patron has more than one item from bib on hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Bug ID: 24612 Summary: expirationdate blank if patron has more than one item from bib on hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org It is impossible to print the expiration date on a hold slip (HOLD_SLIP) if the patron has more than one hold on that bib. The expirationdate comes back blank. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- I have confirmed by looking at [% hold.reserve_id %] that HOLD_SLIP is looking at the wrong hold record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- If I assign <<reserves.expirationdate>> to another variable, for some reason, [% hold.expirationdate %] works. Very wonky behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98738&action=edit Bug 24612: Make hold-transfer-slip take reserve_id To make sure we are going to display the correct hold's info we need to pass the reserve_id. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think this patch will fix the issue you have. Can you confirm? hold skip needs to be tested from return.pl (checkin) and circulation.pl (checkout) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98738|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98739&action=edit Bug 24612: Make hold-transfer-slip take reserve_id To make sure we are going to display the correct hold's info we need to pass the reserve_id. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Christopher, I'm not able to replicate this in Master. I tried to confirm the behavior before applying the patch and haven't gotten the expiration date to come up null. Can you please confirm the problem still exists and/or provide steps to replicate it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com --- Comment #7 from Lisette Scheer <lisetteslatah@gmail.com> --- (In reply to Andrew Fuerste-Henry from comment #6)
Christopher, I'm not able to replicate this in Master. I tried to confirm the behavior before applying the patch and haven't gotten the expiration date to come up null. Can you please confirm the problem still exists and/or provide steps to replicate it?
I was able to replicate is this way: 1. In notices and slips, add [% hold.reserve_id %] to your hold slip. 2. Place 2 bib level holds for the same patron on a bib. 3. Check in one of the items and click print slip. 4. Observe that the slip doesn't have an expiration date at all. 5. Cancel the waiting hold. 6. Check in the other item and click print slip. 7. Observe the expiration date on the slip. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #8 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- I've tested and I can't get the patch to solve the problem. This is what I did: TEST PLAN: 1. Add some content to HOLD_SLIP notice, e.g. <h2>[% branch.branchname %]</h2> <div>[% biblio.author %]<br>[% biblio.title %]<br>[% item.barcode %] <ul><li> Reserve ID: [% hold.reserve_id %]</li> <li>Expiration date: [% hold.expirationdate %]</li></ul> 2. Add 2 holds for 1 patron to a single record 3. Check the reserve IDs in the reserves table - on a clean sandbox, they will be 1 and 2 4. Check in one of the items from the record and print the slip 5. Note that the reserve ID on the slip is 2 and the expiration date is blank 6. Repeated check ins do not change this 7. Check in a second item from the record 8. Note that the reserve ID for this hold is also 2, but this time the expiration date is filled in 9. Check in the first item again - the reserve ID stays as 2, but this time the expiration date is filled in I repeated this several times, and the odd numbered holds (1, 3, 5, 7 etc) never appear - but the even ones appear for all items (2, 4, 6, 8). I set the bug as Failed QA because it doesn't seem to solve the problem - is that the correct status? Or should I have chosen Patch Doesn't Apply? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98739|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102818&action=edit Bug 24612: Make hold-transfer-slip take reserve_id To make sure we are going to display the correct hold's info we need to pass the reserve_id. See comment 7 and 8 for test plans -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102819&action=edit Bug 24612: Add tests ReserveSlip call need to be adjusted in test. We also add a new reserve (same biblio, same patron) to highlight the problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102820&action=edit Bug 24612: Use the reserve_id to identify a reserve when building a notice Now that we have the reserve_id PK on the reserves table we should use it (instead of the couple borrowernumber, biblionumber) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Sally from comment #8)
I've tested and I can't get the patch to solve the problem.
I think it's now fixed with the last patchset!
I set the bug as Failed QA because it doesn't seem to solve the problem - is that the correct status? Or should I have chosen Patch Doesn't Apply?
"Failed QA" is the correct status when the patches do no work as you expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102818|0 |1 is obsolete| | --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 104803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104803&action=edit Bug 24612: Make hold-transfer-slip take reserve_id To make sure we are going to display the correct hold's info we need to pass the reserve_id. == Test plan == 1. Add some content to HOLD_SLIP notice, e.g. <h2>[% branch.branchname %]</h2> <div>[% biblio.author %]<br>[% biblio.title %]<br>[% item.barcode %] <ul><li> Reserve ID: [% hold.reserve_id %]</li> <li>Expiration date: [% hold.expirationdate %]</li></ul> 2. Add 2 holds for 1 patron to a single record 3. Check the reserve IDs in the reserves table - on a clean sandbox, they will be 1 and 2 4. Check in one of the items from the record and print the slip 5. Note that the reserve ID on the slip is 2 and the expiration date is blank 6. Repeated check ins do not change this 7. Check in a second item from the record 8. Note that the reserve ID for this hold is also 2, but this time the expiration date is filled in 9. Check in the first item again - the reserve ID stays as 2, but this time the expiration date is filled in 10. Apply patch 11. cancel the holds to come back to a clean state (and maybe ensure items aren't in transit) 12. redo the test and see the following differences 13. 1st checkin: 1. expiration date ok 2. the reserve ID is the one of the first hold 14. 2nd checkin: 1. expiration date ok 2. the reserve ID is the one of the second hold Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102819|0 |1 is obsolete| | --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 104804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104804&action=edit Bug 24612: Add tests ReserveSlip call need to be adjusted in test. We also add a new reserve (same biblio, same patron) to highlight the problem. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102820|0 |1 is obsolete| | --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 104805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104805&action=edit Bug 24612: Use the reserve_id to identify a reserve when building a notice Now that we have the reserve_id PK on the reserves table we should use it (instead of the couple borrowernumber, biblionumber) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |victor@tuxayo.net --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works! (an so the automated tests) thanks Jonathan. :D Thanks Lisette and Sally for the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104803|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105202&action=edit Bug 24612: Make hold-transfer-slip take reserve_id To make sure we are going to display the correct hold's info we need to pass the reserve_id. == Test plan == 1. Add some content to HOLD_SLIP notice, e.g. <h2>[% branch.branchname %]</h2> <div>[% biblio.author %]<br>[% biblio.title %]<br>[% item.barcode %] <ul><li> Reserve ID: [% hold.reserve_id %]</li> <li>Expiration date: [% hold.expirationdate %]</li></ul> 2. Add 2 holds for 1 patron to a single record 3. Check the reserve IDs in the reserves table - on a clean sandbox, they will be 1 and 2 4. Check in one of the items from the record and print the slip 5. Note that the reserve ID on the slip is 2 and the expiration date is blank 6. Repeated check ins do not change this 7. Check in a second item from the record 8. Note that the reserve ID for this hold is also 2, but this time the expiration date is filled in 9. Check in the first item again - the reserve ID stays as 2, but this time the expiration date is filled in 10. Apply patch 11. cancel the holds to come back to a clean state (and maybe ensure items aren't in transit) 12. redo the test and see the following differences 13. 1st checkin: 1. expiration date ok 2. the reserve ID is the one of the first hold 14. 2nd checkin: 1. expiration date ok 2. the reserve ID is the one of the second hold Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104804|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105203&action=edit Bug 24612: Add tests ReserveSlip call need to be adjusted in test. We also add a new reserve (same biblio, same patron) to highlight the problem. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104805|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105204&action=edit Bug 24612: Use the reserve_id to identify a reserve when building a notice Now that we have the reserve_id PK on the reserves table we should use it (instead of the couple borrowernumber, biblionumber) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105253&action=edit Bug 24612: Fix existing ReserveSlip tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105253|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105254&action=edit Bug 24612: Fix existing ReserveSlip tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105254|0 |1 is obsolete| | --- Comment #23 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 105775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105775&action=edit Bug 24612: Fix existing ReserveSlip tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |aleisha@catalyst.net.nz Version(s)|20.05.00 |20.05.00, 19.11.07 released in| | --- Comment #24 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 --- Comment #25 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Patch a bit too large to warrant a backport to oldoldstable (19.05.x) considering it's severity is only of level "normal" And there is a non-trivial conflict when cherry-picking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 14099 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@koha-us.org | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org