[Bug 28454] New: Add Koha version number to database schema link in reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Bug ID: 28454 Summary: Add Koha version number to database schema link in reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org In reports, the link to the database schema points to the main page and the user must select their version. We know what version they're using, so we should append the version number to the link so that it takes them directly there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 121429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121429&action=edit Bug 28454: Add Koha version number to database schema link in reports This patch modifies the guided reports script, adding a verion check so that a version string can be added to the database schema link if the user is using a non-development version. To test, apply the patch and go to reports -> Saved reports. - In the left-hand sidebar menu you should see a "Koha database schema" link. Depending on which version you're using, it may or may not have a version string included, e.g. "http://schema.koha-community.org/20_05" - In master, there is no version string added because there is no schema available for development versions. - If you apply the patch on a previous version, e.g. 'origin/20.11.x' you will see a link directly to that schema page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121429|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 121491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121491&action=edit Bug 28454: Add Koha version number to database schema link in reports This patch modifies the guided reports script, adding a verion check so that a version string can be added to the database schema link if the user is using a non-development version. To test, apply the patch and go to reports -> Saved reports. - In the left-hand sidebar menu you should see a "Koha database schema" link. Depending on which version you're using, it may or may not have a version string included, e.g. "http://schema.koha-community.org/20_05" - In master, there is no version string added because there is no schema available for development versions. - If you apply the patch on a previous version, e.g. 'origin/20.11.x' you will see a link directly to that schema page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- tested in origin/20.05.x and origin/20.11.x works well in both and this is a handy enhancement! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, could you please fix the link on the start page of the reports module as well? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121491|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123801&action=edit Bug 28454: Add Koha version number to database schema link in reports This patch modifies the guided reports script, adding a verion check so that a version string can be added to the database schema link if the user is using a non-development version. To test, apply the patch and go to reports -> Saved reports. - In the left-hand sidebar menu you should see a "Koha database schema" link. Depending on which version you're using, it may or may not have a version string included, e.g. "http://schema.koha-community.org/20_05" - In master, there is no version string added because there is no schema available for development versions. - If you apply the patch on a previously released version, e.g. 'tags/v20.11.08' you will see a link directly to that schema page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123802&action=edit Bug 28454: (follow-up) Add schema version to link on reports home page This patch makes the same changes to the script and template for the reports home page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123801|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123917&action=edit Bug 28454: Add Koha version number to database schema link in reports This patch modifies the guided reports script, adding a verion check so that a version string can be added to the database schema link if the user is using a non-development version. To test, apply the patch and go to reports -> Saved reports. - In the left-hand sidebar menu you should see a "Koha database schema" link. Depending on which version you're using, it may or may not have a version string included, e.g. "http://schema.koha-community.org/20_05" - In master, there is no version string added because there is no schema available for development versions. - If you apply the patch on a previously released version, e.g. 'tags/v20.11.08' you will see a link directly to that schema page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123802|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123918&action=edit Bug 28454: (follow-up) Add schema version to link on reports home page This patch makes the same changes to the script and template for the reports home page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |jonathan.druart+koha@gmail. | |com --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The second patch is removing lines that is not related to this change (and not advertised in the commit message). Is that expected? Moreover you are duplicating code (that exists already), why don't you use 'Koha.Version' from the template instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123917|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123918|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 124084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124084&action=edit Bug 28454: [ALTERNATIVE PATCH] Add Koha version number to database schema link in reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Owen, this is what I had in mind. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Assignee|oleonard@myacpl.org |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124084|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125073&action=edit Bug 28454: [ALTERNATIVE PATCH] Add Koha version number to database schema link in reports Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125074&action=edit Bug 28454: (follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125073|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125316&action=edit Bug 28454: [ALTERNATIVE PATCH] Add Koha version number to database schema link in reports Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125074|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125317&action=edit Bug 28454: (follow-up) Add missing filters Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patches will be squashed when pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 25525 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org