https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron@biblibre.c | |om --- Comment #14 from didier <didier.gautheron@biblibre.com> --- Hi, nitpicking here but IMO: - tests in their own commit make it easier for double checking they fail on unpatched code, as they must. - some patches could be squashed, thinking of git bisect. - Tests are done with 'AnonymousPatron' set to $anonymous_patron, so far so good, but what if AnonymousPatron is set to a different patron or unset? It's not obvious if it's covered by older tests. Regards Didier -- You are receiving this mail because: You are watching all bug changes.