[Bug 41638] New: Patron record field labels lack distinct id in HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Bug ID: 41638 Summary: Patron record field labels lack distinct id in HTML Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Libraries commonly use jQuery to reword the labels on various fields in the patron record (like changing "Surname" to "Last name"). Those field labels lack distinct IDs, which makes targeting them with jQuery more complicated and fragile: $('.label:contains("Surname")').text('Last name:'); $('label[for="surname"]').text("Last name:"); If that label had an ID like "#surname_label" it would simplify things. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lisette@bywatersolutions.co | |m CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 --- Comment #1 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 191519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191519&action=edit Bug 41638: Add IDs to labels on patron edit When targeting with jquery and css, labels on the patron edit screen can be fragile and complicated. This patch adds ids to all the labels that follow the following convention: <label for="surname" class="required" id="surname_label"> Each id is the "for" with _label appended. To Test: 1. Before applying the patch, go to add a new patron 2. Right click on the page and use the browser inspector/inspect element. 3. Observe there are no ids for the field labels. 4. Apply patch 5. Reload the page 6. Observe there are now ids for the fields. 7. Go through all the fields and confirm there is an id and that they follow the convention above. 8. Change mandatory fields and confirm the labels are still correct. 9. Edit an existing patron and confirm the ids are still present. 10. Sign off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds ids release notes| |to all the labels on | |memberentry.pl with the | |convention of <label | |for="surname" | |id="surname_label"> for | |easier jquery selection. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191519|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191878&action=edit Bug 41638: Add IDs to labels on patron edit When targeting with jquery and css, labels on the patron edit screen can be fragile and complicated. This patch adds ids to all the labels that follow the following convention: <label for="surname" class="required" id="surname_label"> Each id is the "for" with _label appended. To Test: 1. Before applying the patch, go to add a new patron 2. Right click on the page and use the browser inspector/inspect element. 3. Observe there are no ids for the field labels. 4. Apply patch 5. Reload the page 6. Observe there are now ids for the fields. 7. Go through all the fields and confirm there is an id and that they follow the convention above. 8. Change mandatory fields and confirm the labels are still correct. 9. Edit an existing patron and confirm the ids are still present. 10. Sign off! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191879&action=edit Bug 41638: (follow-up) Fix more instances, some markup errors I've added changes for member-alt-address-style.inc, member-alt-contact-style.inc, and member-main-address-style.inc. I've also made some related markup corrections: Missing ID on some inputs, incorrect "for" label on some labels. These fixes don't correct *all* validation errors but it's an improvement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Applying patches fails on merge conflict. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191878|0 |1 is obsolete| | Attachment #191879|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192616&action=edit Bug 41638: Add IDs to labels on patron edit When targeting with jquery and css, labels on the patron edit screen can be fragile and complicated. This patch adds ids to all the labels that follow the following convention: <label for="surname" class="required" id="surname_label"> Each id is the "for" with _label appended. To Test: 1. Before applying the patch, go to add a new patron 2. Right click on the page and use the browser inspector/inspect element. 3. Observe there are no ids for the field labels. 4. Apply patch 5. Reload the page 6. Observe there are now ids for the fields. 7. Go through all the fields and confirm there is an id and that they follow the convention above. 8. Change mandatory fields and confirm the labels are still correct. 9. Edit an existing patron and confirm the ids are still present. 10. Sign off! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192617&action=edit Bug 41638: (follow-up) Fix more instances, some markup errors I've added changes for member-alt-address-style.inc, member-alt-contact-style.inc, and member-main-address-style.inc. I've also made some related markup corrections: Missing ID on some inputs, incorrect "for" label on some labels. These fixes don't correct *all* validation errors but it's an improvement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192616|0 |1 is obsolete| | --- Comment #7 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 192712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192712&action=edit Bug 41638: Add IDs to labels on patron edit When targeting with jquery and css, labels on the patron edit screen can be fragile and complicated. This patch adds ids to all the labels that follow the following convention: <label for="surname" class="required" id="surname_label"> Each id is the "for" with _label appended. To Test: 1. Before applying the patch, go to add a new patron 2. Right click on the page and use the browser inspector/inspect element. 3. Observe there are no ids for the field labels. 4. Apply patch 5. Reload the page 6. Observe there are now ids for the fields. 7. Go through all the fields and confirm there is an id and that they follow the convention above. 8. Change mandatory fields and confirm the labels are still correct. 9. Edit an existing patron and confirm the ids are still present. 10. Sign off! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192617|0 |1 is obsolete| | --- Comment #8 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 192713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192713&action=edit Bug 41638: (follow-up) Fix more instances, some markup errors I've added changes for member-alt-address-style.inc, member-alt-contact-style.inc, and member-main-address-style.inc. I've also made some related markup corrections: Missing ID on some inputs, incorrect "for" label on some labels. These fixes don't correct *all* validation errors but it's an improvement. Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org QA Contact|testopia@bugs.koha-communit |blawlor@clamsnet.org |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192712|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192713|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 --- Comment #9 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 195704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195704&action=edit Bug 41638: Add IDs to labels on patron edit When targeting with jquery and css, labels on the patron edit screen can be fragile and complicated. This patch adds ids to all the labels that follow the following convention: <label for="surname" class="required" id="surname_label"> Each id is the "for" with _label appended. To Test: 1. Before applying the patch, go to add a new patron 2. Right click on the page and use the browser inspector/inspect element. 3. Observe there are no ids for the field labels. 4. Apply patch 5. Reload the page 6. Observe there are now ids for the fields. 7. Go through all the fields and confirm there is an id and that they follow the convention above. 8. Change mandatory fields and confirm the labels are still correct. 9. Edit an existing patron and confirm the ids are still present. 10. Sign off! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 --- Comment #10 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 195705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195705&action=edit Bug 41638: (follow-up) Fix more instances, some markup errors I've added changes for member-alt-address-style.inc, member-alt-contact-style.inc, and member-main-address-style.inc. I've also made some related markup corrections: Missing ID on some inputs, incorrect "for" label on some labels. These fixes don't correct *all* validation errors but it's an improvement. Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 --- Comment #11 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 195706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195706&action=edit Bug 41638: (QA follow-up) Make label for alt contact city consistent with main and alt address city Patch from commit 1012660 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 --- Comment #12 from Brendan Lawlor <blawlor@clamsnet.org> --- QA notes: When reviewing this I used the WAVE extension and W3C Validator. I found that the way the alternate contact city (altcontactaddress3) was labeled was not consistent with the way the city fields were labeled in the main address and alternate address. I added a QA follow up to make it consistent. Instead of the city dropdown select, the input that updates the field in the db should be the one that's labeled. I found some other accessibility issues with the form that are out of scope of this bug and will be filing another bug(s). If you are using Cities, then the city select input is an unlabeled form control. I'm not sure how this should be resolved though. For the radio inputs, like Gender, Allow auto-renewal of items, Protected, Address correction needed, and Lost card, there are multiple labels associated with the form controls. I think the resolution would be to keep the labels for each radio input and change the label for the row to a legend. For the dropdowns like Salutation and Main contact method, the placeholder <option> cannot be empty. It should either say something like "Select option..." or have a label attribute that does. The first table header in messaging preferences should not be empty. It should say something like "Message type" to inform screen readers. The checkboxes for messaging preferences also need labels. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41638 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #14 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org