[Bug 12380] New: can't tab to save buttons on add item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12380 Bug ID: 12380 Summary: can't tab to save buttons on add item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When adding/editing an item on additem.pl if you hit tab through all the subfields when you get to the end you expect the tab to go to the 'add item' buttons but it doesn't - it goes back to the top. Can we get the buttons included in the tab order? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12380 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12380 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 28734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28734&action=edit Bug 12380 - can't tab to save buttons on add item Many form elements on the add item page are giving a tabindex of "1" by the script. This seems to make it impossible to tab through the add item form fields onto the save buttons. I don't see a reason to set an explicit tabindex of "1," so this patch removes it. To test, apply the patch and open an item for editing. Try tabbing through the add item form fields. It should be possible to tab through the fields and onto the submit buttons at the bottom. Test again when adding a new item. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12380 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12380 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28734|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 28750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28750&action=edit [SIGNED-OFF] Bug 12380 - can't tab to save buttons on add item Many form elements on the add item page are giving a tabindex of "1" by the script. This seems to make it impossible to tab through the add item form fields onto the save buttons. I don't see a reason to set an explicit tabindex of "1," so this patch removes it. To test, apply the patch and open an item for editing. Try tabbing through the add item form fields. It should be possible to tab through the fields and onto the submit buttons at the bottom. Test again when adding a new item. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12380 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12380 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28750|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28759&action=edit Bug 12380 - can't tab to save buttons on add item Many form elements on the add item page are giving a tabindex of "1" by the script. This seems to make it impossible to tab through the add item form fields onto the save buttons. I don't see a reason to set an explicit tabindex of "1," so this patch removes it. To test, apply the patch and open an item for editing. Try tabbing through the add item form fields. It should be possible to tab through the fields and onto the submit buttons at the bottom. Test again when adding a new item. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12380 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12380 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.1. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12380 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ed.veal@bywatersolutions.co | |m --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 11597 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org