[Bug 17288] New: Advanced Editor - Rancor - Helpers for 006 and 007 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 Bug ID: 17288 Summary: Advanced Editor - Rancor - Helpers for 006 and 007 fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Add helper plugins for these fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 55454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55454&action=edit Bug 17288 - Advanced Editor - Rancor - Helpers for 006 and 007 fields To test: Open advanced cataloging editor Experiment with 006 and 007 fields and ensure helpers function for all material types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |nick@bywatersolutions.com CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 55548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55548&action=edit Bug 17288: (follow-up) Fix marc21_field_007.xml Bad formatted data in 007 field. Fixed To test follow the previous commit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |hector.hecaxmmx@gmail.com --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Still one error: When you insert an 006 field, position 5 is copied to another selection. For example, when you inster the new field 006 and you change BKS to MX the postion 005 "g" (Target audience--General) is copied to MX, and that position in MX is undefined. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 55842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55842&action=edit Bug 17288 (QA Followup) Don't default char 5 (is undefined in some forms) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Thanks Hector! I just changed the default line not to populate field 5 - anything you enter there in a form where it is defined will carry over, but I feel like that is safer for when you accidentally click the wrong type. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Comment on attachment 55842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55842 Bug 17288 (QA Followup)
var now = new Date();
This line not needed in both fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #7 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 55854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55854&action=edit Bug 17288: (follow-up) Remove unneccessary Date() function Remove line: var now = new Date(); from both subfields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #8 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Advanced editor still has some errors, for example, if you choose another category of material different to BKS and save record or switch between basic and advanced editor, the type of material get back to BKS in fixed fields (i.e., 006, 008). On the contrary if you open a existing record, for example, continue resources the 008 will be BKS and not CR (Continue resources) But I think this is out of the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55854|0 |1 is obsolete| | --- Comment #9 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 55855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55855&action=edit Bug 17288: (follow-up) Remove unneccessary Date() function Remove line: var now = new Date(); from both subfields Also fix 18 positions (00-17) for default data in 006 field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 J Schmidt <jschmidt@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt@switchinc.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- What is the test plan for this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #11 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Owen Leonard from comment #10)
What is the test plan for this?
Hi Owen, please follow the first commit by Nick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55454|0 |1 is obsolete| | Attachment #55548|0 |1 is obsolete| | Attachment #55842|0 |1 is obsolete| | Attachment #55855|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63059&action=edit [SIGNED-OFF] Bug 17288 - Advanced Editor - Rancor - Helpers for 006 and 007 fields To test: Open advanced cataloging editor Experiment with 006 and 007 fields and ensure helpers function for all material types Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63060&action=edit [SIGNED-OFF] Bug 17288: (follow-up) Fix marc21_field_007.xml Bad formatted data in 007 field. Fixed To test follow the previous commit. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63061&action=edit [SIGNED-OFF] Bug 17288 (QA Followup) Don't default char 5 (is undefined in some forms) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63062&action=edit [SIGNED-OFF] Bug 17288: (follow-up) Remove unneccessary Date() function Remove line: var now = new Date(); from both subfields Also fix 18 positions (00-17) for default data in 006 field Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63059|0 |1 is obsolete| | Attachment #63060|0 |1 is obsolete| | Attachment #63061|0 |1 is obsolete| | Attachment #63062|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66465&action=edit Bug 17288 - Advanced Editor - Rancor - Helpers for 006 and 007 fields To test: Open advanced cataloging editor Experiment with 006 and 007 fields and ensure helpers function for all material types Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66466&action=edit Bug 17288: (follow-up) Fix marc21_field_007.xml Bad formatted data in 007 field. Fixed To test follow the previous commit. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66467&action=edit Bug 17288 (QA Followup) Don't default char 5 (is undefined in some forms) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66468&action=edit Bug 17288: (follow-up) Remove unneccessary Date() function Remove line: var now = new Date(); from both subfields Also fix 18 positions (00-17) for default data in 006 field Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Patch complexity|Trivial patch |Small patch --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Not a trivial patch. And small is also arguable ;) Looks good to me. Did not test in Rancor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #22 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org