http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 --- Comment #1 from Emma Heath <emmaheath.student@wegc.school.nz> --- Created attachment 24251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24251&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Emma Heath <emmaheath.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24251|0 |1 is obsolete| | --- Comment #2 from Emma Heath <emmaheath.student@wegc.school.nz> --- Created attachment 24263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24263&action=edit Bug:11540 increasing coverage of Charset.pm To test 1. run prove t/Charset.t 2. apply patch 3. run prove t/Charset.t notice more tests are run -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24266|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 24285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24285&action=edit [SIGNED-OFF] Bug 11540: increasing coverage of Charset.pm To test 1. run prove t/Charset.t 2. apply patch 3. run prove t/Charset.t notice more tests are run Signed-off-by: Tom Houlker <thomas.houlker@hibs.school.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Emma Heath <emmaheath.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24285|0 |1 is obsolete| | --- Comment #6 from Emma Heath <emmaheath.student@wegc.school.nz> --- Created attachment 24304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24304&action=edit Bug 11540: increasing coverage of Charset.pm To test 1. run prove t/Charset.t 2. apply patch 3. run prove t/Charset.t notice more tests are run Signed-off-by: Tom Houlker <thomas.houlker@hibs.school.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Emma Heath <emmaheath.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24286|0 |1 is obsolete| | --- Comment #7 from Emma Heath <emmaheath.student@wegc.school.nz> --- Created attachment 24307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24307&action=edit Bug 11540: (folowup) add a couple of tests more This patch makes sure all scenarios are covered for SetUTF8Flag. Regards To+ Signed-off-by: Emma Heath <emmaheath.student@wegc.school.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24304|0 |1 is obsolete| | Attachment #24307|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24316&action=edit [PASSED QA] Bug 11540: increasing coverage of Charset.pm To test 1. run prove t/Charset.t 2. apply patch 3. run prove t/Charset.t notice more tests are run Signed-off-by: Tom Houlker <thomas.houlker@hibs.school.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tests pass! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11540 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Congratulations on having your first patch accepted to Koha, Emma! -- You are receiving this mail because: You are watching all bug changes.