[Bug 20596] New: Error Zoom 20003 when import authority marc file (koha/tools/manage-marc-import.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Bug ID: 20596 Summary: Error Zoom 20003 when import authority marc file (koha/tools/manage-marc-import.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: marjorie.barry-vila@collecto.ca QA Contact: testopia@bugs.koha-community.org Created attachment 74361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74361&action=edit authority to test Hi, We have a Zoom error when we apply a matching rule on a field (035) that appears twice in the authority record. ZOOM error 20003 "can't set prefix query" (addinfo: "@or @attr 7=1 @attr 4=109 @attr 1=Local-Number 0 @attr 1=Any @attr 4=1 @attr 5=100 @attr 6=3 "F000001" @attr 1=Any @attr 4=1 @attr 5=100 @attr 6=3 "44444"") from diag-set 'ZOOM' Test plan : - Add a record matching rule for field 035$a (index control-number) - upload a authority record file in tools/stage-marc-import.pl (attached file) - go to Manage staged MARC records and open authority file - apply matching rule for 035 - see error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16976 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marjorie, have you checked that control-number exists for authority indexing? It does exist for bibliographic, but the index sets don't match up. https://git.koha-community.org/Koha-community/Koha/src/branch/master/etc/zeb... This suggests 035 is not indexed at all for authorities :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #2 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- (In reply to Katrin Fischer from comment #1)
Hi Marjorie, have you checked that control-number exists for authority indexing? It does exist for bibliographic, but the index sets don't match up.
https://git.koha-community.org/Koha-community/Koha/src/branch/master/etc/ zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml
This suggests 035 is not indexed at all for authorities :(
Hi Katrin, Thank you for your reply and sorry for my delay. I am amazed that zone 035 does not appear in the list of indexed zones. Also I am surprised that zone 016 does not appear in the authority-koha-indexdefs.xml file either, whereas for this field the search with the index control-number works. Is there another file that lists potentially indexed zones for authorities where zone 016 would be found? Regards, Marjorie --- Comment #3 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- (In reply to Katrin Fischer from comment #1)
Hi Marjorie, have you checked that control-number exists for authority indexing? It does exist for bibliographic, but the index sets don't match up.
https://git.koha-community.org/Koha-community/Koha/src/branch/master/etc/ zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml
This suggests 035 is not indexed at all for authorities :(
Hi Katrin, Thank you for your reply and sorry for my delay. I am amazed that zone 035 does not appear in the list of indexed zones. Also I am surprised that zone 016 does not appear in the authority-koha-indexdefs.xml file either, whereas for this field the search with the index control-number works. Is there another file that lists potentially indexed zones for authorities where zone 016 would be found? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #2 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- (In reply to Katrin Fischer from comment #1)
Hi Marjorie, have you checked that control-number exists for authority indexing? It does exist for bibliographic, but the index sets don't match up.
https://git.koha-community.org/Koha-community/Koha/src/branch/master/etc/ zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml
This suggests 035 is not indexed at all for authorities :(
Hi Katrin, Thank you for your reply and sorry for my delay. I am amazed that zone 035 does not appear in the list of indexed zones. Also I am surprised that zone 016 does not appear in the authority-koha-indexdefs.xml file either, whereas for this field the search with the index control-number works. Is there another file that lists potentially indexed zones for authorities where zone 016 would be found? Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marjorie, this should be the only file listing all indexes for the authorities. You might have local changes of course. And maybe it falls back to a keyword search if the index is unknown or so? I have no proof of this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Noémie Labine <noemie.labine@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de --- Comment #5 from Jan Kissig <bibliothek@th-wildau.de> --- hi, since 21.11 the mentioned field 035(az) is indexed as Other-control-number both in biblios and authorities. The described error still exists when the record to be imported contains 2 datafields 035a. Do record-match-rules rely on zoom, zebradb or would switching to elastic be a possible solution? Jan -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |fridolin.somers@biblibre.co | |m --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is an interesting one - I am adding David Cook and Frido as our Zebra experts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As far as I know the search index is used for matching. Switching to Elasticsearch might be an option to investigate, but fixing this would still be very worthwhile. Matching on 035 is an obvious choice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- At a glance, I think that there's a syntax error in the query being generated. If you decompose the following: @or @attr 7=1 @attr 4=109 @attr 1=Local-Number 0 @attr 1=Any @attr 4=1 @attr 5=100 @attr 6=3 "F000001" @attr 1=Any @attr 4=1 @attr 5=100 @attr 6=3 "44444" You get this: @or @attr 7=1 @attr 4=109 @attr 1=Local-Number 0 @attr 1=Any @attr 4=1 @attr 5=100 @attr 6=3 "F000001" @attr 1=Any @attr 4=1 @attr 5=100 @attr 6=3 "44444" There are 3 queries there but only 1 operator. Marjorie, can you provide a screenshot of the record matching rule being used? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #9 from Jan Kissig <bibliothek@th-wildau.de> --- I would like to update information as the index field to look at changed: error: ==> /var/log/koha/hsbwildau/worker-output.log <== ZOOM error 20003 "can't set prefix query" (addinfo: "@or @attr 7=1 @attr 4=109 @attr 1=Local-Number 0 @attr 1=Other-control-number @attr 4=1 @attr 5=100 @attr 6=3 "(DE-101)04079184X" @attr 1=Other-control-number @attr 4=1 @attr 5=100 @attr 6=3 "(DE-588)4079184-1"") from diag-set 'ZOOM' at /usr/share/koha/lib/Koha/BackgroundJob/StageMARCForImport.pm line 162. Test plan: - add matching rule as described in screenshot - stage gnd.xml for import with following settings - marcxml - record type: Authority - format: marcxml - record matching rule as above -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #10 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 144550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144550&action=edit Marcxml file with two entries 035a -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #11 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 144551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144551&action=edit Screenshot of matching rule -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Reproduced the error following Jan Kissig's instructions: ZOOM error 20003 "can't set prefix query" (addinfo: "@or @attr 7=1 @attr 4=109 @attr 1=Local-Number 0 @attr 1=Other-control-number @attr 4=1 @attr 5=100 @attr 6=3 "(DE-101)04079184X" @attr 1=Other-control-number @attr 4=1 @attr 5=10 0 @attr 6=3 "(DE-588)4079184-1"") from diag-set 'ZOOM' at /kohadevbox/koha/Koha/BackgroundJob/StageMARCForImport.pm line 162. It looks like C4::AuthoritiesMarc::SearchAuthorities is where the issue is. The "$orderstring" is being tacked on the front which is OK: '@attr 7=1 @attr 4=109 @attr 1=Local-Number 0' 227 $query="\@or $orderstring $query" if $orderstring; That leaves the two actual queries: @attr 1=Other-control-number @attr 4=1 @attr 5=100 @attr 6=3 "(DE-101)04079184X" @attr 1=Other-control-number @attr 4=1 @attr 5=100 @attr 6=3 "(DE-588)4079184-1" As I suspected, Koha isn't adding the operator to join these two queries together. The query building code is frightful... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- I'm curious about how the Elasticsearch handles it, since the "and_or" in C4::Matcher::get_matches makes no sense. Aha, it does something practical but annoying: Koha/SearchEngine/Elasticsearch/QueryBuilder.pm 287 # Merge the indexes in with the search terms and the operands so that 288 # each search thing is a handy unit. 289 unshift @$operators, undef; # The first one can't have an op By comparison, C4::AuthoritiesMarc::SearchAuthorities doesn't actually use the real operators passed into the function... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- Yeah... C4::AuthoritiesMarc::SearchAuthorities is fundamentally broken. (In reply to David Cook from comment #13)
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm 287 # Merge the indexes in with the search terms and the operands so that 288 # each search thing is a handy unit. 289 unshift @$operators, undef; # The first one can't have an op
Actually, that is unrelated. You can ignore that comment... -- If I understand the Elasticsearch code correctly, it's just hard-coding OR for build_authorities_query_compat(). Amusingly, many parts of Koha pass "and" into build_authorities_query_compat(). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- Ok so I'm working on a patch... I tried both "Other-control-number" and "control-number", but neither worked. Now that's because "control-number" is not a valid authority index, and "Other-control-number" was probably just empty, since I do see it in ./etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- Created attachment 144561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144561&action=edit Bug 20596: Join authority queries together with OR This patch joins authority queries together with OR like Elasticsearch. To the best of the author's knowledge, this code only gets triggered when using record matching rules, but there may be other situations where it's used. Authority search in cataloguing plugins use a different path, and authority search in authority home doesn't allow multiple queries, so they'll never trigger this OR joining of queries. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Create a record matching rule with the following: Matching rule code: NID Description: NormdatenID Match threshold: 100 Record type: Authority record Search index: Any Score: 101 Tag: 035 Subfields: a Offset: 0 Length: 0 Normalization rule: None Click "Remove this match check" 2. Stage gnd.xml (from BZ 20596 attachments) - Choose "MARCXML" for "Format" - Choose "Authority" for "Record type" - Choose "NID" for "Record matching rule" - Click "Stage for import" 3. Note the job gets to "100% Finished" (Before this patch, it would say "0% Failed") 4. View the batch 5. Import the record 6. Repeat steps 2-4 and note that the record matching rule worked 7. Go to http://localhost:8081/cgi-bin/koha/authorities/authorities-home.pl 8. Search for "e" 9. Note that the search works 10. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 11. Click tab 6 12. Click on the tag editor next to "a Personal Name" 13. Type "e" into each box and click "Search" 14. Note that the search works -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- Created attachment 144562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144562&action=edit Bug 20596: Add unit test for multiple values in authority search This patch adds a unit test which returns 2 authority records via an implicit OR when searching for strings from two different authority records. Test plan: 1. prove t/db_dependent/Search.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | --- Comment #18 from David Cook <dcook@prosentient.com.au> --- I think working on C4::AuthoritiesMarc just now may have taken years off my life, but I think those patches should do the trick. Please give it a test and sign off if you're happy with it. Perhaps Fridolin can QA this one... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Error Zoom 20003 when |Authority record matching |import authority marc file |rule causes staging failure |(koha/tools/manage-marc-imp |when MARC record contains |ort.pl) |multiple tag values for a | |match point -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> ---
Perhaps Fridolin can QA this one...
I will ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Jan, can you do the sign-off? You should be able to use a sandbox for it, if you don't have the dev env yet: https://wiki.koha-community.org/wiki/Sandboxes Let us know, if we can help. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- And thx to David and Frido :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #22 from Jan Kissig <bibliothek@th-wildau.de> --- Tested as described in comment #16 with Search index: Any and also with Search index: Other-control-number and everything (staging and matching) worked as as expected! Thanks for that fast response -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144561|0 |1 is obsolete| | --- Comment #23 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 144590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144590&action=edit Bug 20596: Join authority queries together with OR This patch joins authority queries together with OR like Elasticsearch. To the best of the author's knowledge, this code only gets triggered when using record matching rules, but there may be other situations where it's used. Authority search in cataloguing plugins use a different path, and authority search in authority home doesn't allow multiple queries, so they'll never trigger this OR joining of queries. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Create a record matching rule with the following: Matching rule code: NID Description: NormdatenID Match threshold: 100 Record type: Authority record Search index: Any Score: 101 Tag: 035 Subfields: a Offset: 0 Length: 0 Normalization rule: None Click "Remove this match check" 2. Stage gnd.xml (from BZ 20596 attachments) - Choose "MARCXML" for "Format" - Choose "Authority" for "Record type" - Choose "NID" for "Record matching rule" - Click "Stage for import" 3. Note the job gets to "100% Finished" (Before this patch, it would say "0% Failed") 4. View the batch 5. Import the record 6. Repeat steps 2-4 and note that the record matching rule worked 7. Go to http://localhost:8081/cgi-bin/koha/authorities/authorities-home.pl 8. Search for "e" 9. Note that the search works 10. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 11. Click tab 6 12. Click on the tag editor next to "a Personal Name" 13. Type "e" into each box and click "Search" 14. Note that the search works Signed-off-by: Katrin <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144562|0 |1 is obsolete| | --- Comment #24 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 144591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144591&action=edit Bug 20596: Add unit test for multiple values in authority search This patch adds a unit test which returns 2 authority records via an implicit OR when searching for strings from two different authority records. Test plan: 1. prove t/db_dependent/Search.t Signed-off-by: Katrin <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144590|0 |1 is obsolete| | --- Comment #25 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 144598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144598&action=edit Bug 20596: Join authority queries together with OR This patch joins authority queries together with OR like Elasticsearch. To the best of the author's knowledge, this code only gets triggered when using record matching rules, but there may be other situations where it's used. Authority search in cataloguing plugins use a different path, and authority search in authority home doesn't allow multiple queries, so they'll never trigger this OR joining of queries. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Create a record matching rule with the following: Matching rule code: NID Description: NormdatenID Match threshold: 100 Record type: Authority record Search index: Any Score: 101 Tag: 035 Subfields: a Offset: 0 Length: 0 Normalization rule: None Click "Remove this match check" 2. Stage gnd.xml (from BZ 20596 attachments) - Choose "MARCXML" for "Format" - Choose "Authority" for "Record type" - Choose "NID" for "Record matching rule" - Click "Stage for import" 3. Note the job gets to "100% Finished" (Before this patch, it would say "0% Failed") 4. View the batch 5. Import the record 6. Repeat steps 2-4 and note that the record matching rule worked 7. Go to http://localhost:8081/cgi-bin/koha/authorities/authorities-home.pl 8. Search for "e" 9. Note that the search works 10. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 11. Click tab 6 12. Click on the tag editor next to "a Personal Name" 13. Type "e" into each box and click "Search" 14. Note that the search works Signed-off-by: Katrin <katrin.fischer.83@web.de> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144591|0 |1 is obsolete| | --- Comment #26 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 144599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144599&action=edit Bug 20596: Add unit test for multiple values in authority search This patch adds a unit test which returns 2 authority records via an implicit OR when searching for strings from two different authority records. Test plan: 1. prove t/db_dependent/Search.t Signed-off-by: Katrin <katrin.fischer.83@web.de> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #27 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 144600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144600&action=edit Bug 20596: (QA follow-up) perltidy Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #28 from Fridolin Somers <fridolin.somers@biblibre.com> --- Great work everyone on this tricky bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jan Kissig from comment #22)
Tested as described in comment #16 with Search index: Any and also with Search index: Other-control-number and everything (staging and matching) worked as as expected!
Thanks for that fast response
It was actually not me testing, but Jan. There is a bug in the sandbox system where it uses the data of the one who created the sandbox instead of the information given on the sign-off form. To give Jan credit, can we please fix the sign-off lines before push? I can do it, but it might take me too long, so leaving the comment as this is already PQA - thx Frido! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144598|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144605&action=edit Bug 20596: Join authority queries together with OR This patch joins authority queries together with OR like Elasticsearch. To the best of the author's knowledge, this code only gets triggered when using record matching rules, but there may be other situations where it's used. Authority search in cataloguing plugins use a different path, and authority search in authority home doesn't allow multiple queries, so they'll never trigger this OR joining of queries. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Create a record matching rule with the following: Matching rule code: NID Description: NormdatenID Match threshold: 100 Record type: Authority record Search index: Any Score: 101 Tag: 035 Subfields: a Offset: 0 Length: 0 Normalization rule: None Click "Remove this match check" 2. Stage gnd.xml (from BZ 20596 attachments) - Choose "MARCXML" for "Format" - Choose "Authority" for "Record type" - Choose "NID" for "Record matching rule" - Click "Stage for import" 3. Note the job gets to "100% Finished" (Before this patch, it would say "0% Failed") 4. View the batch 5. Import the record 6. Repeat steps 2-4 and note that the record matching rule worked 7. Go to http://localhost:8081/cgi-bin/koha/authorities/authorities-home.pl 8. Search for "e" 9. Note that the search works 10. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 11. Click tab 6 12. Click on the tag editor next to "a Personal Name" 13. Type "e" into each box and click "Search" 14. Note that the search works Signed-off-by: Jan Kissig <jan.kissig@th-wildau.de> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144599|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144606&action=edit Bug 20596: Add unit test for multiple values in authority search This patch adds a unit test which returns 2 authority records via an implicit OR when searching for strings from two different authority records. Test plan: 1. prove t/db_dependent/Search.t Signed-off-by: Jan Kissig <jan.kissig@th-wildau.de> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144600|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144607&action=edit Bug 20596: (QA follow-up) perltidy Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Signoff lines fixed at Katrins request.. great to have you aboard with testing Jan :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.01 |23.05.00,22.11.01,22.05.09 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #36 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |arthur.suzuki@biblibre.com Version(s)|23.05.00,22.11.01,22.05.09 |23.05.00,22.11.01,22.05.09, released in| |21.11.16 --- Comment #37 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #38 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org