https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31948 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen@gmail.com |katrin.fischer@bsz-bw.de Keywords| |rel_22_11_candidate Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31948 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142767&action=edit Bug 31948: Add timestamp to tmp_holdsqueue table With the option to have real time updates to tmp_holdsqueue a timestamp will be really helpful to help find the most recently added entries. To test: * Place some holds on a record with available items * Run build_holds-queue.pl * Verify the hold shows up under circulation > holds queue * Apply patch * Run build_holds_queue.pl again * Verify this works without any issues * Turn on RealTimeHoldsQueue * Update pick-up location, add another hold * Make sure these changes are reflected in the holds queue as well * Look at the database and verify timestamps are set -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31948 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2954 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2954 [Bug 2954] Holds queue report should show date/time of last update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31948 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142767|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142773&action=edit Bug 31948: Add timestamp to tmp_holdsqueue table With the option to have real time updates to tmp_holdsqueue a timestamp will be really helpful to help find the most recently added entries. To test: * Place some holds on a record with available items * Run build_holds-queue.pl * Verify the hold shows up under circulation > holds queue * Apply patch * Run build_holds_queue.pl again * Verify this works without any issues * Turn on RealTimeHoldsQueue * Update pick-up location, add another hold * Make sure these changes are reflected in the holds queue as well * Look at the database and verify timestamps are set Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31948 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Kyle, hope it's ok with you - we are counting you for QA and Owen as SO. If you -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31948 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31948 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate | Text to go in the| |This adds a timestamp release notes| |column to the | |tmp_holdsqueue table that | |the holds queue in | |circulation is built from. | |With RealTimeHoldsQueue | |this will enable reporting | |on the date and time an | |entry was added to the | |holds queue. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31948 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #8)

+ $dbh->do(q{ALTER TABLE `tmp_holdsqueue` ADD `timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP AFTER item_level_request});

Hmm. No check if column exists? Not idempotent..

Resulting in: Upgrade to 22.06.00.075 [09:27:16]: Bug 31948 - Add timestamp to tmp_holdsqueue table ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate column name 'timestamp' at /usr/share/koha/C4/Installer.pm line 739

Hi Marcel, you are right, we should add the check. Sorry for missing it. I probably won't be able to provide the patch today or tomorrow tho :( -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31948 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33051 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33051 [Bug 33051] 22600075.pl is not idempotent -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31948 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #9)

(In reply to Marcel de Rooy from comment #8)

...

+ $dbh->do(q{ALTER TABLE `tmp_holdsqueue` ADD `timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP AFTER item_level_request});

Hmm. No check if column exists? Not idempotent..

Resulting in: Upgrade to 22.06.00.075 [09:27:16]: Bug 31948 - Add timestamp to tmp_holdsqueue table ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate column name 'timestamp' at /usr/share/koha/C4/Installer.pm line 739

Hi Marcel, you are right, we should add the check. Sorry for missing it. I probably won't be able to provide the patch today or tomorrow tho :(

Moved the resolution of this to bug 33051 and removed the additional_work_needed keyword. -- You are receiving this mail because: You are watching all bug changes.