https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105767&action=edit Bug 25716: Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder The z39.50 responder has a number of command line options that are not accessible if using the debian scripts to control it. We should be able to set those options in the koha conf file to be passed to the script itself. Test Plan: 1) Apply this patch 2) Copy your kohaclone's koha-z3950-responder to /usr/sbin/koha-z3950-responder if necessary 3) Add "<z3950_responder_options>--add-item-status k</z3950_responder_options>" inside your <config> block in your koha-conf.xml file 4) Use koha-z3950-responder to start/restart the z39.50 responder, note the item status is now in subfield k! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 114166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114166&action=edit Bug 25716: Don't exit if config doesn't exist in Koha conf file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle@bywatersolutions.com |testopia@bugs.koha-communit | |y.org CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- It is not breaking xmlstarlet, so not an issue. Back to NSO. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105767|0 |1 is obsolete| | Attachment #120178|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125095&action=edit Bug 25716: Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder The z39.50 responder has a number of command line options that are not accessible if using the debian scripts to control it. We should be able to set those options in the koha conf file to be passed to the script itself. Test Plan: 1) Apply this patch 2) Copy your kohaclone's koha-z3950-responder to /usr/sbin/koha-z3950-responder if necessary 3) Add "<z3950_responder_options>--add-item-status k</z3950_responder_options>" inside your <config> block in your koha-conf.xml file 4) Use koha-z3950-responder to start/restart the z39.50 responder, note the item status is now in subfield k! Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125095|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125481&action=edit Bug 25716: Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder The z39.50 responder has a number of command line options that are not accessible if using the debian scripts to control it. We should be able to set those options in the koha conf file to be passed to the script itself. Test Plan: 1) Apply this patch 2) Copy your kohaclone's koha-z3950-responder to /usr/sbin/koha-z3950-responder if necessary 3) Add "<z3950_responder_options>--add-item-status k</z3950_responder_options>" inside your <config> block in your koha-conf.xml file 4) Use koha-z3950-responder to start/restart the z39.50 responder, note the item status is now in subfield k! Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I can't really fail this.. but I would have preferred to see it as options in the z3950 specific config file rather than this somewhat obscure pass a param into the config.. it feels weird having `--add-item-status k--` inside a config line But.. the code does indeed work and although we get a noisy warning about XML issues in the qa scripts it doesn't appear to actually cause an issue with the feature. Passing QA. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125481|0 |1 is obsolete| | Attachment #125482|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142520&action=edit Bug 25716: Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder The z39.50 responder has a number of command line options that are not accessible if using the debian scripts to control it. We should be able to set those options in the koha conf file to be passed to the script itself. Test Plan: 1) Apply this patch 2) Copy your kohaclone's koha-z3950-responder to /usr/sbin/koha-z3950-responder if necessary 3) Add "<z3950_responder_options>--add-item-status k</z3950_responder_options>" inside your <config> block in your koha-conf.xml file 4) Use koha-z3950-responder to start/restart the z39.50 responder, note the item status is now in subfield k! Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142522&action=edit Bug 25716: (QA follow-up) Move additional options to etc/z3950/config.xml This followup moves the configuration to the z3950 etc file, either the default and or the custom file is used as per the existing script code. In addition, the options and be set using an environment variable named Z3950_ADDITIONAL_OPTS. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.