[Bug 37172] New: HoldItem and HoldTitle do not check all the values of "hold_fulfillment_policy" rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37172 Bug ID: 37172 Summary: HoldItem and HoldTitle do not check all the values of "hold_fulfillment_policy" rule Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: arthur.suzuki@biblibre.com QA Contact: testopia@bugs.koha-community.org values "homebranch" and "holdingbranch" are not checked, leading to forbidden holds to be put from the ILS-DI interface. I think the controls on "hold_fulfillment_policy" should be done in "CanItemBeReserved" rather than "CheckReserves". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37172 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |arthur.suzuki@biblibre.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28504 Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37172 --- Comment #1 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 168013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168013&action=edit Bug 37172 - HoldItem and HoldTitle do not check all the values of "hold_fulfillment_policy" rule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37172 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Yop You must fix commit message ( : not - ) See https://wiki.koha-community.org/wiki/Commit_messages#Subject_line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37172 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- + # Pickup branch management} Typo ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37172 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Is this sill valid ? Needs a unit test :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37172 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |BibLibre list of Sponsors| | Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37172 --- Comment #5 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 209155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209155&action=edit Bug 37172: HoldItem and HoldTitle do not check all the values of "hold_fulfillment_policy" rule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37172 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168013|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37172 --- Comment #6 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 209156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209156&action=edit Bug 37172: Add unit tests for hold_fulfillment_policy homebranch and holdingbranch checks Test that CanItemBeReserved correctly enforces the homebranch and holdingbranch values of the hold_fulfillment_policy circulation rule. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org