[Bug 35418] New: SUSHI harvest hangs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 Bug ID: 35418 Summary: SUSHI harvest hangs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: pedro.amorim@ptfs-europe.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com Depends on: 34587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 [Bug 34587] Add a Usage Statistics module to ERM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159289&action=edit Bug 35418: Add TR_B2 tests This test file adds tests for the TR_B2 specific report. But also tests for this specific bug, which only happens if the report time period ends in december -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159290&action=edit Bug 35418: Fix _get_usage_months No longer falls in an endless loop if the last month in the report period is december. Test plan: 1) Apply just the tests patch, run EUsage tests prove t/db_dependent/Koha/ERM/EUsage/ 2) Wait for a few seconds. Notice SushiCounter.t it hangs. CTRL+C (cancel it) 3) Apply the fix patch. 4) Run the tests again. Notice all EUsage tests pass with no issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159289|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 159323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159323&action=edit Bug 35418: Add TR_B2 tests This test file adds tests for the TR_B2 specific report. But also tests for this specific bug, which only happens if the report time period ends in december Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159290|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 159324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159324&action=edit Bug 35418: Fix _get_usage_months No longer falls in an endless loop if the last month in the report period is december. Test plan: 1) Apply just the tests patch, run EUsage tests prove t/db_dependent/Koha/ERM/EUsage/ 2) Wait for a few seconds. Notice SushiCounter.t it hangs. CTRL+C (cancel it) 3) Apply the fix patch. 4) Run the tests again. Notice all EUsage tests pass with no issues. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159323|0 |1 is obsolete| | --- Comment #5 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Created attachment 159347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159347&action=edit Bug 35418: Add TR_B2 tests This test file adds tests for the TR_B2 specific report. But also tests for this specific bug, which only happens if the report time period ends in december Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159324|0 |1 is obsolete| | --- Comment #6 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Created attachment 159348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159348&action=edit Bug 35418: Fix _get_usage_months No longer falls in an endless loop if the last month in the report period is december. Test plan: 1) Apply just the tests patch, run EUsage tests prove t/db_dependent/Koha/ERM/EUsage/ 2) Wait for a few seconds. Notice SushiCounter.t it hangs. CTRL+C (cancel it) 3) Apply the fix patch. 4) Run the tests again. Notice all EUsage tests pass with no issues. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Keywords|Sandbox |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159347|0 |1 is obsolete| | Attachment #159348|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159373&action=edit Bug 35418: Add TR_B2 tests This test file adds tests for the TR_B2 specific report. But also tests for this specific bug, which only happens if the report time period ends in december Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159374&action=edit Bug 35418: Fix _get_usage_months No longer falls in an endless loop if the last month in the report period is december. Test plan: 1) Apply just the tests patch, run EUsage tests prove t/db_dependent/Koha/ERM/EUsage/ 2) Wait for a few seconds. Notice SushiCounter.t it hangs. CTRL+C (cancel it) 3) Apply the fix patch. 4) Run the tests again. Notice all EUsage tests pass with no issues. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha@gmail. |pedro.amorim@ptfs-europe.co |com |m Keywords|rel_23_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418 Bug 35418 depends on bug 34587, which changed state. Bug 34587 Summary: Add a Usage Statistics module to ERM https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org