[Bug 32954] New: Standardize action fieldsets in rotating collections, suggestions, tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Bug ID: 32954 Summary: Standardize action fieldsets in rotating collections, suggestions, tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32746 Blocks: 32744 As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers a few templates in rotating collections, suggestions, and tools Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32744 [Bug 32744] [OMNIBUS] Standardize structure around action fieldsets https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 [Bug 32746] Standardize structure around action fieldsets in acquisitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 146591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146591&action=edit Bug 32954: Standardize action fieldsets in rotating collections, suggestions, tools As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers a few templates in rotating collections, suggestions, and tools. To test, apply the patch and check the following pages to confirm that changes to form structure look correct: - Tools -> Rotating collections. Create a collection if necessary, then click "Action" -> "Manage items." Check the form on the manage items page. - Suggestions -> Sidebar filter. Check that different sets of filters expand and collapse correctly. - Tools -> Batch item modification (initial form) - Tools -> Inventory (initial form) - Cataloging -> Stage records for import (initial form) - Tools -> Upload (upload and search forms) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146591|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 146613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146613&action=edit Bug 32954: Standardize action fieldsets in rotating collections, suggestions, tools As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers a few templates in rotating collections, suggestions, and tools. To test, apply the patch and check the following pages to confirm that changes to form structure look correct: - Tools -> Rotating collections. Create a collection if necessary, then click "Action" -> "Manage items." Check the form on the manage items page. - Suggestions -> Sidebar filter. Check that different sets of filters expand and collapse correctly. - Tools -> Batch item modification (initial form) - Tools -> Inventory (initial form) - Cataloging -> Stage records for import (initial form) - Tools -> Upload (upload and search forms) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146613|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147407&action=edit Bug 32954: Standardize action fieldsets in rotating collections, suggestions, tools As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers a few templates in rotating collections, suggestions, and tools. To test, apply the patch and check the following pages to confirm that changes to form structure look correct: - Tools -> Rotating collections. Create a collection if necessary, then click "Action" -> "Manage items." Check the form on the manage items page. - Suggestions -> Sidebar filter. Check that different sets of filters expand and collapse correctly. - Tools -> Batch item modification (initial form) - Tools -> Inventory (initial form) - Cataloging -> Stage records for import (initial form) - Tools -> Upload (upload and search forms) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147407|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 148515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148515&action=edit Bug 32954: Standardize action fieldsets in rotating collections, suggestions, tools As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers a few templates in rotating collections, suggestions, and tools. To test, apply the patch and check the following pages to confirm that changes to form structure look correct: - Tools -> Rotating collections. Create a collection if necessary, then click "Action" -> "Manage items." Check the form on the manage items page. - Suggestions -> Sidebar filter. Check that different sets of filters expand and collapse correctly. - Tools -> Batch item modification (initial form) - Tools -> Inventory (initial form) - Cataloging -> Stage records for import (initial form) - Tools -> Upload (upload and search forms) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Bug 32954 depends on bug 32746, which changed state. Bug 32746 Summary: Standardize structure around action fieldsets in acquisitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org