[Bug 16197] New: Searching for user in reserve/request.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Bug ID: 16197 Summary: Searching for user in reserve/request.pl is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: philippe.blouin@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The user search in reserve/request.pl got broken by bug 13894. The search using the "recordset" doesn not care for "lastname, firstname" as before, instead finding nothing. Scenario: EASY SETUP: database with two borrowers with same last name, and one record minimu. 1) go to KOHA_SITE/cgi-bin/koha/reserve/request.pl?biblionumber=1 2) enter the last name. You should get two results in the table 3) same site, enter "lastname, firstname" (comma optional). You get no result. This used to work before 13894. Vile RecordSet broke it... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Assignee|koha-bugs@lists.koha-commun |philippe.blouin@inlibro.com |ity.org | CC| |francois.charbonnier@inlibr | |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13894 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 --- Comment #1 from Blou <philippe.blouin@inlibro.com> --- Actually, problem seems with C4/Utils/DataTables/Members.pm 's search method. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 --- Comment #2 from Blou <philippe.blouin@inlibro.com> --- Created attachment 49877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49877&action=edit Bug 16197 - Specifying both last and firstname in reserve's patrong search yields nothing. The user search in reserve/request.pl got broken by bug 13894. The search using the "recordset" doesn not care for "lastname, firstname" as before, instead finding nothing. Test scenario: EASY SETUP: database with two borrowers with same last name, and one record minimu. 1) go to KOHA_SITE/cgi-bin/koha/reserve/request.pl?biblionumber=1 2) enter the last name. You should get two results in the table 3) same site, enter "lastname, firstname" (comma optional). You get no result. 4) Apply the patch, same test now return the one matching result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49877|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 49887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49887&action=edit Bug 16197 - Specifying both last and firstname in reserve's patrong search yields nothing. The user search in reserve/request.pl got broken by bug 13894. The search using the "recordset" doesn not care for "lastname, firstname" as before, instead finding nothing. Test scenario: EASY SETUP: database with two borrowers with same last name, and one record minimu. 1) go to KOHA_SITE/cgi-bin/koha/reserve/request.pl?biblionumber=1 2) enter the last name. You should get two results in the table 3) same site, enter "lastname, firstname" (comma optional). You get no result. 4) Apply the patch, same test now return the one matching result. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15930 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15252 Status|Signed Off |In Discussion --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- I signed off, but am marking to in discussion as I think this is the same issue as 15930. I like this approach, but it causes issues for the patch of 15252. I think the best solution proposed is to use "quotes" to force phrase searching for two part names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Blou, please jump into the discussion on bug 15930. I'd like to provide a global fix for this issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 15930 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org