https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35141 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35141 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157739&action=edit Bug 35141: Prevent link_bibs_to_authorities from dying on invalid metadata When fetching the record we need to eval in case of exception To test: 1 - Apply first patch 2 - perl misc/link_bibs_to_authorities.pl 3 - Note it dies on parser error at record 369 4 - Apply this patch 5 - perl misc/link_bibs_to_authorities.pl 6 - The process completes - with warning thrown on record 369 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35141 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157738|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 157766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157766&action=edit Bug 35141: Catch ES search exceptions in link_bibs_to_authorities, warn, and continue This patch simplay adds an eval and a warning to link_bibs_to_authorities to catch any errors while searching and continue linking. To test: 1 - edit /etc/kohia/sites/kohadev/koha-conf.xml and add to elasticsearch stanza <request_timeout>0</request_timeout> 2 - perl misc/link_bibs_to_authorities.pl 3 - It dies immediately 4 - Apply patch 5 - perl misc/link_bibs_to_authorities.pl 6 - Now it tries every record, throwing warnings along the way, but completes Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35141 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Filled Assignee :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35141 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35141 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157766|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157972&action=edit Bug 35141: Catch ES search exceptions in link_bibs_to_authorities, warn, and continue This patch simplay adds an eval and a warning to link_bibs_to_authorities to catch any errors while searching and continue linking. To test: 1 - edit /etc/kohia/sites/kohadev/koha-conf.xml and add to elasticsearch stanza <request_timeout>0</request_timeout> 2 - perl misc/link_bibs_to_authorities.pl 3 - It dies immediately 4 - Apply patch 5 - perl misc/link_bibs_to_authorities.pl 6 - Now it tries every record, throwing warnings along the way, but completes Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35141 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157974&action=edit Bug 35141: (QA follow-up) Increment the bad count Also move earlier print to warn for consistency. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35141 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35141 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.