[Bug 24465] New: Label creator requires catalogue permission instead of label_creator permission from tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24465 Bug ID: 24465 Summary: Label creator requires catalogue permission instead of label_creator permission from tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Checking bug 7468 I noticed that all the templates in labels use the catalogue permission instead of the expected tools->label_creator permission. The permission description manages creating labels from patron and catalog data, so it seems it should be used for the label creator? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cnighswonger@foundations.ed |ity.org |u Component|Tools |Label/patron card printing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24465 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Can you clarify this one? It looks to me like the template for ./koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/cataloging-home.tt uses the correct tools label creator sub-permission. However, it looks like the Perl scripts (e.g. ./labels/label-home.pl) are using the "catalogue" permission instead. Actually running 'grep "flagsrequired" ./labels/*' shows either "catalogue => 1" or "tools => 'label_creator'" or "borrowers => 'edit_borrowers'" I wonder if the Perl scripts should have both the "label_creator" sub permission and the "catalogue" permission... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24465 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- It seems correct to update all the label-*.pl script to require "label_creator" permission. My only hesitation is about the quick spine label print option. If you have SpineLabelShowPrintOnBibDetails enabled the bibliographic detail page's holdings table has a column with "Print label" buttons. There is currently no permissions check on that. Should we add a "label_creator" permission check to that button and the corresponding page, or should we leave that one available to users with only "catalogue" permission? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24465 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I feel like it should be separate? It's not necessarily the same people who print patron cards and who print item labels. Especially now that the item labels have been moved in cataloging instead of tools. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org