[Bug 40870] New: Fund code is lost when modifying an order in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Bug ID: 40870 Summary: Fund code is lost when modifying an order in acquisitions Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: - add an order to a basket in acquisitions - confirm your order shows in the basket with a fund code selected - click Modify on your order - note that Fund is empty in the modify form and you need to re-select it -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- It doesn't seem like we are trying to set the fund at all in the dropdown to 'selected'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186884&action=edit Bug 40870: Set the fund code to selected on acqui/neworderempty.pl To tes: 1- add an order to a basket in acquisitions 2- confirm your order shows in the basket with a fund code selected 3- click Modify on your order 4- note that Fund is empty in the modify form and you need to re-select it 5. APPLY PATCH 6. Try steps 1 -4 again, the correct fund should be set on page load -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186884|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 186888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186888&action=edit Bug 40870: Set the fund code to selected on acqui/neworderempty.pl To tes: 1- add an order to a basket in acquisitions 2- confirm your order shows in the basket with a fund code selected 3- click Modify on your order 4- note that Fund is empty in the modify form and you need to re-select it 5. APPLY PATCH 6. Try steps 1 -4 again, the correct fund should be set on page load Signed-off-by: Wendy Bartlett <wbartlett@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186888|0 |1 is obsolete| | --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 186895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186895&action=edit Bug 40870: Set the fund code to selected on acqui/neworderempty.pl To tes: 1- add an order to a basket in acquisitions 2- confirm your order shows in the basket with a fund code selected 3- click Modify on your order 4- note that Fund is empty in the modify form and you need to re-select it 5. APPLY PATCH 6. Try steps 1 -4 again, the correct fund should be set on page load Signed-off-by: Wendy Bartlett <wbartlett@cuyahogalibrary.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |matt.blenkinsop@openfifth.c | |o.uk CC| |matt.blenkinsop@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38714 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714 [Bug 38714] Adjust templates for prettier -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186908&action=edit Bug 40870: Set selected when needed I think this commit simplifies the code a lot. The regression has been caused by commit fe4999ad39a33476fdcf886648e1e52b5947ab04 Bug 38714: acqui/neworderempty.tt It forgot to set the selected attribute. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Could you have a look at this patch please? I think it's a cleaner way to fix the bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186908|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186909&action=edit Bug 40870: Set selected when needed I think this commit simplifies the code a lot. The regression has been caused by commit fe4999ad39a33476fdcf886648e1e52b5947ab04 Bug 38714: acqui/neworderempty.tt It forgot to set the selected attribute. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #7)
Could you have a look at this patch please? I think it's a cleaner way to fix the bug.
Yes, it's much cleaner. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186909|0 |1 is obsolete| | --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186921&action=edit Bug 40870: Set selected when needed I think this commit simplifies the code a lot. The regression has been caused by commit fe4999ad39a33476fdcf886648e1e52b5947ab04 Bug 38714: acqui/neworderempty.tt It forgot to set the selected attribute. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #12 from Mathieu Saby <mathsabypro@gmail.com> --- This fix depends on 38714, that has been backported to 21.11.05. Does it mean that this one needs to be backported too in 21.11 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Mathieu Saby from comment #12)
This fix depends on 38714, that has been backported to 21.11.05. Does it mean that this one needs to be backported too in 21.11 ?
I guess you meant 24.11. No, it has not been backported, see the last comments on the bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 --- Comment #14 from Mathieu Saby <mathsabypro@gmail.com> --- Sorry, indeed I meant 24.11 but I must have opened a wrong bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 38714 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org