[Bug 8956] New: Split serials enumeration data into separate fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Priority: P5 - low Change sponsored?: --- Bug ID: 8956 CC: colin.campbell@ptfs-europe.com Assignee: koha-bugs@lists.koha-community.org Summary: Split serials enumeration data into separate fields Severity: enhancement Classification: Unclassified OS: All Reporter: kyle@bywatersolutions.com Hardware: All Status: NEW Version: master Component: Serials Product: Koha Work to be done 1) Add an option 'published_end_date' to the serials table. It will only be used to represent the last issue date in a bound volume. 2) Data clean up: Extract the published dates from the existing enumeration field. Populate serials.publisheddate and serials.published_end_date with this data. 3) Strip the publishing dates from their enumeration fields (probably by simply deleting matched parentheses and everything in between them). 4) In order to break the “Numbered” field into three columns, add X, Y and Z columns to serials, as well as X, Y and Z descriptions columns to the subscription table. 5) Port existing data into these columns. Once all the enumeration fields are of the correct format, e.g., Vol. X No. Y, we can use everything preceding {X} as X_Description, and everything preceding {Y} until } as Y_Description. Another way to look at this is if we split on {?}, we will have all the label fields in order of use. Once we have the label fields, we can parse those out of the enumeration string, and we will have the set of values they represent. 6) Add a calendar widget for published on and expected on (serials-edit.pl). This will require librarians to enter new dates in the accepted format. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13041&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13042&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13043&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13044&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13045&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13046&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13047&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- TEST PLAN Part 1: 1) Apply patch and run updatedatabase.pl 2) Verify the new fields have been created. The new serialseq fields should be the correct data, assuming the serials are following Koha standards. NOTE: It is not necessary for this data to be absolutely correct. This data is really for statistical purposes at the moment, but do pave the way for future serials improvements. Part 2: 1) Apply the patch 2) Create a new subscription, and add serials to it. The new x y and z fields should be populated with the same data the replaces {X} {Y} and {Z} in the enumeration field. Part 3: 1) Apply the patch 2) Add/update a serial, and choose dates via the datepicker. 3) Verify the data is saved correctly in the database. Part 4: 1) Apply the patch. Add/update a serial, and choose a published end date. 2) Verify the date was stored in the database correctly ( serials.published_end_date ) NOTE: The purpose of this feature is to better handle the dates of bound volumes of serials. Right now, we specify the first published date, but not the published date of the last issue in a bound volume. Part 5-7: 1) Apply the patches 2) Create a new serial. You can now see that instead of having the labels described in the enumeration field, we have three new replacement variables {XL}, {YL} and {ZL}. 3) Generate a new serial and verify the placeholders are replaced with the correct labels. Note: This feature will not affect existing serials, so it should be upgrade safe. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- I think this bug needs some exposition. We have libraries that are finding it difficult to generate reports for serials for the following reasons: 1) Parsing serialseq to get issue/vol/no/whatever data is difficult 2) Librarians put incorrectly formatted dates in the date fields 3) There is no proper way to store the published date of the last issue of a bound volume. Parts 1 through 4 are the only critical patches to resolve these issue. Parts 5-7 are just something I thought would be a nice way to advance the serials module. In the future, it may be possible to stop using serialseq and use the new fields in serial and subscription to display that data. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13041|0 |1 is obsolete| | Attachment #13042|0 |1 is obsolete| | Attachment #13043|0 |1 is obsolete| | Attachment #13044|0 |1 is obsolete| | Attachment #13045|0 |1 is obsolete| | Attachment #13046|0 |1 is obsolete| | Attachment #13047|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15914&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15915&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15916&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15917&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15918&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15919&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15920&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |alex.arnaud@biblibre.com --- Comment #17 from Alex Arnaud <alex.arnaud@biblibre.com> --- First patch does not apply. So, don't try to apply others. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15914|0 |1 is obsolete| | Attachment #15915|0 |1 is obsolete| | Attachment #15916|0 |1 is obsolete| | Attachment #15917|0 |1 is obsolete| | Attachment #15918|0 |1 is obsolete| | Attachment #15919|0 |1 is obsolete| | Attachment #15920|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16346&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16347&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16348&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16349&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16350&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16351&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16352&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16353&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 8 - Perltidy serials/subscription-add.pl again -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #26 from Alex Arnaud <alex.arnaud@biblibre.com> --- I have created a subscription with numbering pattern to "Volume, number" and set: {X} Label: Year {Y} Label: Number I cre -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #27 from Alex Arnaud <alex.arnaud@biblibre.com> --- I created a serial and description is ok: "Year 2013, Number 1". But if i edit this subscription again, x and y label are reset to "Vol" and "Number". But serials are not affected. Adding a new one create a description like "Year 2013, Number 2". Also, it could be better the Test prediction pattern use defined labels instead of "{XL} 2013, {YL} 1" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16346|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18554&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16347|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18555&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16348|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18556&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16349|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18557&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16350|0 |1 is obsolete| | --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18558&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16351|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18559&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16352|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18560&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16353|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18561&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 8 - Perltidy serials/subscription-add.pl again -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 paul.landers@ttuhsc.edu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.landers@ttuhsc.edu --- Comment #36 from paul.landers@ttuhsc.edu --- Kyle, after review by our serials staff I now sign off on this dev. Paul Landers Texas Tech University Health Sciences Center Library I.T. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18554|0 |1 is obsolete| | --- Comment #37 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18568&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18555|0 |1 is obsolete| | --- Comment #38 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18569&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18556|0 |1 is obsolete| | --- Comment #39 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18570&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18557|0 |1 is obsolete| | --- Comment #40 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18571&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18558|0 |1 is obsolete| | --- Comment #41 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18572&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor. Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18559|0 |1 is obsolete| | --- Comment #42 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18573&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18560|0 |1 is obsolete| | --- Comment #43 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18574&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels. Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18561|0 |1 is obsolete| | --- Comment #44 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18575&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 8 - Perltidy serials/subscription-add.pl again Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18568|0 |1 is obsolete| | --- Comment #45 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18576&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18569|0 |1 is obsolete| | --- Comment #46 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18577&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18570|0 |1 is obsolete| | --- Comment #47 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18578&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18571|0 |1 is obsolete| | --- Comment #48 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18579&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18572|0 |1 is obsolete| | --- Comment #49 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18580&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor. Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18573|0 |1 is obsolete| | --- Comment #50 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18581&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18574|0 |1 is obsolete| | --- Comment #51 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18582&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels. Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18575|0 |1 is obsolete| | --- Comment #52 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18583&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 8 - Perltidy serials/subscription-add.pl again Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com --- Comment #53 from Melia Meggs <melia@bywatersolutions.com> --- Helping Paul add his sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #54 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Just some advance remarks: In total this is a larger patch. It could be advantageous if Paul as the one signing off, could further elaborate on what he exactly tested. Did you test various numbering patterns, how much data was converted in the upgrade, etc. etc. In this way we can build up some more confidence in this development. I just had a quick look: The upgrade reports lines like : NUMBERING METHOD: '{X}' Does not seem to be very informative? The label X, etc with Appears in numbering formula as {XL} do not seem very easy to understand on Edit subscription? [This already held for numbering patterns, but life is not simpler now..] Funny date in next issue publication date: 02/00/0 Do not know what happened here, but could be an existing problem.. Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18679&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 9 - Remove print from database update -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #56 from Kyle M Hall <kyle.m.hall@gmail.com> --- He followed the test plan in part 8. (In reply to comment #54)
Just some advance remarks:
In total this is a larger patch. It could be advantageous if Paul as the one signing off, could further elaborate on what he exactly tested. Did you test various numbering patterns, how much data was converted in the upgrade, etc. etc. In this way we can build up some more confidence in this development.
I just had a quick look:
The upgrade reports lines like : NUMBERING METHOD: '{X}' Does not seem to be very informative? The label X, etc with Appears in numbering formula as {XL} do not seem very easy to understand on Edit subscription? [This already held for numbering patterns, but life is not simpler now..] Funny date in next issue publication date: 02/00/0 Do not know what happened here, but could be an existing problem..
Thanks.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #57 from Kyle M Hall <kyle.m.hall@gmail.com> --- The test plan in comment 8 that is ; ) I've also attached a qa followup to remove that print line from the db update. (In reply to comment #56)
He followed the test plan in part 8.
(In reply to comment #54)
Just some advance remarks:
In total this is a larger patch. It could be advantageous if Paul as the one signing off, could further elaborate on what he exactly tested. Did you test various numbering patterns, how much data was converted in the upgrade, etc. etc. In this way we can build up some more confidence in this development.
I just had a quick look:
The upgrade reports lines like : NUMBERING METHOD: '{X}' Does not seem to be very informative? The label X, etc with Appears in numbering formula as {XL} do not seem very easy to understand on Edit subscription? [This already held for numbering patterns, but life is not simpler now..] Funny date in next issue publication date: 02/00/0 Do not know what happened here, but could be an existing problem..
Thanks.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #58 from Melia Meggs <melia@bywatersolutions.com> --- For Paul's testing, he created 2 new serials using an X Y Z numbering pattern (I believe he tried Volume, Number, Issue, as well as Volume, Number, Year, if I remember correctly). He verified that the new fields were showing up, and he tried using the datepicker a few times. He also edited an existing serial to make sure the new fields looked ok. (I was watching with screen sharing while he went through the test plan, and then I helped him with the Git signoff.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this change might be in conflict with the big serials pattern patch that has reached 'Passed QA' already (bug 7688). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #60 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #59)
I think this change might be in conflict with the big serials pattern patch that has reached 'Passed QA' already (bug 7688).
I already talk about this possible problem with Julian (author of the feature 7688). On a functional point of view the 2 features are not in conflict but, inevitably, the patches will not apply cleanly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #61 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #60)
(In reply to Katrin Fischer from comment #59)
I think this change might be in conflict with the big serials pattern patch that has reached 'Passed QA' already (bug 7688).
I already talk about this possible problem with Julian (author of the feature 7688). On a functional point of view the 2 features are not in conflict but, inevitably, the patches will not apply cleanly.
I suppose the big question is: which of the two will be easier to rebase over top the other. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Starting with a code review based on squashed patches: 1) Bug number missing from database update 2) In subscription-add.pl there is a typo, not sure the consequences: - $templte->param(letterloop => $letterloop); + $templte->param( letterloop => $letterloop ); 3) I'd really like to have more information about the use of the published_end_date and bound volumes - this seems to be a separate feature. The test plan says:
Part 4: 1) Apply the patch. Add/update a serial, and choose a published end date. 2) Verify the date was stored in the database correctly ( >serials.published_end_date ) NOTE: The purpose of this feature is to better handle the dates of bound >volumes of serials. Right now, we specify the first published date, but not the >published date of the last issue in a bound volume.
There is currently no real workflow for adding bound volumes - what are you referring to here? What steps lead to a bound volume for this library? -- I am a bit worried about the amount of testing this has seen - was an existing database converted with this patch? What were the results? Were other more unusual subscription patterns tested as well? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #63 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, failing to get your attention and answers to my questions :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #64 from Kyle M Hall <kyle@bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 12375 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org