[Bug 16881] New: Apply KohaTable and ColVis plugin on MARCdetail' s items table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Bug ID: 16881 Summary: Apply KohaTable and ColVis plugin on MARCdetail's items table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: alex.arnaud@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Allows to choose columns to display on items table in the MARCdetail page (cgi-bin/koha/catalogue/MARCdetail.pl). Also, the columns displayed are saved for each users in database. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 53226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53226&action=edit Bug 16881 - Apply KohaTable and ColVis plugin on MARCdetail's items table Also, the columns displayed are saved for each users in database. Test plan: - apply this BZ, - launch perl installer/data/mysql/updatedatabase.pl - launch perl misc/devel/update_dbix_class_files.pl - go to the items tab on cgi-bin/koha/catalogue/MARCdetail.pl page you should be able to hide/show each columns. - leave this page and come back with the same koha account: You should have the same columns shown/hidden as when you left. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53226|0 |1 is obsolete| | --- Comment #2 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 53303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53303&action=edit Bug 16881 - Apply KohaTable and ColVis plugin on MARCdetail's items table Also, the columns displayed are saved for each users in database. Test plan: - apply this BZ, - launch perl installer/data/mysql/updatedatabase.pl - launch perl misc/devel/update_dbix_class_files.pl - go to the items tab on cgi-bin/koha/catalogue/MARCdetail.pl page you should be able to hide/show each columns. - leave this page and come back with the same koha account: You should have the same columns shown/hidden as when you left. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #3 from delaye <stephane.delaye@biblibre.com> --- i have thise message in the sandbox One http://pro.test1.biblibre.com/cgi-bin/koha/catalogue/MARCdetail.pl?biblionum... Template process failed: undef error - DBIx::Class::Schema::resultset(): Can't find source for UsersColumnsSetting at /home/koha/src/C4/Utils/DataTables/DynamicColumnsSettings.pm line 23 For help, please send mail to the webmaster (webmaster@matrice-koha36-sandbox), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 --- Comment #4 from delaye <stephane.delaye@biblibre.com> --- with the updatedatabse it's work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53303|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53510&action=edit [SIGNED-OFF] Bug 16881 - Apply KohaTable and ColVis plugin on MARCdetail's items table Also, the columns displayed are saved for each users in database. Test plan: - apply this BZ, - launch perl installer/data/mysql/updatedatabase.pl - launch perl misc/devel/update_dbix_class_files.pl - go to the items tab on cgi-bin/koha/catalogue/MARCdetail.pl page you should be able to hide/show each columns. - leave this page and come back with the same koha account: You should have the same columns shown/hidden as when you left. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Alex, I wanted to implement this feature for a while, but I don't understand the way you chose :) Why did not you store the value in the browser session? You are adding a new behavior but only for 1 table, it would be good to have it everywhere the columns settings are used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I have to say that I like the idea of storing the chosen options permanently. This seems to reflect what people expect here considering the feedback from training libraries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- I really like this feature and agree with Cait, the ability for users to save their settings will make workflows easier for librarians I agree with Jonathan too, this feature should be made usable for other pages too, even if it is only introduced here first. 1 - C4/Utils/DataTables/DynamicColumnsSettings.pm - sub catalogue_marcdetail_itemst This should be more generic, the work should be done in a function that can be passed data from any page 2 - The script should be moved ot a javascript files for inclusion when necessary, and can then be triggered by code on each page. 3 -The current code calls the service function each time the table is rendered, so a sort will also make a call, this should only happen when column view changes 4 - Ideally when a user restores all columns we shouldn't need to save their data, maybe we only store columns that are exceptions? 5 - This should use the REST api and not an svc script 6 - $schema->resultset('UsersColumnsSetting')->update_or_create This should use Koha::Object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 --- Comment #9 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 59566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59566&action=edit Bug 16881 - Apply KohaTable and ColVis plugin on MARCdetail's items table Also, the columns displayed are saved for each users in database. Test plan: - apply this BZ, - launch perl installer/data/mysql/updatedatabase.pl - launch perl misc/devel/update_dbix_class_files.pl - go to the items tab on cgi-bin/koha/catalogue/MARCdetail.pl page you should be able to hide/show each columns. - leave this page and come back with the same koha account: You should have the same columns shown/hidden as when you left. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 --- Comment #10 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 59567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59567&action=edit Bug 16881 - Apply KohaTable and ColVis plugin on MARCdetail's items table Also, the columns displayed are saved for each users in database. Test plan: - apply this BZ, - launch perl installer/data/mysql/updatedatabase.pl - launch perl misc/devel/update_dbix_class_files.pl - go to the items tab on cgi-bin/koha/catalogue/MARCdetail.pl page you should be able to hide/show each columns. - leave this page and come back with the same koha account: You should have the same columns shown/hidden as when you left. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59566|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53510|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Alex Arnaud <alex.arnaud@biblibre.com> --- Here is a replacement patch. Code is more generic, svc script is replaced with a new REST api method and UsersColumnsSetting has its Koha objects. I change the javascript code to make other tables can use this feature with few changes. It could have been more usable but this means i should have to modify the KohaTable call for all these tables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 --- Comment #12 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Nick Clemens from comment #8)
I really like this feature and agree with Cait, the ability for users to save their settings will make workflows easier for librarians
I agree with Jonathan too, this feature should be made usable for other pages too, even if it is only introduced here first.
1 - C4/Utils/DataTables/DynamicColumnsSettings.pm - sub catalogue_marcdetail_itemst This should be more generic, the work should be done in a function that can be passed data from any page I don't know how to make it more generic. It return all item fields depending on a framwork code...
2 - The script should be moved ot a javascript files for inclusion when necessary, and can then be triggered by code on each page.
3 -The current code calls the service function each time the table is rendered, so a sort will also make a call, this should only happen when column view changes What do you mean by service function ? If you speak about the saveStateCallback, it is called only when a "column button" is clicked.
4 - Ideally when a user restores all columns we shouldn't need to save their data, maybe we only store columns that are exceptions? There is no option for restoring all columns for now.
5 - This should use the REST api and not an svc script
6 - $schema->resultset('UsersColumnsSetting')->update_or_create This should use Koha::Object
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Taking a closer look this is really interesting as it's allowing to store the column definitions by user. Can you please rebase? 59567 - Bug 16881 - Apply KohaTable and ColVis plugin on MARCdetail's items table Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 16881 - Apply KohaTable and ColVis plugin on MARCdetail's items table Using index info to reconstruct a base tree... M api/v1/swagger/definitions.json M api/v1/swagger/paths.json M catalogue/MARCdetail.pl M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt Auto-merging installer/data/mysql/kohastructure.sql Auto-merging catalogue/MARCdetail.pl Auto-merging api/v1/swagger/paths.json Auto-merging api/v1/swagger/definitions.json CONFLICT (content): Merge conflict in api/v1/swagger/definitions.json error: Failed to merge in the changes. Patch failed at 0001 Bug 16881 - Apply KohaTable and ColVis plugin on MARCdetail's items table The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-16881---Apply-KohaTable-and-ColVis-plugin-on-M-0QlVGC.patch sloth:/usr/local/vagrant/kohaclone_master (58-16881-colvis|AM 1/1) $ git status On branch 58-16881-colvis You are in the middle of an am session. (fix conflicts and then run "git am --continue") (use "git am --skip" to skip this patch) (use "git am --abort" to restore the original branch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #14 from Joy Nelson <joy@bywatersolutions.com> --- Would this include allowing users to change the order in which the columns display? i.e. callnumber followed by enumeration followed by barcode, etc... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Joy Nelson from comment #14)
Would this include allowing users to change the order in which the columns display?
No, it only allows for the showing or hiding columns in place. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59567|0 |1 is obsolete| | --- Comment #16 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79107&action=edit Bug 16881 - Apply KohaTable and ColVis plugin on MARCdetail's items table Also, the columns displayed are saved for each users in database. Test plan: - apply this BZ, - launch perl installer/data/mysql/updatedatabase.pl - launch perl misc/devel/update_dbix_class_files.pl - go to the items tab on cgi-bin/koha/catalogue/MARCdetail.pl page you should be able to hide/show each columns. - leave this page and come back with the same koha account: You should have the same columns shown/hidden as when you left. Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-09-19) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 --- Comment #17 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79108&action=edit Bug 16881: update schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- After testing hiding and showing columns, I see entries in users_columns_settings for my account, but is_hidden is 0 even if I have selected columns to be hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 --- Comment #19 from Alex Arnaud <alex.arnaud@biblibre.com> --- I can't reproduce that. Hiding a column set is_hidden to 1 and vice versa. I may miss a specific use case. Can you tell me exactly what you did? As you've probably noticed, we don't store the column name in database but the corresponding mapped subfield. Are you checking the right one? Also, changes are done using an asynchronous call to the API. This may take some time depending on your local instance/hardware. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- H Alex, I wanted to see if I can replicate Owen's problem, but the patches on longer apply :( One thing I'd like to make sure is that user configured upper case subfields (mapped to more_subfields_xml) still can be shown - it's about the only place they do show at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27467 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22276 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #21 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- This bug seems to partially reproduce bug 22276 which was closed fixed (at least the "column setting store per user" feature). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- *** This bug has been marked as a duplicate of bug 33484 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org