[Bug 30205] New: Add biblio.subtitle to the subscription-detail.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Bug ID: 30205 Summary: Add biblio.subtitle to the subscription-detail.pl page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org On the subscription-detail page we show the biblio.title, we should also show the biblio.subtitle, if it exists. This can be shown both in the h1 heading and on the 'Biblio:' line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131201&action=edit Bug 30205: Add subtitle to subscription detail page To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Click on one of those subscription to be taken to the subscription detail page. 4. Look at the main heading (h1) and the "Biblio:" line. Notice there is no subtitle in either place 5. Apply patch, restart_all, and reload the subscription detail page. 6. You should now see the subtitle on both the main heading (h1) and on the 'Biblio:' line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Text to go in the| |Add the biblio.subtitle to release notes| |the serial subscription | |details page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Did you look at including biblio-title.inc? Maybe it's overkill here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #2)
Did you look at including biblio-title.inc? Maybe it's overkill here?
I did not, but now I will! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- *** Bug 23499 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30302 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30302 [Bug 30302] Include subtitle in fields searched by Title in serials -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131201|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 131762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131762&action=edit Bug 30205: Add subtitle to subscription detail page To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Click on one of those subscription to be taken to the subscription detail page. 4. Look at the main heading (h1) and the "Biblio:" line. Notice there is no subtitle in either place 5. Apply patch, restart_all, and reload the subscription detail page. 6. You should now see the subtitle on both the main heading (h1) and on the 'Biblio:' line. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131762|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132915&action=edit Bug 30205: Add subtitle to subscription detail page To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Click on one of those subscription to be taken to the subscription detail page. 4. Look at the main heading (h1) and the "Biblio:" line. Notice there is no subtitle in either place 5. Apply patch, restart_all, and reload the subscription detail page. 6. You should now see the subtitle on both the main heading (h1) and on the 'Biblio:' line. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #3)
(In reply to Owen Leonard from comment #2)
Did you look at including biblio-title.inc? Maybe it's overkill here?
I did not, but now I will!
Hi Andrew, I am ok with the patch as is, but maybe you can add a note why not biblio-title.inc? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.06 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34199 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34199 [Bug 34199] Add part_name and part_number to subscription result list -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org