[Bug 29113] New: Requires code field for additional contents appears unnecessary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Bug ID: 29113 Summary: Requires code field for additional contents appears unnecessary Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When adding a HTML customization there is now a new required "Code" field that has to be filled in. Is this really necessary? * The old news editor didn't require this additional field. * None of the HTML customizations is repeatable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- * The code doesn't show in the list of entries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Requires code field for |Required new "code" field |additional contents appears |for additional contents |unnecessary |appears unnecessary -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... and why don't we use the internal id? :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It groups the entries together. Like you have news_1 that is translated in different languages, the code will be the same for the different rows and the system will know they represent the same content. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It's the same behaviour we have for notice templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if we could not do better solving this with an additional ID or generated code instead of relying on user entry here if that's the only use case. But if we keep it, should we not make it visible in the table too? For the notices the code is also used in the code, so we have to rely on the codes being right for activating/deactivating the functionality. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125695&action=edit Bug 29113: Hide code for additional contents and generate it additional_contents.code is used to group DB rows together. Each row represent one content in a given language, and the code is used to know they are translation of the lang='default' one. It's not really useful for the end user and we could hide it and generate it. Test plan: Create/Edit/Delete additional contents (news and HTML customizations) and confirm that they are correctly grouped together. You need several languages installed to test this patch correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125695|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125696&action=edit Bug 29113: Hide code for additional contents and generate it additional_contents.code is used to group DB rows together. Each row represent one content in a given language, and the code is used to know they are translation of the lang='default' one. It's not really useful for the end user and we could hide it and generate it. Test plan: Create/Edit/Delete additional contents (news and HTML customizations) and confirm that they are correctly grouped together. You need several languages installed to test this patch correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- If i add a new item, defining several languages on the initial save then the code is set as NULL for all entries Adding a second does the same and they are all grouped as a single entry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125861&action=edit Bug 29113: Fix random assignation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Nick, I don't recreate what you describe. But I found a bug when testing (title and content were getting a random language). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Could this code field be used too as a sort of alias for passing the internal identifier (idnew?) to opac-main ? See bug 29190 Or should that better be another (new) field? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24387 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 [Bug 24387] Rename News tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Bug 29113 depends on bug 24387, which changed state. Bug 24387 Summary: Rename News tool https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + for my $lang ( sort {$a ne 'default'} @lang ) { # Process 'default' first Hmm. Nice coding pattern. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #9)
Created attachment 125861 [details] [review] Bug 29113: Fix random assignation
Unclear commit message, no test plan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- If the title says that it is unnecessary, why not remove it? Or should you better adjust the title? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #14)
If the title says that it is unnecessary, why not remove it? Or should you better adjust the title?
We need it, to group rows together (rows have different languages, but represent the same content). However the end users don't need it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #15)
(In reply to Marcel de Rooy from comment #14)
If the title says that it is unnecessary, why not remove it? Or should you better adjust the title?
We need it, to group rows together (rows have different languages, but represent the same content). However the end users don't need it.
Adjust the title then? If title and commit messages are unclear, getting it further may be more complicated? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #13)
(In reply to Jonathan Druart from comment #9)
Created attachment 125861 [details] [review] [review] Bug 29113: Fix random assignation
Unclear commit message, no test plan
Because of the sort we cannot shift. So we need to specify and retrieve explicitly what we need (using $lang) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Required new "code" field |New "code" field for |for additional contents |additional contents is not |appears unnecessary |useful for the end users --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #17)
(In reply to Marcel de Rooy from comment #13)
(In reply to Jonathan Druart from comment #9)
Created attachment 125861 [details] [review] [review] [review] Bug 29113: Fix random assignation
Unclear commit message, no test plan
Because of the sort we cannot shift. So we need to specify and retrieve explicitly what we need (using $lang)
Done, commit message read good to me however. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #16)
(In reply to Jonathan Druart from comment #15)
(In reply to Marcel de Rooy from comment #14)
If the title says that it is unnecessary, why not remove it? Or should you better adjust the title?
We need it, to group rows together (rows have different languages, but represent the same content). However the end users don't need it.
Adjust the title then? If title and commit messages are unclear, getting it further may be more complicated?
Done, commit message read good to me however. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is one of the reasons I was keen to have distinct tables for these features rather than combine them I think.. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387#c30 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry, sha1 errors, I can't get this one to apply. My feeling is.. this hides an issue nicely as an interim measure.. I still feel that we should split the features to allow them to develop independently and at that point we can drop the superfluous 'code' field for this particular use case. I'm still keen on 'News', 'Blocks' and 'Pages' at the end of the day -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125861|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127365&action=edit Bug 29113: Fix random assignation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #21)
Sorry, sha1 errors, I can't get this one to apply.
My feeling is.. this hides an issue nicely as an interim measure.. I still feel that we should split the features to allow them to develop independently and at that point we can drop the superfluous 'code' field for this particular use case.
I'm still keen on 'News', 'Blocks' and 'Pages' at the end of the day
Which issue is hidden? We need this column, even if we split the features (what would we gain?). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- To go further: 1. We should add "pages" to this table (and so don't split the table or we will end up with 3 identical tables). This is related to bug 27527. 2. I actually think we should put the notice templates into this table (merge them at least) 3. What we need to avoid this code is to normalize and have 2 tables, linked together. additional_contents - id - category - published_on - updated_on - expirationdate - number Another table for translations: - fk - lang (or eventually fk to a lang table) - title - content And, this is similar to the itemtypes, av, etc. translation story. Translations in the DB must be reconsidered, but it's another topic... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Can we move forward? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #24)
additional_contents - id - category - published_on - updated_on - expirationdate - number
Another table for translations: - fk - lang (or eventually fk to a lang table) - title - content
This looks better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #26)
(In reply to Jonathan Druart from comment #24)
additional_contents - id - category - published_on - updated_on - expirationdate - number
Another table for translations: - fk - lang (or eventually fk to a lang table) - title - content
This looks better.
But this is not for now :D However I still think we should hide the code for 21.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29515 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + code => $code || 'tmp_code', Please explain. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #28)
+ code => $code || 'tmp_code',
Please explain. The code is mandatory at DB level so we must add a temporary code during the insert, then update it after
I feel like it should actually be 'tmp_code' always, at this point we are creating a new entry and $code should never be set. We could add the following change diff --git a/tools/additional-contents.pl b/tools/additional-contents.pl index e63a44a809a..59721e24b2a 100755 --- a/tools/additional-contents.pl +++ b/tools/additional-contents.pl @@ -159,7 +159,7 @@ elsif ( $op eq 'add_validate' ) { my $additional_content = Koha::AdditionalContent->new( { category => $category, - code => $code || 'tmp_code', + code => 'tmp_code', location => $location, branchcode => $branchcode, title => $title, @@ -173,13 +173,11 @@ elsif ( $op eq 'add_validate' ) { )->store; eval { $additional_content->store; - unless ($code) { - $additional_content->discard_changes; - $code = $category eq 'news' - ? 'News_' . $additional_content->idnew - : $location . '_' . $additional_content->idnew; - $additional_content->code($code)->store; - } + $additional_content->discard_changes; + $code = $category eq 'news' + ? 'News_' . $additional_content->idnew + : $location . '_' . $additional_content->idnew; + $additional_content->code($code)->store; }; if ($@) { $success = 0; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125696|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127856&action=edit Bug 29113: Hide code for additional contents and generate it additional_contents.code is used to group DB rows together. Each row represent one content in a given language, and the code is used to know they are translation of the lang='default' one. It's not really useful for the end user and we could hide it and generate it. Test plan: Create/Edit/Delete additional contents (news and HTML customizations) and confirm that they are correctly grouped together. You need several languages installed to test this patch correctly. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127365|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127857&action=edit Bug 29113: Fix random assignation Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Works, but the 'code' could be nicer. Still time for another QAer today? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127856|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127989&action=edit Bug 29113: Hide code for additional contents and generate it additional_contents.code is used to group DB rows together. Each row represent one content in a given language, and the code is used to know they are translation of the lang='default' one. It's not really useful for the end user and we could hide it and generate it. Test plan: Create/Edit/Delete additional contents (news and HTML customizations) and confirm that they are correctly grouped together. You need several languages installed to test this patch correctly. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127857|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127990&action=edit Bug 29113: Fix random assignation Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29693 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 [Bug 29693] CodeMirror broken on additional_contents.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> ---
additional_contents.code is used to group DB rows together. Each row represent one content in a given language, and the code is used to know they are translation of the lang='default' one.
It's not really useful for the end user and we could hide it and generate it.
Opening a new bug to allow configuring this code somehow. I need some more flexibility on e.g. bug 31503. It adds a location PatronConsent but I need codes like PatronConsent_[suffix] where suffix points to a specific patron consent type. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31509 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org