[Bug 33453] New: Confirmation button for 'Record cashup' should be yellow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 Bug ID: 33453 Summary: Confirmation button for 'Record cashup' should be yellow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When recording a cashup the confirmation button in the modal should be 'yellow' for the primary action. * Enable cash registers and create a cash register * Go to Tools > Transaction history for ... * Click on 'Record cashup' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 --- Comment #1 from Koha Training Catalyst <koha-training@catalyst.net.nz> --- Created attachment 169617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169617&action=edit Bug 33453: Change the button class of the record cashup modal to btn-primary To test: 1. Go to System Preferences > find and enable "Use cash registers" 2. Go to Administration > "Cash registers" and create a new cash register 3. Go to Tools > "Transaction history for" > "Record cashup" 4. Click "Record cashup" 5. Modal with change: "Confirm" should be yellow and primary. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 Koha Training Catalyst <koha-training@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 Koha Training Catalyst <koha-training@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169617|0 |1 is obsolete| | --- Comment #2 from Koha Training Catalyst <koha-training@catalyst.net.nz> --- Created attachment 169621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169621&action=edit Bug 33453: Change the button class of the record cashup modal to btn-primary To test: 1. Go to System Preferences > find and enable "Use cash registers" 2. Go to Administration > "Cash registers" and create a new cash register 3. Go to Tools > "Transaction history for" > "Record cashup" 4. Click "Record cashup" 5. Modal with change: "Confirm" should be yellow and primary. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169621|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 169641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169641&action=edit Bug 33453: Change the button class of the record cashup modal to btn-primary To test: 1. Go to System Preferences > find and enable "Use cash registers" 2. Go to Administration > "Cash registers" and create a new cash register 3. Go to Tools > "Transaction history for" > "Record cashup" 4. Click "Record cashup" 5. Modal with change: "Confirm" should be yellow and primary. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Text to go in the| |This fixes the style of the release notes| |"Confirm" button in the | |pop-up window when | |recording a cashup (Tools > | |Transaction history for > | |Record cashup). The button | |was changed from the | |default button style (with | |a white background) to the | |yellow primary action | |button. CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Hi. I have added a release note. I also changed the bug from an enhancement to a minor bug, as it is something inconsistent with the rest of the UI that requires fixing. Everything works as expected - nice work! To get credit on the dashboard (https://dashboard.koha-community.org/), and to be listed as a Koha developer on the Koha timeline page, please update the assignee for the bug. David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Whilst the code here is good, I'd really like to see accountability in the author of the patch.. we shouldn't be sharing accounts for authoring commits.. Please correct the patch by adding a proper author to it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hi Martin This was for a 2 hour bug squashing session. I'll contact the author to change the Assignee on the bug report. It's not a regular occurrence that we're sharing authorship. If the code is fine can we please set this back to Signed Off? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 Vicki <vicki.mckay@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vicki.mckay@catalyst.net.nz Assignee|koha-bugs@lists.koha-commun |vicki.mckay@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 --- Comment #7 from Vicki <vicki.mckay@catalyst.net.nz> --- Sorry Martin! Aleisha did remind me to do this, and then I forgot :) Was a pleasure to participate in some Koha development for the first time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Vicki from comment #7)
Sorry Martin!
Aleisha did remind me to do this, and then I forgot :)
Was a pleasure to participate in some Koha development for the first time.
Hi Vicky, if you let me know which name you want to appear and if this email address is ok to use, I can update the patch file for you with that information to move it back into the queue. Thanks for participating and providing a patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169641|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169940&action=edit Bug 33453: Change the button class of the record cashup modal to btn-primary To test: 1. Go to System Preferences > find and enable "Use cash registers" 2. Go to Administration > "Cash registers" and create a new cash register 3. Go to Tools > "Transaction history for" > "Record cashup" 4. Click "Record cashup" 5. Modal with change: "Confirm" should be yellow and primary. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks Vicki (and Aliesha for organising the bug squashing event), I've amended the patch and passed it now, many thanks Martin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Congratulations Vicki, you are now officially a Koha developer :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.04 released in| | Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.11.00,24.05.04 |24.11.00,24.05.04,23.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #15 from wainuiwitikapark@catalyst.net.nz --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #16 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org