http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9455 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 14777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14777&action=edit Proposed patch Testing: Functionality should remain unchanged. Retrieval of basketgroups in acquisitions should not be affected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9455 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14777|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14897&action=edit [SIGNED-OFF] Bug 9455: Remove unnecessary quoting from sql Wa've removed the mysql specific back quotes from sql files But this case remained of them embedded in an sql string Also removed the unnecessary call to finish and temporary variable in the subroutine return Testing: Functionality should remain unchanged. Retrieval of basketgroups in acquisitions should not be affected Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works according to test instructions: Basketgroups functionality appears to work normally. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9455 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14897|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15480&action=edit [PASSED QA] Bug 9455: Remove unnecessary quoting from sql Wa've removed the mysql specific back quotes from sql files But this case remained of them embedded in an sql string Also removed the unnecessary call to finish and temporary variable in the subroutine return Testing: Functionality should remain unchanged. Retrieval of basketgroups in acquisitions should not be affected Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works according to test instructions: Basketgroups functionality appears to work normally. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked SQL produces the same results as before and did some tests on the basket group functionality. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9455 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.