https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35148 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35148 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 157801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157801&action=edit Bug 35148: before_send_messages plugin hook does not pass the --where option The before_send_messages plugin hook currently sends all the non-smtp related options with the exception of the --where option. This should be added. Test Plan: 1) Install the latest version of the kitchen sink plugin ( https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/releases ) 2) Apply this patch 3) Run process_message_queue.pl with a --where option 4) Run the command: ./misc/cronjobs/process_message_queue.pl --where "letter_code='test'" 5) Note the output looks like: Plugin hook before_send_message called with the params: $VAR1 = { 'verbose' => 0, 'where' => 'letter_code=\'test\'', 'letter_code' => [], 'type' => [], 'limit' => undef }; -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35148 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157801|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157802&action=edit Bug 35148: before_send_messages plugin hook does not pass the --where option The before_send_messages plugin hook currently sends all the non-smtp related options with the exception of the --where option. This should be added. Test Plan: 1) Install the latest version of the kitchen sink plugin ( https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/releases ) 2) Apply this patch 3) Run process_message_queue.pl with a --where option 4) Run the command: ./misc/cronjobs/process_message_queue.pl --where "letter_code='test'" 5) Note the output looks like: Plugin hook before_send_message called with the params: $VAR1 = { 'verbose' => 0, 'where' => 'letter_code=\'test\'', 'letter_code' => [], 'type' => [], 'limit' => undef }; Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35148 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is a tiny chance and makes perfect sense.. Must admit, I expected to see the hook within C4::Letters::SendQueuedMessages as opposed to in the cron script... but that's nothing to do with this patch. Going straight for a PQA :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35148 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35148 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35148 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.