[Bug 38313] New: RESTOAuth2ClientCredentials pref description is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 Bug ID: 38313 Summary: RESTOAuth2ClientCredentials pref description is confusing Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jake.deery@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In Bug 20734, we added a string informing sysadmins that Net::OAuth2::AuthorizationServer is required for the RESTOAuth2ClientCredentials syspref to be operable. I don't think we need this anymore, as for git installs this is in the cpanfile, and for package installs this is included as a dependency for koha-perldeps. Could we remove this string to a) tidy things up, and b) avoid confusion of people installing the cpan module twice (once in Debian, and once in cpan-land)? Jake. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 --- Comment #1 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 173803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173803&action=edit Bug 38313: Remove confusing string from RESTOAuth2ClientCredentials This patch removes a once necessary and now confusing warning from the RESTOAuth2ClientCredentials syspref. TO TEST: a) Notice how the RESTOAuth2ClientCredentials syspref references installing Net::OAuth2::AuthorizationServer, even though this module is in the cpanfile and koha-perldeps and has been since 22.11 b) APPLY PATCH c) Notice how the message is now gone -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173803|0 |1 is obsolete| | --- Comment #2 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 173804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173804&action=edit Bug 38313: Remove confusing string from RESTOAuth2ClientCredentials This patch removes a once necessary and now confusing warning from the RESTOAuth2ClientCredentials syspref. TO TEST: a) Notice how the RESTOAuth2ClientCredentials syspref references installing Net::OAuth2::AuthorizationServer, even though this module is in the cpanfile and koha-perldeps and has been since 22.11 b) APPLY PATCH c) Run reset_all in k.t.d d) Notice how the message is now gone -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173804|0 |1 is obsolete| | --- Comment #3 from William Lavoie <william.lavoie@inLibro.com> --- Created attachment 176476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176476&action=edit Bug 38313: Remove confusing string from RESTOAuth2ClientCredentials This patch removes a once necessary and now confusing warning from the RESTOAuth2ClientCredentials syspref. TO TEST: a) Notice how the RESTOAuth2ClientCredentials syspref references installing Net::OAuth2::AuthorizationServer, even though this module is in the cpanfile and koha-perldeps and has been since 22.11 b) APPLY PATCH c) Run reset_all in k.t.d d) Notice how the message is now gone Signed-off-by: William Lavoie <william.lavoie@inLibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- cpanfile:recommends 'Net::OAuth2::AuthorizationServer', '0.16'; It's recommends, not requires. I guess that's why it's in the description of the syspref. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 --- Comment #5 from Jake Deery <jake.deery@ptfs-europe.com> --- When you install a package, it is included as a dependency. This can be verified by looking at the metadata of the koha-perldeps package. Perhaps we should update the cpanfile too? Jake. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |jake.deery@ptfs-europe.com |ity.org | QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176476|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 176867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176867&action=edit Bug 38313: Remove confusing string from RESTOAuth2ClientCredentials This patch removes a once necessary and now confusing warning from the RESTOAuth2ClientCredentials syspref. TO TEST: a) Notice how the RESTOAuth2ClientCredentials syspref references installing Net::OAuth2::AuthorizationServer, even though this module is in the cpanfile and koha-perldeps and has been since 22.11 b) APPLY PATCH c) Run reset_all in k.t.d d) Notice how the message is now gone Signed-off-by: William Lavoie <william.lavoie@inLibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|RESTOAuth2ClientCredentials |RESTOAuth2ClientCredentials |pref description is |system preference |confusing |description is confusing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38184 [Bug 38184] OpacTrustedCheckout module does not show due date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38184 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38184 [Bug 38184] OpacTrustedCheckout module does not show due date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.05.00 |25.05.00,24.11.08 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38313 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org