[Bug 29495] New: Issue link is lost in return claims when using 'MarkLostItemsAsReturned'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Bug ID: 29495 Summary: Issue link is lost in return claims when using 'MarkLostItemsAsReturned' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com We have a foreign key constraint in return_claims for issue_id.. this means that if you have 'MarkLostItemsAsReturned' enabled, we first add the issue_id linking to the original checkout, then immediately move the checkout to old_issues and nuke the issue_id from the claims_return table :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127711&action=edit Bug 29495: Drop issue_id constraint from return_claims This patch removes the issue_id constraint from return_claims. Due to the nature of our dual table approach to checkouts/old_checkouts we can't safely hae this constraint and not lose data. Prior to this commit, when an item is checked in we move the checkout from checkouts to old_checkouts.. this therefore triggers the delete of the issue_id from the return_claims table as described by the foreign key constraint. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127712&action=edit Bug 29495: DBIC Schema Rebuild -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127713&action=edit Bug 29495: Add DBIC relationships back into Schema This patch adds the relationship accessors back into the affected Schema classes, now below the fold so they are retained during dbic rebuilds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127714&action=edit Bug 29495: Add code level constraint replacement This patch adds a check in Koha::Checkouts::ReturnClaim::store to replace the database level foreign key check. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |nick@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- DB update should use primary_key_exists so it is idempotent. The last patch could add claim object methods that use something like return Koha::Checkouts->new_from_dbic( $self->_result->issue ) to allow prefetching, but I don't think that's absolutely necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127711|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127765&action=edit Bug 29495: Drop issue_id constraint from return_claims This patch removes the issue_id constraint from return_claims. Due to the nature of our dual table approach to checkouts/old_checkouts we can't safely hae this constraint and not lose data. Prior to this commit, when an item is checked in we move the checkout from checkouts to old_checkouts.. this therefore triggers the delete of the issue_id from the return_claims table as described by the foreign key constraint. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127712|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127766&action=edit Bug 29495: DBIC Schema Rebuild -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127713|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127767&action=edit Bug 29495: Add DBIC relationships back into Schema This patch adds the relationship accessors back into the affected Schema classes, now below the fold so they are retained during dbic rebuilds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127714|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127768&action=edit Bug 29495: Add code level constraint replacement This patch adds a check in Koha::Checkouts::ReturnClaim::store to replace the database level foreign key check. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127769&action=edit Bug 29495: Update relationship methods This patch updates the relationship methods found in Koha::Checkouts::ReturnClaim so that they are prefetchable and embeddable on the API. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the review Kyle.. I've implemented the requested improvements now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 [Bug 29519] One should be able to resolve a return claim at checkin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29519 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 [Bug 29519] One should be able to resolve a return claim at checkin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 [Bug 29519] One should be able to resolve a return claim at checkin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28854 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127765|0 |1 is obsolete| | --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 127809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127809&action=edit Bug 29495: Drop issue_id constraint from return_claims This patch removes the issue_id constraint from return_claims. Due to the nature of our dual table approach to checkouts/old_checkouts we can't safely hae this constraint and not lose data. Prior to this commit, when an item is checked in we move the checkout from checkouts to old_checkouts.. this therefore triggers the delete of the issue_id from the return_claims table as described by the foreign key constraint. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127766|0 |1 is obsolete| | --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 127810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127810&action=edit Bug 29495: DBIC Schema Rebuild Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127767|0 |1 is obsolete| | --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 127811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127811&action=edit Bug 29495: Add DBIC relationships back into Schema This patch adds the relationship accessors back into the affected Schema classes, now below the fold so they are retained during dbic rebuilds. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127768|0 |1 is obsolete| | --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 127812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127812&action=edit Bug 29495: Add code level constraint replacement This patch adds a check in Koha::Checkouts::ReturnClaim::store to replace the database level foreign key check. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127769|0 |1 is obsolete| | --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 127813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127813&action=edit Bug 29495: Update relationship methods This patch updates the relationship methods found in Koha::Checkouts::ReturnClaim so that they are prefetchable and embeddable on the API. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127937&action=edit Bug 29495: Unit Tests Test plan 1. Run updated tests prior to applying new patches.. pass 2. Run updated tests after applying new patches.. pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127809|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127938&action=edit Bug 29495: Drop issue_id constraint from return_claims This patch removes the issue_id constraint from return_claims. Due to the nature of our dual table approach to checkouts/old_checkouts we can't safely hae this constraint and not lose data. Prior to this commit, when an item is checked in we move the checkout from checkouts to old_checkouts.. this therefore triggers the delete of the issue_id from the return_claims table as described by the foreign key constraint. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127810|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127939&action=edit Bug 29495: DBIC Schema Rebuild Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127811|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127940&action=edit Bug 29495: Add DBIC relationships back into Schema This patch adds the relationship accessors back into the affected Schema classes, now below the fold so they are retained during dbic rebuilds. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127812|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127941&action=edit Bug 29495: Add code level constraint replacement This patch adds a check in Koha::Checkouts::ReturnClaim::store to replace the database level foreign key check. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127813|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127942&action=edit Bug 29495: Update relationship methods This patch updates the relationship methods found in Koha::Checkouts::ReturnClaim so that they are prefetchable and embeddable on the API. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127943&action=edit Bug 29495: (follow-up) Use 'item' relationship This patch adds the missing 'item' relationship in Checkouts::ReturnClaim and then uses it from the resolve method. This improve the reliability of the resolution code so it works when the item has already been checked in (without having to check Old::Checkouts). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127944&action=edit Bug 29495: Add relation tests This patch adds missing tests for relationship accessors in the ReturnClaim class. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Added missing unit tests.. we're well covered now.. over to QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (Wouldn't it be better to put effort in merging the tables?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #26)
(Wouldn't it be better to put effort in merging the tables?)
We have blocked a lot of important bug fixes because of the merge table question... at the moment I think fixing bugs is more reachable than the table merge which also could never be backported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127937|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127938|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127940|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127941|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127942|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127944|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129105&action=edit Bug 29495: Unit Tests Test plan 1. Run updated tests prior to applying new patches.. pass 2. Run updated tests after applying new patches.. pass Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129106&action=edit Bug 29495: Drop issue_id constraint from return_claims This patch removes the issue_id constraint from return_claims. Due to the nature of our dual table approach to checkouts/old_checkouts we can't safely hae this constraint and not lose data. Prior to this commit, when an item is checked in we move the checkout from checkouts to old_checkouts.. this therefore triggers the delete of the issue_id from the return_claims table as described by the foreign key constraint. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129107&action=edit Bug 29495: DBIC Schema Rebuild Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129109&action=edit Bug 29495: Add DBIC relationships back into Schema This patch adds the relationship accessors back into the affected Schema classes, now below the fold so they are retained during dbic rebuilds. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129110&action=edit Bug 29495: Add code level constraint replacement This patch adds a check in Koha::Checkouts::ReturnClaim::store to replace the database level foreign key check. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129111&action=edit Bug 29495: Update relationship methods This patch updates the relationship methods found in Koha::Checkouts::ReturnClaim so that they are prefetchable and embeddable on the API. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129112&action=edit Bug 29495: (follow-up) Use 'item' relationship This patch adds the missing 'item' relationship in Checkouts::ReturnClaim and then uses it from the resolve method. This improve the reliability of the resolution code so it works when the item has already been checked in (without having to check Old::Checkouts). Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129113&action=edit Bug 29495: Add relation tests This patch adds missing tests for relationship accessors in the ReturnClaim class. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #36 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #37 from Fridolin Somers <fridolin.somers@biblibre.com> --- Arf this breaks the unit test t/db_dependent/TestBuilder.t : Value not allowed for auto_incr issue_id in Issue at /kohadevbox/koha/t/lib/TestBuilder.pm line 387. not ok 507 - Testing Koha::Checkouts::ReturnClaims # Failed test 'Testing Koha::Checkouts::ReturnClaims' # at t/db_dependent/TestBuilder.t line 401. # got: '' # expected: 'Koha::Checkouts::ReturnClaim' not ok 508 - Module Koha::Checkouts::ReturnClaims should have koha_object[s]_class method if needed # Failed test 'Module Koha::Checkouts::ReturnClaims should have koha_object[s]_class method if needed' # at t/db_dependent/TestBuilder.t line 404. # got: 'Can't call method "get_from_storage" on an undefined value at t/db_dependent/TestBuilder.t line 403. # ' # expected: '' 1..508 # Looks like you failed 2 tests of 508. Can you have a look please ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129547&action=edit Bug 29495: (follow-up) Fix Tests Update DBIC relation types to prevent double issue creation during object build. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #39 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #38)
Created attachment 129547 [details] [review] Bug 29495: (follow-up) Fix Tests
Update DBIC relation types to prevent double issue creation during object build.
Don't push that right now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129575&action=edit Bug 29495: Fix TestBuilder.t Value not allowed for auto_incr issue_id in Issue at /kohadevbox/koha/t/lib/TestBuilder.pm line 387. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Martin, this patch fixes the failure and don't modify the relation. It seems better to me. What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Seems like a better approach to me :).. I wasn't close enough to TestBuilder to spot where I'd need to do that. Thanks Jonathan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129547|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129575|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129582&action=edit Bug 29495: Fix TestBuilder.t Value not allowed for auto_incr issue_id in Issue at /kohadevbox/koha/t/lib/TestBuilder.pm line 387. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #44 from Fridolin Somers <fridolin.somers@biblibre.com> --- Thanks Martin and Jonathan I understand the keyword "additional_work_needed". UT is now OK : kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/TestBuilder.t t/db_dependent/TestBuilder.t .. ok All tests successful. Files=1, Tests=15, 42 wallclock secs ( 0.07 usr 0.01 sys + 32.63 cusr 8.45 csys = 41.16 CPU) Result: PASS Tell me if can be pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Fridolin Somers from comment #44)
Tell me if can be pushed.
Yes, it's ready for push. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #46 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed master : Bug 29495: Fix TestBuilder.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #48 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm getting a qa failure after applying these to 21.05. Should this maybe depend on bug 28588? Please rebase for backport to 21.05 if possible. Thanks! Here's the error I got: FAIL t/db_dependent/Koha/Checkouts/ReturnClaim.t FAIL valid Version control conflict marker Version control conflict marker Type of arg 1 to Test::Exception::throws_ok must be block or sub {} (not reference constructor) Type of arg 1 to Test::Exception::throws_ok must be block or sub {} (not reference constructor) Type of arg 1 to Test::Exception::throws_ok must be block or sub {} (not reference constructor) Version control conflict marker t/db_dependent/Koha/Checkouts/ReturnClaim.t had compilation errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #49 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130460&action=edit [21.05.x] Bug 29495: Unit Tests Test plan 1. Run updated tests prior to applying new patches.. pass 2. Run updated tests after applying new patches.. pass Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #50 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130461&action=edit [21.05.x] Bug 29495: Drop issue_id constraint from return_claims This patch removes the issue_id constraint from return_claims. Due to the nature of our dual table approach to checkouts/old_checkouts we can't safely hae this constraint and not lose data. Prior to this commit, when an item is checked in we move the checkout from checkouts to old_checkouts.. this therefore triggers the delete of the issue_id from the return_claims table as described by the foreign key constraint. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #51 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130462&action=edit [21.05.x] Bug 29495: DBIC Schema Rebuild Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #52 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130463&action=edit [21.05.x] Bug 29495: Add DBIC relationships back into Schema This patch adds the relationship accessors back into the affected Schema classes, now below the fold so they are retained during dbic rebuilds. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #53 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130464&action=edit [21.05.x] Bug 29495: Add code level constraint replacement This patch adds a check in Koha::Checkouts::ReturnClaim::store to replace the database level foreign key check. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #54 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130465&action=edit [21.05.x] Bug 29495: Update relationship methods This patch updates the relationship methods found in Koha::Checkouts::ReturnClaim so that they are prefetchable and embeddable on the API. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #55 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130466&action=edit [21.05.x] Bug 29495: (follow-up) Use 'item' relationship This patch adds the missing 'item' relationship in Checkouts::ReturnClaim and then uses it from the resolve method. This improve the reliability of the resolution code so it works when the item has already been checked in (without having to check Old::Checkouts). Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #56 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130467&action=edit [21.05.x] Bug 29495: Fix TestBuilder.t Value not allowed for auto_incr issue_id in Issue at /kohadevbox/koha/t/lib/TestBuilder.pm line 387. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #57 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Thanks for the 21.05 patches, Tomas! You did not make a 21.05 version of the "Add relationship tests" patch. The merge errors on that one seemed pretty simple to clear, so I'm not sure what's the source of the qa error I'm getting now (with all of your 21.05 patches and the regular version of Add Relationship Tests): root@kohadevbox:koha(rmain2105)$ qa -c 9 -v 2 testing 9 commit(s) (applied to 774e847 '94 Bug 29804: Fix Koha::Hold->is_pick') Processing files before patches |========================>| 7 / 7 (100.00%) Processing files after patches |========================>| 7 / 7 (100.00%) OK Koha/Checkouts/ReturnClaim.pm OK Koha/Schema/Result/Issue.pm OK Koha/Schema/Result/OldIssue.pm OK Koha/Schema/Result/ReturnClaim.pm OK installer/data/mysql/kohastructure.sql FAIL t/db_dependent/Koha/Checkouts/ReturnClaim.t FAIL valid Bareword "dt_from_string" not allowed while "strict subs" in use t/db_dependent/Koha/Checkouts/ReturnClaim.t had compilation errors. OK t/lib/TestBuilder.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130464|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130465|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130466|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130467|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130460|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130461|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130462|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130463|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #58 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130752&action=edit [21.05.x] Bug 29495: Unit Tests Test plan 1. Run updated tests prior to applying new patches.. pass 2. Run updated tests after applying new patches.. pass Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #59 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130753&action=edit [21.05.x] Bug 29495: Drop issue_id constraint from return_claims This patch removes the issue_id constraint from return_claims. Due to the nature of our dual table approach to checkouts/old_checkouts we can't safely hae this constraint and not lose data. Prior to this commit, when an item is checked in we move the checkout from checkouts to old_checkouts.. this therefore triggers the delete of the issue_id from the return_claims table as described by the foreign key constraint. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #60 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130754&action=edit [21.05.x] Bug 29495: DBIC Schema Rebuild Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #61 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130755&action=edit [21.05.x] Bug 29495: Add DBIC relationships back into Schema This patch adds the relationship accessors back into the affected Schema classes, now below the fold so they are retained during dbic rebuilds. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #62 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130756&action=edit [21.05.x] Bug 29495: Add code level constraint replacement This patch adds a check in Koha::Checkouts::ReturnClaim::store to replace the database level foreign key check. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #63 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130757&action=edit [21.05.x] Bug 29495: Update relationship methods This patch updates the relationship methods found in Koha::Checkouts::ReturnClaim so that they are prefetchable and embeddable on the API. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #64 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130758&action=edit [21.05.x] Bug 29495: Fix TestBuilder.t Value not allowed for auto_incr issue_id in Issue at /kohadevbox/koha/t/lib/TestBuilder.pm line 387. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #65 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Andrew Fuerste-Henry from comment #57)
Thanks for the 21.05 patches, Tomas! You did not make a 21.05 version of the "Add relationship tests" patch. The merge errors on that one seemed pretty simple to clear, so I'm not sure what's the source of the qa error I'm getting now (with all of your 21.05 patches and the regular version of Add Relationship Tests):
Hi, the item relationship is not particularly used by this bug. It is introduced as an enhancement follow-up that could've been on its own bug. So I don't include it. This new patchset has the relationship removed from the schema as well. Please only include the [21.05.x] patches, and retry. I got no failures locally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #66 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #67 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
1. Run updated tests prior to applying new patches.. pass 2. Run updated tests after applying new patches.. pass
I suppose that it shouldn't pass prior to applying new patches. (1.) At least that's what I have on 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03,21.05.11 |22.05.00,21.11.03,21.05.11, released in| |20.11.15 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #68 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 20.11.x branch for 20.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #69 from wainuiwitikapark@catalyst.net.nz --- Does this need to be backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Whilst 19.11 probably falls fowl of this bug, I don't think it warrants a backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #71 from wainuiwitikapark@catalyst.net.nz --- Not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31110 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110 [Bug 31110] Use `_should_be_fk` for ReturnClaim in TestBuilder -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org