[Bug 14965] New: Remove C4::Dates from 'lists' in folder reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Bug ID: 14965 Summary: Remove C4::Dates from 'lists' in folder reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org Remove C4::Dates from: - reports/bor_issues_top.pl - reports/borrowers_out.pl - reports/cat_issues_top.pl - reports/itemslost.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 43163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43163&action=edit Remove C4::Dates from 'lists' in folder reports Remove C4::Dates from: - reports/bor_issues_top.pl - reports/borrowers_out.pl - reports/cat_issues_top.pl - reports/itemslost.pl To test: - Go to Home > Reports - Verify that following reports behave as before: - 'Patrons with the most checkouts (reports/bor_issues_top.pl) - 'Most circulated items' (reports/cat_issues_top.pl) - 'Patrons who haven't checked out (reports/borrowers_out.pl) - 'Items lost' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch Status|NEW |Needs Signoff Blocks| |14870 Patch complexity|--- |Small patch Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 --- Comment #2 from Marc Véron <veron@veron.ch> --- Still applies. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net Status|Needs Signoff |Failed QA --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Marc Véron from comment #1)
- 'Patrons who haven't checked out (reports/borrowers_out.pl)
With the patch applied, the 'Global' column showing name and card number is missing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43163|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 43955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43955&action=edit Remove C4::Dates from 'lists' in folder reports Remove C4::Dates from: - reports/bor_issues_top.pl - reports/borrowers_out.pl - reports/cat_issues_top.pl - reports/itemslost.pl To test: - Go to Home > Reports - Verify that following reports behave as before: - 'Patrons with the most checkouts (reports/bor_issues_top.pl) - 'Most circulated items' (reports/cat_issues_top.pl) - 'Patrons who haven't checked out (reports/borrowers_out.pl) - 'Items lost' Amended to fix issue with reports/borrowers_out.pl / see comment #3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- In "Patrons with the most checkouts" report (reports/bor_issues_top.pl) doesn't work filter for checked-out and checked-in dates... Other reports works well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 --- Comment #6 from Marc Véron <veron@veron.ch> --- Hi Josef, I just tested with patch applied: Checkout date from: 01/01/2015 ... To: 31/10/2015 Check-in date from: 01/01/2015 ... To: 31/10/2015 Any library / Itemtype / Category Limit: 5 By: None It worked. What did you use for testing? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- I have test instance with only few checkouts in last 2 months. Some checkouts were made in september and some in october. But it doesn't matter which dates I use in checkout/checkin date filter, I still get exactly same data. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 --- Comment #8 from Marc Véron <veron@veron.ch> --- (In reply to Josef Moravec from comment #7)
I have test instance with only few checkouts in last 2 months. Some checkouts were made in september and some in october. But it doesn't matter which dates I use in checkout/checkin date filter, I still get exactly same data.
Josef, thanks a lot for testing, I found the issue. Amended patch follows. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43955|0 |1 is obsolete| | --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 44154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44154&action=edit Remove C4::Dates from 'lists' in folder reports Remove C4::Dates from: - reports/bor_issues_top.pl - reports/borrowers_out.pl - reports/cat_issues_top.pl - reports/itemslost.pl To test: - Go to Home > Reports - Verify that following reports behave as before: - 'Patrons with the most checkouts (reports/bor_issues_top.pl) - 'Most circulated items' (reports/cat_issues_top.pl) - 'Patrons who haven't checked out (reports/borrowers_out.pl) - 'Items lost' Amended to fix issue with reports/borrowers_out.pl / see comment #3 Amended to fix issue with reports/bor_issues_top.pl / see comment #7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44154|0 |1 is obsolete| | --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44417&action=edit Remove C4::Dates from 'lists' in folder reports Remove C4::Dates from: - reports/bor_issues_top.pl - reports/borrowers_out.pl - reports/cat_issues_top.pl - reports/itemslost.pl To test: - Go to Home > Reports - Verify that following reports behave as before: - 'Patrons with the most checkouts (reports/bor_issues_top.pl) - 'Most circulated items' (reports/cat_issues_top.pl) - 'Patrons who haven't checked out (reports/borrowers_out.pl) - 'Items lost' Amended to fix issue with reports/borrowers_out.pl / see comment #3 Amended to fix issue with reports/bor_issues_top.pl / see comment #7 http://bugs.koha-community.org/show_bug.cgi?id=14965 Signed-off-by: Frederic Demians <f.demians@tamil.fr> Code OK. The 4 reports works for me as before (same results). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44417|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44488&action=edit Remove C4::Dates from 'lists' in folder reports Remove C4::Dates from: - reports/bor_issues_top.pl - reports/borrowers_out.pl - reports/cat_issues_top.pl - reports/itemslost.pl To test: - Go to Home > Reports - Verify that following reports behave as before: - 'Patrons with the most checkouts (reports/bor_issues_top.pl) - 'Most circulated items' (reports/cat_issues_top.pl) - 'Patrons who haven't checked out (reports/borrowers_out.pl) - 'Items lost' Amended to fix issue with reports/borrowers_out.pl / see comment #3 Amended to fix issue with reports/bor_issues_top.pl / see comment #7 http://bugs.koha-community.org/show_bug.cgi?id=14965 Signed-off-by: Frederic Demians <f.demians@tamil.fr> Code OK. The 4 reports works for me as before (same results). Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 44488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44488 Remove C4::Dates from 'lists' in folder reports Review of attachment 44488: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14965&attachment=44488) ----------------------------------------------------------------- ::: reports/borrowers_out.pl @@ +232,4 @@
} $strcalc .= " AND NOT EXISTS (SELECT * FROM issues WHERE issues.borrowernumber=borrowers.borrowernumber "; if ( @$filters[1] ) { + $strcalc .= " AND issues.timestamp > ?";
I have opened bug 15138 for this typo. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- *** Bug 15138 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org