[Bug 20747] New: Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Bug ID: 20747 Summary: Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: lisetteslatah@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com It would be great if the LocalHoldsPriority could be used within a district in a consortium.
Christopher expressed concern, adding on “grouping” – some libraries may not >>want to be effected. Typically this is all or nothing or on or off. Example, >>the circulation of Mobile Hotspots; hotspots are popular outside of CDA but CDA >>patrons get priority, Rathdrum is pushed down. Consider an “Item type” or “Item >>level” opt out which would be similar to how suppression works. If the >>modification increased features and flexibility, there may be more interest from >>the larger group in supporting the enhancement. Group structure for settings, a >>hierarchy based system, and refinement is needed.
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com Depends on| |16735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 [Bug 11126] Make the holds system optionally give precedence to local holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12004 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22284 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|NEW |In Discussion --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Lisette, could you please explain a bit further? Also, can you take a look at bug 22284 and see how it fits? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #2 from Lisette Scheer <lisetteslatah@gmail.com> --- LocalHoldsPriority currently looks only at home library. We would like if it could look at groups and look first at the whole group then outside the group for priority. Example: MOS and TRO are in group together and LAP is not in the same group. MOS has the only copy of a new book and the holds are: 1. MOS patron 2. LAP patron1 3. LAP patron2 4. TRO patron We would like it to fill: 1. MOS Patron 2. TRO Patron 3. LAP patron1 4. LAP patron2 Assuming no additional holds were place by MOS or TRO patrons before it got to LAP. Another Example might be if LAP also had a copy but the order of holds was: 1. MOS patron 2. LAP patron1 3. TRO patron 4. LAP patron2 The 2 copies could bounce around between the 3 branches taking extra courier time (LAP to TRO has to take 3 different courier routes, LAP to MOS 2) but with what we would like, the MOS copy would fill for MOS and then TRO (1 courier route) then go out to the consortium and the LAP one could stay in LAP (or its group) before going out to the consortium, potentially cutting down wait time for branches where their group has purchased copies. I may have it wrong, but it looks like bug 22284 would prevent the holds from going out of the groups? That isn't what we would want, as we still want our items to be able to go out of the district once holds for our district have been filled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #3 from Joy Nelson <joy@bywatersolutions.com> --- Lisette- The way that Bug 22284 would work includes functionality for 'non local/group' holds to be filled after all the local holds have been satisfied. joy
I may have it wrong, but it looks like bug 22284 would prevent the holds from going out of the groups? That isn't what we would want, as we still want our items to be able to go out of the district once holds for our district have been filled.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #4 from Lisette Scheer <lisetteslatah@gmail.com> --- Joy, In that case, it looks like bug 22284 would work for our purposes here at Valnet. Thanks for the clarification! Lisette (In reply to Joy Nelson from comment #3)
Lisette- The way that Bug 22284 would work includes functionality for 'non local/group' holds to be filled after all the local holds have been satisfied.
joy
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** This bug has been marked as a duplicate of bug 22284 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED --- Comment #6 from Lisette Scheer <lisetteslatah@gmail.com> --- But 22284 did not fix this issue. It only limited completely to the group, rather than prioritizing the group and then going out of the group, similarly to Bug 12004 but to allow just group prioritization and not branch prioritization. The reason that using just the transportation cost matrix doesn't just do this has to do with when an item is already checked out and returned, it'll send the item far away and then when the copy for the far away branch comes in, it gets routed up to us. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org --- Comment #7 from Michelle Spinney <mspinney@clamsnet.org> --- This is really important for consortia, or any network with branches. We need this for our network as we have 2 islands that use their own intra-island delivery as well as our state delivery service. Not having this ability has caused a lot of issues during our busy summer tourist season. The transport cost matrix has been no help. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Eileen Chandler <echandler@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echandler@clamsnet.org --- Comment #8 from Eileen Chandler <echandler@clamsnet.org> --- CLAMS wants 1. individual library 2. Hierarchical group 3. larger group. We don't want to cut out the individual library as the first choice. New bug perhaps? Cutting out the individual library and preferring a group as the first option will not work for us. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 AspenCat Team <aspencatteam@clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam@clicweb.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking cosponsors URL| |https://bywatersolutions.co | |m/crowdsourcing/localholdsp | |riority-query -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #9 from George Williams (NEKLS) <george@nekls.org> --- I want the development to have enough flexibility to do: 1. individual library 2. hold group 3. entire system or: 1. hold group 2. entire system I don't see any reason it couldn't be designed to do both. (In reply to Eileen Chandler from comment #8)
CLAMS wants 1. individual library 2. Hierarchical group 3. larger group. We don't want to cut out the individual library as the first choice. New bug perhaps? Cutting out the individual library and preferring a group as the first option will not work for us.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Seeking cosponsors |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |roadmap_24_11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Chanel Wheeler <chanel.wheeler@yavapaiaz.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chanel.wheeler@yavapaiaz.go | |v --- Comment #10 from Chanel Wheeler <chanel.wheeler@yavapaiaz.gov> --- We agree with 1. individual library 2. hold group 3. entire system We had this in our last ILS and depended on it. We're at a loss as to what to do now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 s.antonucci@rcls.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.antonucci@rcls.org Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lisette@bywatersolutions.co |ity.org |m CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|roadmap_24_11 |roadmap_25_05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 karie.straube@yavapaiaz.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karie.straube@yavapaiaz.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Klas Blomberg <klas.blomberg@skovde.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |klas.blomberg@skovde.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Elizabeth Hoffman <ehoffman@plumcreeklibrary.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ehoffman@plumcreeklibrary.n | |et -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #11 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 181220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181220&action=edit Bug 20747: Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library This patch adds new options to the LocalHoldsPriority system preference to allow for the following options: 'None' the equivalent to 'Don't' pre-patch 'GiveLibrary' the equivalent to 'Do' pre-patch 'GiveLibraryAndGroup' Allows for checking the library first, then hold groups 'GiveGroup' Allows to prioritize within a group without prioritizing any library first. The included patches will update the preference in existing installations to maintain current behavior. To Test: BEFORE APPLYING THE PATCH /Setup Groups and confirm current behavior/ 1. Set the " LocalHoldsPriority " system preference to "Give", "LocalHoldsPriorityPatronControl" to "home library" and "LocalHoldsPriorityItemControl" to "home library" 2. Create 2 Library hold Groups - I called mine group 1 & group 2 3. Add 2 libraries each to each group. - Group 1 - Centerville - Fairfield - Group 2 - Fairview - Franklin 4. Find a patron for each branch in the groups - Centerville - 23529000035676 (Henry) - Fairfield - Changed 23529000050113 - Fairview - Changed 23529001000463 (Edna) - Franklin - 23529000121682 5. Find a record with at least 2 items 6. If needed change the home and holding libraries so you have at least one item for each hold group - Centerville - 39999000000252 - Fairview - Changed 39999000000238 7. Place 2 record level holds for the record. - One for 23529000035676 for pickup at Centerville (Priority 1) - One for 23529001000463 for pickup at fairview (Priority 2) 8. Check in 39999000000238. The hold popup should be for the second hold, not the first. /apply patch and confirm behavior still works/ 9. Apply patch 10. Rebuild the database then restart_all (in sandboxes it's an action, in ktd " dbic && updatedatabase && restart_all ") 11. Confirm that " LocalHoldsPriority " is set to "Give Library" 12. Repeat steps 7-8, behavior should be the same. / check library then library group setting/ 13. Change " LocalHoldsPriority " to "Give library then library group" 14. Set the following record level holds for the record: - Pickup at Fairfield - 23529000050113 - Pickup at Franklin - 23529000121682 - Pickup at Centerville - 23529000035676 (Henry) - Pickup at Fairview - 23529001000463 (Edna) 15. Check in 39999000000252 - should try and fill to Centerville - 23529000035676 (Henry) 16. Check in 39999000000238 - should try and fill to Fairview - 23529001000463 (Edna) 17. Cancel the hold for 23529001000463 18. Check in 39999000000238 should try and fill to 23529000121682 / check library group setting / 19. Reset the holds to match step 14. 20. Check in 39999000000252 - should try and fill to Fairfield 21. Check in 39999000000238 - should try and fill to Franklin /check no priority / 22. Reset the holds to match step 14. 23. Check in 39999000000238 - Should fill the Fairfield hold 24. Check in 39999000000252 - Should fill the Franklin hold /Also check/ Item level holds behave as expected Different combinations of LocalHoldsPriorityItemControl and LocalHoldsPriorityPatronControl Sponsored by: Cape Libraries Automated Materials Sharing Sponsored by: Northeast Kansas Library System (NEKLS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #12 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 181221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181221&action=edit Bug 20747: DB Rev This patch adds a DB rev to update the system preference in existing installations. # Please enter the commit message for your changes. Lines starting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds the ability release notes| |to set the | |"LocalHoldsPriority" system | |preference to more options: | |Give Library (current | |behavior when on), Give | |Library and Group, Give | |Library Group, or Don't | |give (current behavior when | |off). | |The system preference | |will be updated in existing | |installations to match with | |the new options based on | |current settings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb@sekls.org Status|Needs Signoff |Failed QA --- Comment #13 from Jason Robb <jrobb@sekls.org> --- This mostly worked. When I did step 12 I had to toggle the syspref to get it to work. I also got this error when I ran the qa tools. FAIL installer/data/mysql/db_revs/bug_20747-updatelocalholdspriority_syspref.pl FAIL file permissions File must have the exec flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #14 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 181311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181311&action=edit Bug 20747: (QA follow-up) fix permissions on database update UPDATED TEST PLAN This patch adds new options to the LocalHoldsPriority system preference to allow for the following options: 'None' the equivalent to 'Don't' pre-patch 'GiveLibrary' the equivalent to 'Do' pre-patch 'GiveLibraryAndGroup' Allows for checking the library first, then hold groups 'GiveGroup' Allows to prioritize within a group without prioritizing any library first. The included patches will update the preference in existing installations to maintain current behavior. To Test: BEFORE APPLYING THE PATCH /Setup Groups and confirm current behavior/ 1. Set the " LocalHoldsPriority " system preference to "Give", "LocalHoldsPriorityPatronControl" to "home library" and "LocalHoldsPriorityItemControl" to "home library" 2. Create 2 Library Groups - Set them to be hold groups - I called mine group 1 & group 2 3. Add 2 libraries each to each group. - Group 1 - Centerville - Fairfield - Group 2 - Fairview - Franklin 4. Find a patron for each branch in the groups - Centerville - 23529000035676 (Henry) - Fairfield - Changed 23529000050113 - Fairview - Changed 23529001000463 (Edna) - Franklin - 23529000121682 5. Find a record with at least 2 items 6. If needed change the home and holding libraries so you have at least one item for each hold group - Centerville - 39999000000252 - Fairview - Changed 39999000000238 7. Place 2 record level holds for the record. - One for 23529000035676 for pickup at Centerville (Priority 1) - One for 23529001000463 for pickup at fairview (Priority 2) 8. Check in 39999000000238. The hold popup should be for the second hold, not the first. /apply patch and confirm behavior still works/ 9. Apply patch 10. Rebuild the database then restart_all (in sandboxes it's an action, in ktd " dbic && updatedatabase && restart_all ") 11. Confirm that " LocalHoldsPriority " is set to "Give Library" 12. Repeat steps 7-8, behavior should be the same. / check library then library group setting/ 13. Change " LocalHoldsPriority " to "Give library then library group" 14. Set the following record level holds for the record in the following order: - Pickup at Fairfield - 23529000050113 - Pickup at Franklin - 23529000121682 - Pickup at Centerville - 23529000035676 (Henry) - Pickup at Fairview - 23529001000463 (Edna) 15. Check in 39999000000252 - should try and fill to Centerville - 23529000035676 (Henry) 16. Check in 39999000000238 - should try and fill to Fairview - 23529001000463 (Edna) 17. Suspend the hold for 23529001000463 18. Check in 39999000000238 should try and fill to 23529000121682 / check library group setting / 19. Reset the holds to match step 14. 20. Change " LocalHoldsPriority " to "Give group" 21. Check in 39999000000252 - should try and fill to Fairfield 22. Check in 39999000000238 - should try and fill to Franklin /check no priority / 23. Change " LocalHoldsPriority " to "Don't give" 24. Reset the holds to match step 14. 25. Check in 39999000000238 - Should fill the Fairfield hold 26. Check in 39999000000252 - Should fill the Fairfield hold /Also check/ Item level holds behave as expected Different combinations of LocalHoldsPriorityItemControl and LocalHoldsPriorityPatronControl Sponsored by: Cape Libraries Automated Materials Sharing Sponsored by: Northeast Kansas Library System (NEKLS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Lisette Scheer <lisette@bywatersolutions.com> --- setting back to failed qa. I'm having some trouble with the dbrev. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181311|0 |1 is obsolete| | --- Comment #16 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 181313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181313&action=edit Bug 20747: (follow-up) fix permissions and location on database update file UPDATED TEST PLAN This patch adds new options to the LocalHoldsPriority system preference to allow for the following options: 'None' the equivalent to 'Don't' pre-patch 'GiveLibrary' the equivalent to 'Do' pre-patch 'GiveLibraryAndGroup' Allows for checking the library first, then hold groups 'GiveGroup' Allows to prioritize within a group without prioritizing any library first. The included patches will update the preference in existing installations to maintain current behavior. To Test: BEFORE APPLYING THE PATCH /Setup Groups and confirm current behavior/ 1. Set the " LocalHoldsPriority " system preference to "Give", "LocalHoldsPriorityPatronControl" to "home library" and "LocalHoldsPriorityItemControl" to "home library" 2. Create 2 Library Groups - Set them to be hold groups - I called mine group 1 & group 2 3. Add 2 libraries each to each group. - Group 1 - Centerville - Fairfield - Group 2 - Fairview - Franklin 4. Find a patron for each branch in the groups - Centerville - 23529000035676 (Henry) - Fairfield - Changed 23529000050113 - Fairview - Changed 23529001000463 (Edna) - Franklin - 23529000121682 5. Find a record with at least 2 items 6. If needed change the home and holding libraries so you have at least one item for each hold group - Centerville - 39999000000252 - Fairview - Changed 39999000000238 7. Place 2 record level holds for the record. - One for 23529000035676 for pickup at Centerville (Priority 1) - One for 23529001000463 for pickup at fairview (Priority 2) 8. Check in 39999000000238. The hold popup should be for the second hold, not the first. /apply patch and confirm behavior still works/ 9. Apply patch 10. Rebuild the database then restart_all (in sandboxes it's an action, in ktd " dbic && updatedatabase && restart_all ") 11. Confirm that " LocalHoldsPriority " is set to "Give Library" 12. Repeat steps 7-8, behavior should be the same. / check library then library group setting/ 13. Change " LocalHoldsPriority " to "Give library then library group" 14. Set the following record level holds for the record in the following order: - Pickup at Fairfield - 23529000050113 - Pickup at Franklin - 23529000121682 - Pickup at Centerville - 23529000035676 (Henry) - Pickup at Fairview - 23529001000463 (Edna) 15. Check in 39999000000252 - should try and fill to Centerville - 23529000035676 (Henry) 16. Check in 39999000000238 - should try and fill to Fairview - 23529001000463 (Edna) 17. Suspend the hold for 23529001000463 18. Check in 39999000000238 should try and fill to 23529000121682 / check library group setting / 19. Reset the holds to match step 14. 20. Change " LocalHoldsPriority " to "Give group" 21. Check in 39999000000252 - should try and fill to Fairfield 22. Check in 39999000000238 - should try and fill to Franklin /check no priority / 23. Change " LocalHoldsPriority " to "Don't give" 24. Reset the holds to match step 14. 25. Check in 39999000000238 - Should fill the Fairfield hold 26. Check in 39999000000252 - Should fill the Fairfield hold /Also check/ Item level holds behave as expected Different combinations of LocalHoldsPriorityItemControl and LocalHoldsPriorityPatronControl Sponsored by: Cape Libraries Automated Materials Sharing Sponsored by: Northeast Kansas Library System (NEKLS) Bug 20747: (follow-up) Move atomic update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181313|0 |1 is obsolete| | --- Comment #17 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 181314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181314&action=edit Bug 20747: (follow-up) fix atomic update This update moves the atomic update to the correct place, updates permissions, and fixes an error in the original patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181220|0 |1 is obsolete| | --- Comment #18 from Jason Robb <jrobb@sekls.org> --- Created attachment 181319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181319&action=edit Bug 20747: Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library This patch adds new options to the LocalHoldsPriority system preference to allow for the following options: 'None' the equivalent to 'Don't' pre-patch 'GiveLibrary' the equivalent to 'Do' pre-patch 'GiveLibraryAndGroup' Allows for checking the library first, then hold groups 'GiveGroup' Allows to prioritize within a group without prioritizing any library first. The included patches will update the preference in existing installations to maintain current behavior. To Test: BEFORE APPLYING THE PATCH /Setup Groups and confirm current behavior/ 1. Set the " LocalHoldsPriority " system preference to "Give", "LocalHoldsPriorityPatronControl" to "home library" and "LocalHoldsPriorityItemControl" to "home library" 2. Create 2 Library hold Groups - I called mine group 1 & group 2 3. Add 2 libraries each to each group. - Group 1 - Centerville - Fairfield - Group 2 - Fairview - Franklin 4. Find a patron for each branch in the groups - Centerville - 23529000035676 (Henry) - Fairfield - Changed 23529000050113 - Fairview - Changed 23529001000463 (Edna) - Franklin - 23529000121682 5. Find a record with at least 2 items 6. If needed change the home and holding libraries so you have at least one item for each hold group - Centerville - 39999000000252 - Fairview - Changed 39999000000238 7. Place 2 record level holds for the record. - One for 23529000035676 for pickup at Centerville (Priority 1) - One for 23529001000463 for pickup at fairview (Priority 2) 8. Check in 39999000000238. The hold popup should be for the second hold, not the first. /apply patch and confirm behavior still works/ 9. Apply patch 10. Rebuild the database then restart_all (in sandboxes it's an action, in ktd " dbic && updatedatabase && restart_all ") 11. Confirm that " LocalHoldsPriority " is set to "Give Library" 12. Repeat steps 7-8, behavior should be the same. / check library then library group setting/ 13. Change " LocalHoldsPriority " to "Give library then library group" 14. Set the following record level holds for the record: - Pickup at Fairfield - 23529000050113 - Pickup at Franklin - 23529000121682 - Pickup at Centerville - 23529000035676 (Henry) - Pickup at Fairview - 23529001000463 (Edna) 15. Check in 39999000000252 - should try and fill to Centerville - 23529000035676 (Henry) 16. Check in 39999000000238 - should try and fill to Fairview - 23529001000463 (Edna) 17. Cancel the hold for 23529001000463 18. Check in 39999000000238 should try and fill to 23529000121682 / check library group setting / 19. Reset the holds to match step 14. 20. Check in 39999000000252 - should try and fill to Fairfield 21. Check in 39999000000238 - should try and fill to Franklin /check no priority / 22. Reset the holds to match step 14. 23. Check in 39999000000238 - Should fill the Fairfield hold 24. Check in 39999000000252 - Should fill the Franklin hold /Also check/ Item level holds behave as expected Different combinations of LocalHoldsPriorityItemControl and LocalHoldsPriorityPatronControl Sponsored by: Cape Libraries Automated Materials Sharing Sponsored by: Northeast Kansas Library System (NEKLS) Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181221|0 |1 is obsolete| | --- Comment #19 from Jason Robb <jrobb@sekls.org> --- Created attachment 181320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181320&action=edit Bug 20747: DB Rev This patch adds a DB rev to update the system preference in existing installations. # Please enter the commit message for your changes. Lines starting Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181314|0 |1 is obsolete| | --- Comment #20 from Jason Robb <jrobb@sekls.org> --- Created attachment 181321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181321&action=edit Bug 20747: (follow-up) fix atomic update This update moves the atomic update to the correct place, updates permissions, and fixes an error in the original patch. Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #21 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Comment on attachment 181319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181319 Bug 20747: Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library Review of attachment 181319: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20747&attachment=181319) ----------------------------------------------------------------- QA feedback: I've got failing tests at t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #22 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Tried the review feature but it hasn't saved my comments, trying again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #23 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Comment on attachment 181319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181319 Bug 20747: Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library Review of attachment 181319: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20747&attachment=181319) ----------------------------------------------------------------- QA feedback: I've got failing tests at t/db_dependent/HoldsQueue.t, plus the below comment which applies to all the calls to AddReserve in the test ::: t/db_dependent/Holds/LocalHoldsPriority.t @@ +111,5 @@
+# Create five record level holds +AddReserve( + { + branchcode => $library1,
We're now passing the entire library object instead of just the branchcode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #24 from Lisette Scheer <lisette@bywatersolutions.com> --- Quick update: I've got this working locally with the holds queue and the testing is working, but it does not work properly with the RTQ yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #25 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 182008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182008&action=edit Bug 20747: (follow-up) Fix hold queue to work with LocalHoldPriority Group options This fixes the holds queue and associated tests. I also updated the sql file to fix an issue and the LocalHoldsPriority tests to fix a typo. I'm working on final unit tests for the holds queue for all the options for QA but I wanted to get the queue changes ready for sign-off. UPDATED TEST PLAN This patch adds new options to the LocalHoldsPriority system preference to allow for the following options: 'None' the equivalent to 'Don't' pre-patch 'GiveLibrary' the equivalent to 'Do' pre-patch 'GiveLibraryAndGroup' Allows for checking the library first, then hold groups 'GiveGroup' Allows to prioritize within a group without prioritizing any library first. The included patches will update the preference in existing installations to maintain current behavior. To Test: BEFORE APPLYING THE PATCH /Tip/ I kept the following tabs open: -The holds screen (for suspending, checking order, etc) -Check in screen (can ignore holds to keep them all in place) -Holds to Pull with "All" for Libraries -System Preferences /Setup Groups and confirm current behavior/ 1. Set the following system preferences: -" LocalHoldsPriority " system preference to "Give" -"LocalHoldsPriorityPatronControl" to "home library" -"LocalHoldsPriorityItemControl" to "home library" -"RealTimeHoldsQueue" to "Enable" 2. Create 2 Library Groups - Set them to be hold groups - I called mine group 1 & group 2 3. Add 2 libraries each to each group. - Group 1 - Centerville - Fairfield - Group 2 - Fairview - Franklin 4. Find a patron for each branch in the groups - Centerville - Changed 23529000035676 (Henry) - Fairfield - Changed 23529000050113 (Jordan) - Fairview - Changed 23529001000463 (Edna) - Franklin - 23529000121682 (Nicole) 5. Find a record with at least 2 items 6. If needed change the home and holding libraries so you have at least one item for each hold group - Centerville - 39999000000252 - Fairview - Changed 39999000000238 7. Place 2 record level holds for the record. - One for 23529000035676 (Henry) for pickup at Centerville (Priority 1) - One for 23529001000463 (Edna) for pickup at Fairview (Priority 2) 8. Check in 39999000000238. The hold popup should be for the second hold (Henry), not the first (Edna.) Ignore the hold 9. Edit the record then save to trigger real time queue update 10. On the Holds Queue (submit after each set of changes): - Centerville should be for Henry - Fairview should be for Edna /apply patch and confirm behavior still works/ 10. Apply patch 11. Rebuild the database then restart_all (in sandboxes it's an action, in ktd " dbic && updatedatabase && restart_all ") 12. Confirm that " LocalHoldsPriority " is set to "Give Library" 13. Repeat steps 8-10, behavior should be the same. / check library then library group setting/ 14. Change " LocalHoldsPriority " to "Give library then library group" 15. Set the following record level holds for the record in the following order: *You can add Jordan and Nicole's, then rearrange the order. - Pickup at Fairfield - 23529000050113 (Jordan) - Pickup at Franklin - 23529000121682 (Nicole) - Pickup at Centerville - 23529000035676 (Henry) - Pickup at Fairview - 23529001000463 (Edna) 17. Check in 39999000000252 - should try and fill to Centerville - 23529000035676 (Henry) 17. Check in 39999000000238 - should try and fill to Fairview - 23529001000463 (Edna) 18. On the Hold Queue: - Centerville should be for Henry - Fairview should be for Edna 19. Suspend the hold for 23529001000463 (Edna) 20. Check in 39999000000238 should try and fill to 23529000121682 (Nicole) (ignore the hold) 21. On the Holds Queue: - Centerville should be for Henry - Fairview should be for Nicole / check library group setting / 22. Reset the holds to match step 15. 23. Change " LocalHoldsPriority " to "Give group" 24. Check in 39999000000252 - should try and fill to Fairfield (Jordan) (ignore the hold) 25. Check in 39999000000238 - should try and fill to Franklin (Nicole) (ignore the hold) 26. On the Holds Queue: - Centerville should be for Jordan - Fairview should be for Nicole /check no priority / 27. Change " LocalHoldsPriority " to "Don't give" 28. Reset the holds to match step 15. 29. Check in 39999000000238 - Should fill to Fairfield (Jordan) (ignore the hold) 30. Check in 39999000000252 - Should fill to Fairfield hold (Jordan) (ignore the hold) 31. On the Holds Queue: - Centerville should be for Jordan - Fairview should be for Nicole /Also check/ Item level holds behave as expected Different combinations of LocalHoldsPriorityItemControl and LocalHoldsPriorityPatronControl Sponsored by: Cape Libraries Automated Materials Sharing Sponsored by: Northeast Kansas Library System (NEKLS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #26 from Lisette Scheer <lisette@bywatersolutions.com> --- Step 8 in the plan is backwards, the hold should be for hold 2, Edna not for hold 1, Henry. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds the ability |This patch adds the ability release notes|to set the |to set the |"LocalHoldsPriority" system |"LocalHoldsPriority" system |preference to more options: |preference to more options: |Give Library (current | |behavior when on), Give |-'Give Library' (current |Library and Group, Give |behavior when on) |Library Group, or Don't |-'Give |give (current behavior when |Library and Group' |off). |-'Give |The system preference |Library Group' |will be updated in existing |-'Don't |installations to match with |give' (current behavior |the new options based on |when off). |current settings. |The system | |preference will be updated | |in existing installations | |to match with the new | |options based on current | |settings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds the ability |This patch adds the ability release notes|to set the |to set the |"LocalHoldsPriority" system |"LocalHoldsPriority" system |preference to more options: |preference to more options: | | |-'Give Library' (current |-`Give Library` (current |behavior when on) |behavior when on) |-'Give |-`Give |Library and Group' |Library and Group` |-'Give |-`Give |Library Group' |Library Group` |-'Don't |-`Don't |give' (current behavior |give` (current behavior |when off). |when off). |The system |The system |preference will be updated |preference will be updated |in existing installations |in existing installations |to match with the new |to match with the new |options based on current |options based on current |settings. |settings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #27 from Lisette Scheer <lisette@bywatersolutions.com> --- Updated test plan to better account for holds queue vs between hold queue runs: Bug 20747: (follow-up) Fix hold queue to work with LocalHoldPriority Group options This fixes the holds queue and associated tests. I also updated the sql file to fix an issue and the LocalHoldsPriority tests to fix a typo. I'm working on final unit tests for the holds queue for all the options for QA but I wanted to get the queue changes ready for sign-off. UPDATED TEST PLAN This patch adds new options to the LocalHoldsPriority system preference to allow for the following options: 'None' the equivalent to 'Don't' pre-patch 'GiveLibrary' the equivalent to 'Do' pre-patch 'GiveLibraryAndGroup' Allows for checking the library first, then hold groups 'GiveGroup' Allows to prioritize within a group without prioritizing any library first. The included patches will update the preference in existing installations to maintain current behavior. To Test: BEFORE APPLYING THE PATCH /Tip/ I kept the following tabs open: -The holds screen (for suspending, checking order, etc) -Check in screen (can ignore holds to keep them all in place) -Holds to Pull with "All" for Libraries -System Preferences /Setup Groups and confirm current behavior/ 1. Set the following system preferences: -" LocalHoldsPriority " system preference to "Give" -"LocalHoldsPriorityPatronControl" to "home library" -"LocalHoldsPriorityItemControl" to "home library" 2. Create 2 Library Groups - Set them to be hold groups - I called mine group 1 & group 2 3. Add 2 libraries each to each group. - Group 1 - Centerville - Fairfield - Group 2 - Fairview - Franklin 4. Find a patron for each branch in the groups - Centerville - Changed 23529000035676 (Henry) - Fairfield - Changed 23529000050113 (Jordan) - Fairview - Changed 23529001000463 (Edna) - Franklin - 23529000121682 (Nicole) 5. Find a record with at least 2 items 6. If needed change the home and holding libraries so you have at least one item for each hold group - Centerville - 39999000000252 - Fairview - Changed 39999000000238 7. Place 2 record level holds for the record. - One for 23529000035676 (Henry) for pickup at Centerville (Priority 1) - One for 23529001000463 (Edna) for pickup at Fairview (Priority 2) 8. Check in 39999000000238. The hold popup should be for the second hold (Edna), not the first (Henry.) Ignore the hold 9. Set the "RealTimeHoldsQueue" system preference to "Enable" 10. Edit the record then save to trigger real time queue update 11. On the Holds Queue (submit after each set of changes): - Centerville should be for Henry - Fairview should be for Edna 12. Suspend all the holds 13. Edit the record to trigger real time queue update. 14. Set the "RealTimeHoldsQueue" system preference to "Disable" 15. Unsuspend holds /apply patch and confirm behavior still works/ 16. Apply patch 17. Rebuild the database then restart_all (in sandboxes it's an action, in ktd " dbic && updatedatabase && restart_all ") 18. Confirm that " LocalHoldsPriority " is set to "Give Library" 19. Repeat steps 8-15, behavior should be the same. / check library then library group setting/ 20. Change " LocalHoldsPriority " to "Give library then library group" 21. Set the following record level holds for the record in the following order: *You can add Jordan and Nicole's, then rearrange the order. - Pickup at Fairfield - 23529000050113 (Jordan) - Pickup at Franklin - 23529000121682 (Nicole) - Pickup at Centerville - 23529000035676 (Henry) - Pickup at Fairview - 23529001000463 (Edna) 22. Check in 39999000000252 - should try and fill to Centerville - 23529000035676 (Henry) 23. Check in 39999000000238 - should try and fill to Fairview - 23529001000463 (Edna) 24. Repeat steps 9-10 25. On the Hold Queue: - Centerville should be for Henry - Fairview should be for Edna 26. Repeat steps 12-15 27. Suspend the hold for 23529001000463 (Edna) 28. Check in 39999000000238 should try and fill to 23529000121682 (Nicole) (ignore the hold) 29. Repeat steps 9-10 30. On the Holds Queue: - Centerville should be for Henry - Fairview should be for Nicole 31. Repeat steps 12-15 / check library group setting / 32. Reset the holds to match step 15. 33. Change " LocalHoldsPriority " to "Give group" 34. Check in 39999000000252 - should try and fill to Fairfield (Jordan) (ignore the hold) 35. Check in 39999000000238 - should try and fill to Franklin (Nicole) (ignore the hold) 36. Repeat steps 9-10 37. On the Holds Queue: - Centerville should be for Jordan - Fairview should be for Nicole 38. repeat steps 12-15 /check no priority / 39. Change " LocalHoldsPriority " to "Don't give" 40. Reset the holds to match step 21. 41. Check in 39999000000238 - Should fill to Fairfield (Jordan) (ignore the hold) 42. Check in 39999000000252 - Should fill to Fairfield hold (Jordan) (ignore the hold) 42. Repeat steps 9-10 43. On the Holds Queue: - Centerville should be for Jordan - Fairview should be for Nicole 44. Repeat steps 12-15 /Also check/ Item level holds behave as expected Different combinations of LocalHoldsPriorityItemControl and LocalHoldsPriorityPatronControl Sponsored by: Cape Libraries Automated Materials Sharing Sponsored by: Northeast Kansas Library System (NEKLS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 s.antonucci@rcls.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC|s.antonucci@rcls.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 s.antonucci@rcls.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.antonucci@rcls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #28 from Lisette Scheer <lisette@bywatersolutions.com> --- less convoluted test plan for holds without the queue being built (fresh check in/new hold no rtq) and checking the holds queue: To Test: BEFORE APPLYING THE PATCH /Tip/ I kept the following tabs open: -The holds screen (for suspending, checking order, etc) -Check in screen (can ignore holds to keep them all in place) -Holds to Pull with "All" for Libraries -System Preferences /Setup Groups and confirm current behavior/ 1. Set the following system preferences: -" LocalHoldsPriority " system preference to "Give" -"LocalHoldsPriorityPatronControl" to "home library" -"LocalHoldsPriorityItemControl" to "home library" 2. Create 2 Library Groups - Set them to be hold groups - I called mine group 1 & group 2 3. Add 2 libraries each to each group. - Group 1 - Centerville - Fairfield - Group 2 - Fairview - Franklin 4. Find a patron for each branch in the groups - Centerville - Changed 23529000035676 (Henry) - Fairfield - Changed 23529000050113 (Jordan) - Fairview - Changed 23529001000463 (Edna) - Franklin - 23529000121682 (Nicole) 5. Find a record with at least 2 items 6. If needed change the home and holding libraries so you have at least one item for each hold group - Centerville - 39999000000252 - Fairview - Changed 39999000000238 7. Place 2 record level holds for the record. - One for 23529000035676 (Henry) for pickup at Centerville (Priority 1) - One for 23529001000463 (Edna) for pickup at Fairview (Priority 2) 8. Check in 39999000000238. The hold popup should be for the second hold (Edna), not the first (Henry.) Ignore the hold /apply patch and confirm behavior still works/ 9. Apply patch 10. Rebuild the database then restart_all (in sandboxes it's an action, in ktd " dbic && updatedatabase && restart_all ") 11. Confirm that " LocalHoldsPriority " is set to "Give Library" 12. Repeat step 8, behavior should be the same. / check library then library group setting/ 13. Change " LocalHoldsPriority " to "Give library then library group" 14. Set the following record level holds for the record in the following order: *You can add Jordan and Nicole's, then rearrange the order. - Pickup at Fairfield - 23529000050113 (Jordan) - Pickup at Franklin - 23529000121682 (Nicole) - Pickup at Centerville - 23529000035676 (Henry) - Pickup at Fairview - 23529001000463 (Edna) 15. Check in 39999000000252 - should try and fill to Centerville - 23529000035676 (Henry) (ignore the hold) 16. Check in 39999000000238 - should try and fill to Fairview - 23529001000463 (Edna) (ignore the hold) 17. Suspend the hold for 23529001000463 (Edna) 18. Check in 39999000000238 should try and fill to 23529000121682 (Nicole) (ignore the hold) / check library group setting / 19. Reset the holds to match step 14. 20. Change " LocalHoldsPriority " to "Give group" 21. Check in 39999000000252 - should try and fill to Fairfield (Jordan) (ignore the hold) 22. Check in 39999000000238 - should try and fill to Franklin (Nicole) (ignore the hold) /check no priority / 23. Change " LocalHoldsPriority " to "Don't give" 24. Reset the holds to match step 14. 25. Check in 39999000000238 - Should fill to Fairfield (Jordan) (ignore the hold) 26. Check in 39999000000252 - Should fill to Fairfield hold (Jordan) (ignore the hold) /Check holds queue/ /"Give library then library group" hold queue - Library/ 27. Repeat Step 13 28. Run perl misc/cronjobs/holds/build_holds_queue.pl 29. On the Hold Queue: - Centerville should be for Henry - Fairview should be for Edna /"Give library then library group" hold queue - Group/ 30. Repeat step 17 31. Run perl misc/cronjobs/holds/build_holds_queue.pl 32. On the Holds Queue: - Centerville should be for Henry - Fairview should be for Nicole /"Give Group" hold queue/ 33. Repeat steps 19-20 34. Run perl misc/cronjobs/holds/build_holds_queue.pl 35. On the Holds Queue: - Centerville should be for Jordan - Fairview should be for Nicole /"Don't Give" hold queue/ 36. Repeat Steps 23-24 37. On the Holds Queue - Centerville should be for Jordan - Fairview should be for Nicole /Also check/ Item level holds behave as expected Different combinations of LocalHoldsPriorityItemControl and LocalHoldsPriorityPatronControl Sponsored by: Cape Libraries Automated Materials Sharing Sponsored by: Northeast Kansas Library System (NEKLS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #29 from Lisette Scheer <lisette@bywatersolutions.com> --- Per some discussion with Jason, I've filed a new bug for allowing a staff interface trigger of a full holds queue rebuild. The queue has to be rebuilt after the preference is changed to take effect if the items were already queued. Bug 39859 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39859 Text to go in the|This patch adds the ability |This enhancement adds the release notes|to set the |ability to set the |"LocalHoldsPriority" system |"LocalHoldsPriority" system |preference to more options: |preference to more options: | | |-`Give Library` (current |-`Give Library` (current |behavior when on) |behavior when on) |-`Give |-`Give |Library and Group` |Library and Group` |-`Give |-`Give |Library Group` |Library Group` |-`Don't |-`Don't |give` (current behavior |give` (current behavior |when off). |when off). |The system |The system |preference will be updated |preference will be updated |in existing installations |in existing installations |to match with the new |to match with the new |options based on current |options based on current |settings. |settings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds the |This enhancement adds the release notes|ability to set the |ability to set the |"LocalHoldsPriority" system |"LocalHoldsPriority" system |preference to more options: |preference to more options: | | |-`Give Library` (current |-`Give Library` (current |behavior when on) |behavior when on) |-`Give |-`Give |Library and Group` |Library and Group` |-`Give |-`Give |Library Group` |Library Group` |-`Don't |-`Don't |give` (current behavior |give` (current behavior |when off). |when off). |The system |The system |preference will be updated |preference will be updated |in existing installations |in existing installations |to match with the new |to match with the new |options based on current |options based on current |settings. |settings. | |Note: The holds | |queue needs to be rebuilt | |after changing the | |preference to update items | |that have already been | |targeted by the queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182008|0 |1 is obsolete| | --- Comment #30 from Jason Robb <jrobb@sekls.org> --- Created attachment 182048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182048&action=edit Bug 20747: (follow-up) Fix hold queue to work with LocalHoldPriority Group options This fixes the holds queue and associated tests. I also updated the sql file to fix an issue and the LocalHoldsPriority tests to fix a typo. I'm working on final unit tests for the holds queue for all the options for QA but I wanted to get the queue changes ready for sign-off. UPDATED TEST PLAN This patch adds new options to the LocalHoldsPriority system preference to allow for the following options: 'None' the equivalent to 'Don't' pre-patch 'GiveLibrary' the equivalent to 'Do' pre-patch 'GiveLibraryAndGroup' Allows for checking the library first, then hold groups 'GiveGroup' Allows to prioritize within a group without prioritizing any library first. The included patches will update the preference in existing installations to maintain current behavior. To Test: BEFORE APPLYING THE PATCH /Tip/ I kept the following tabs open: -The holds screen (for suspending, checking order, etc) -Check in screen (can ignore holds to keep them all in place) -Holds to Pull with "All" for Libraries -System Preferences /Setup Groups and confirm current behavior/ 1. Set the following system preferences: -" LocalHoldsPriority " system preference to "Give" -"LocalHoldsPriorityPatronControl" to "home library" -"LocalHoldsPriorityItemControl" to "home library" -"RealTimeHoldsQueue" to "Enable" 2. Create 2 Library Groups - Set them to be hold groups - I called mine group 1 & group 2 3. Add 2 libraries each to each group. - Group 1 - Centerville - Fairfield - Group 2 - Fairview - Franklin 4. Find a patron for each branch in the groups - Centerville - Changed 23529000035676 (Henry) - Fairfield - Changed 23529000050113 (Jordan) - Fairview - Changed 23529001000463 (Edna) - Franklin - 23529000121682 (Nicole) 5. Find a record with at least 2 items 6. If needed change the home and holding libraries so you have at least one item for each hold group - Centerville - 39999000000252 - Fairview - Changed 39999000000238 7. Place 2 record level holds for the record. - One for 23529000035676 (Henry) for pickup at Centerville (Priority 1) - One for 23529001000463 (Edna) for pickup at Fairview (Priority 2) 8. Check in 39999000000238. The hold popup should be for the second hold (Henry), not the first (Edna.) Ignore the hold 9. Edit the record then save to trigger real time queue update 10. On the Holds Queue (submit after each set of changes): - Centerville should be for Henry - Fairview should be for Edna /apply patch and confirm behavior still works/ 10. Apply patch 11. Rebuild the database then restart_all (in sandboxes it's an action, in ktd " dbic && updatedatabase && restart_all ") 12. Confirm that " LocalHoldsPriority " is set to "Give Library" 13. Repeat steps 8-10, behavior should be the same. / check library then library group setting/ 14. Change " LocalHoldsPriority " to "Give library then library group" 15. Set the following record level holds for the record in the following order: *You can add Jordan and Nicole's, then rearrange the order. - Pickup at Fairfield - 23529000050113 (Jordan) - Pickup at Franklin - 23529000121682 (Nicole) - Pickup at Centerville - 23529000035676 (Henry) - Pickup at Fairview - 23529001000463 (Edna) 17. Check in 39999000000252 - should try and fill to Centerville - 23529000035676 (Henry) 17. Check in 39999000000238 - should try and fill to Fairview - 23529001000463 (Edna) 18. On the Hold Queue: - Centerville should be for Henry - Fairview should be for Edna 19. Suspend the hold for 23529001000463 (Edna) 20. Check in 39999000000238 should try and fill to 23529000121682 (Nicole) (ignore the hold) 21. On the Holds Queue: - Centerville should be for Henry - Fairview should be for Nicole / check library group setting / 22. Reset the holds to match step 15. 23. Change " LocalHoldsPriority " to "Give group" 24. Check in 39999000000252 - should try and fill to Fairfield (Jordan) (ignore the hold) 25. Check in 39999000000238 - should try and fill to Franklin (Nicole) (ignore the hold) 26. On the Holds Queue: - Centerville should be for Jordan - Fairview should be for Nicole /check no priority / 27. Change " LocalHoldsPriority " to "Don't give" 28. Reset the holds to match step 15. 29. Check in 39999000000238 - Should fill to Fairfield (Jordan) (ignore the hold) 30. Check in 39999000000252 - Should fill to Fairfield hold (Jordan) (ignore the hold) 31. On the Holds Queue: - Centerville should be for Jordan - Fairview should be for Nicole /Also check/ Item level holds behave as expected Different combinations of LocalHoldsPriorityItemControl and LocalHoldsPriorityPatronControl Sponsored by: Cape Libraries Automated Materials Sharing Sponsored by: Northeast Kansas Library System (NEKLS) Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181319|0 |1 is obsolete| | --- Comment #31 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 182049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182049&action=edit Bug 20747: Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library This patch adds new options to the LocalHoldsPriority system preference to allow for the following options: 'None' the equivalent to 'Don't' pre-patch 'GiveLibrary' the equivalent to 'Do' pre-patch 'GiveLibraryAndGroup' Allows for checking the library first, then hold groups 'GiveGroup' Allows to prioritize within a group without prioritizing any library first. The included patches will update the preference in existing installations to maintain current behavior. To Test: BEFORE APPLYING THE PATCH /Setup Groups and confirm current behavior/ 1. Set the " LocalHoldsPriority " system preference to "Give", "LocalHoldsPriorityPatronControl" to "home library" and "LocalHoldsPriorityItemControl" to "home library" 2. Create 2 Library hold Groups - I called mine group 1 & group 2 3. Add 2 libraries each to each group. - Group 1 - Centerville - Fairfield - Group 2 - Fairview - Franklin 4. Find a patron for each branch in the groups - Centerville - 23529000035676 (Henry) - Fairfield - Changed 23529000050113 - Fairview - Changed 23529001000463 (Edna) - Franklin - 23529000121682 5. Find a record with at least 2 items 6. If needed change the home and holding libraries so you have at least one item for each hold group - Centerville - 39999000000252 - Fairview - Changed 39999000000238 7. Place 2 record level holds for the record. - One for 23529000035676 for pickup at Centerville (Priority 1) - One for 23529001000463 for pickup at fairview (Priority 2) 8. Check in 39999000000238. The hold popup should be for the second hold, not the first. /apply patch and confirm behavior still works/ 9. Apply patch 10. Rebuild the database then restart_all (in sandboxes it's an action, in ktd " dbic && updatedatabase && restart_all ") 11. Confirm that " LocalHoldsPriority " is set to "Give Library" 12. Repeat steps 7-8, behavior should be the same. / check library then library group setting/ 13. Change " LocalHoldsPriority " to "Give library then library group" 14. Set the following record level holds for the record: - Pickup at Fairfield - 23529000050113 - Pickup at Franklin - 23529000121682 - Pickup at Centerville - 23529000035676 (Henry) - Pickup at Fairview - 23529001000463 (Edna) 15. Check in 39999000000252 - should try and fill to Centerville - 23529000035676 (Henry) 16. Check in 39999000000238 - should try and fill to Fairview - 23529001000463 (Edna) 17. Cancel the hold for 23529001000463 18. Check in 39999000000238 should try and fill to 23529000121682 / check library group setting / 19. Reset the holds to match step 14. 20. Check in 39999000000252 - should try and fill to Fairfield 21. Check in 39999000000238 - should try and fill to Franklin /check no priority / 22. Reset the holds to match step 14. 23. Check in 39999000000238 - Should fill the Fairfield hold 24. Check in 39999000000252 - Should fill the Franklin hold /Also check/ Item level holds behave as expected Different combinations of LocalHoldsPriorityItemControl and LocalHoldsPriorityPatronControl Sponsored by: Cape Libraries Automated Materials Sharing Sponsored by: Northeast Kansas Library System (NEKLS) Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181320|0 |1 is obsolete| | --- Comment #32 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 182050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182050&action=edit Bug 20747: DB Rev This patch adds a DB rev to update the system preference in existing installations. # Please enter the commit message for your changes. Lines starting Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181321|0 |1 is obsolete| | --- Comment #33 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 182051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182051&action=edit Bug 20747: (follow-up) fix atomic update This update moves the atomic update to the correct place, updates permissions, and fixes an error in the original patch. Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182048|0 |1 is obsolete| | --- Comment #34 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 182052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182052&action=edit Bug 20747: (follow-up) Fix hold queue to work with LocalHoldPriority Group options This fixes the holds queue and associated tests. I also updated the sql file to fix an issue and the LocalHoldsPriority tests to fix a typo. I'm working on final unit tests for the holds queue for all the options for QA but I wanted to get the queue changes ready for sign-off. UPDATED TEST PLAN This patch adds new options to the LocalHoldsPriority system preference to allow for the following options: 'None' the equivalent to 'Don't' pre-patch 'GiveLibrary' the equivalent to 'Do' pre-patch 'GiveLibraryAndGroup' Allows for checking the library first, then hold groups 'GiveGroup' Allows to prioritize within a group without prioritizing any library first. The included patches will update the preference in existing installations to maintain current behavior. To Test: BEFORE APPLYING THE PATCH /Tip/ I kept the following tabs open: -The holds screen (for suspending, checking order, etc) -Check in screen (can ignore holds to keep them all in place) -Holds to Pull with "All" for Libraries -System Preferences /Setup Groups and confirm current behavior/ 1. Set the following system preferences: -" LocalHoldsPriority " system preference to "Give" -"LocalHoldsPriorityPatronControl" to "home library" -"LocalHoldsPriorityItemControl" to "home library" -"RealTimeHoldsQueue" to "Enable" 2. Create 2 Library Groups - Set them to be hold groups - I called mine group 1 & group 2 3. Add 2 libraries each to each group. - Group 1 - Centerville - Fairfield - Group 2 - Fairview - Franklin 4. Find a patron for each branch in the groups - Centerville - Changed 23529000035676 (Henry) - Fairfield - Changed 23529000050113 (Jordan) - Fairview - Changed 23529001000463 (Edna) - Franklin - 23529000121682 (Nicole) 5. Find a record with at least 2 items 6. If needed change the home and holding libraries so you have at least one item for each hold group - Centerville - 39999000000252 - Fairview - Changed 39999000000238 7. Place 2 record level holds for the record. - One for 23529000035676 (Henry) for pickup at Centerville (Priority 1) - One for 23529001000463 (Edna) for pickup at Fairview (Priority 2) 8. Check in 39999000000238. The hold popup should be for the second hold (Henry), not the first (Edna.) Ignore the hold 9. Edit the record then save to trigger real time queue update 10. On the Holds Queue (submit after each set of changes): - Centerville should be for Henry - Fairview should be for Edna /apply patch and confirm behavior still works/ 10. Apply patch 11. Rebuild the database then restart_all (in sandboxes it's an action, in ktd " dbic && updatedatabase && restart_all ") 12. Confirm that " LocalHoldsPriority " is set to "Give Library" 13. Repeat steps 8-10, behavior should be the same. / check library then library group setting/ 14. Change " LocalHoldsPriority " to "Give library then library group" 15. Set the following record level holds for the record in the following order: *You can add Jordan and Nicole's, then rearrange the order. - Pickup at Fairfield - 23529000050113 (Jordan) - Pickup at Franklin - 23529000121682 (Nicole) - Pickup at Centerville - 23529000035676 (Henry) - Pickup at Fairview - 23529001000463 (Edna) 17. Check in 39999000000252 - should try and fill to Centerville - 23529000035676 (Henry) 17. Check in 39999000000238 - should try and fill to Fairview - 23529001000463 (Edna) 18. On the Hold Queue: - Centerville should be for Henry - Fairview should be for Edna 19. Suspend the hold for 23529001000463 (Edna) 20. Check in 39999000000238 should try and fill to 23529000121682 (Nicole) (ignore the hold) 21. On the Holds Queue: - Centerville should be for Henry - Fairview should be for Nicole / check library group setting / 22. Reset the holds to match step 15. 23. Change " LocalHoldsPriority " to "Give group" 24. Check in 39999000000252 - should try and fill to Fairfield (Jordan) (ignore the hold) 25. Check in 39999000000238 - should try and fill to Franklin (Nicole) (ignore the hold) 26. On the Holds Queue: - Centerville should be for Jordan - Fairview should be for Nicole /check no priority / 27. Change " LocalHoldsPriority " to "Don't give" 28. Reset the holds to match step 15. 29. Check in 39999000000238 - Should fill to Fairfield (Jordan) (ignore the hold) 30. Check in 39999000000252 - Should fill to Fairfield hold (Jordan) (ignore the hold) 31. On the Holds Queue: - Centerville should be for Jordan - Fairview should be for Nicole /Also check/ Item level holds behave as expected Different combinations of LocalHoldsPriorityItemControl and LocalHoldsPriorityPatronControl Sponsored by: Cape Libraries Automated Materials Sharing Sponsored by: Northeast Kansas Library System (NEKLS) Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #35 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for the detailed test plan, Lisette! This worked exactly how described. Notes: Once during testing the holds were filled differently than what was expected from the plan, but I realized that it was because I was checking all the items into Centerville. When I reset the item's current library to match the home library the holds were fulfilled as expected from the test plan. To help with getting set up to test this you can use this SQL and then continue on from step 7: -- set initial system preferences UPDATE systempreferences SET value = '1' WHERE variable = 'LocalHoldsPriority'; UPDATE systempreferences SET value = 'HomeLibrary' WHERE variable = 'LocalHoldsPriorityPatronControl'; UPDATE systempreferences SET value = 'homebranch' WHERE variable = 'LocalHoldsPriorityItemControl'; -- create library groups INSERT INTO library_groups (title, ft_local_hold_group) VALUES ('Group 1', 1); INSERT INTO library_groups (title, ft_local_hold_group) VALUES ('Group 2', 1); -- add libraries to groups INSERT INTO library_groups (parent_id, branchcode) VALUES (1, 'CPL'); INSERT INTO library_groups (parent_id, branchcode) VALUES (1, 'FFL'); INSERT INTO library_groups (parent_id, branchcode) VALUES (2, 'FPL'); INSERT INTO library_groups (parent_id, branchcode) VALUES (2, 'FRL'); -- set up patrons UPDATE borrowers SET branchcode = 'CPL' WHERE cardnumber = '23529000035676'; UPDATE borrowers SET branchcode = 'FFL' WHERE cardnumber = '23529000050113'; UPDATE borrowers SET branchcode = 'FPL' WHERE cardnumber = '23529001000463'; UPDATE borrowers SET branchcode = 'FRL' WHERE cardnumber = '23529000121682'; -- set up items UPDATE items SET homebranch = 'FPL' WHERE barcode = '39999000000238'; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182049|0 |1 is obsolete| | --- Comment #36 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182191&action=edit Bug 20747: Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library This patch adds new options to the LocalHoldsPriority system preference to allow for the following options: 'None' the equivalent to 'Don't' pre-patch 'GiveLibrary' the equivalent to 'Do' pre-patch 'GiveLibraryAndGroup' Allows for checking the library first, then hold groups 'GiveGroup' Allows to prioritize within a group without prioritizing any library first. The included patches will update the preference in existing installations to maintain current behavior. To Test: BEFORE APPLYING THE PATCH /Setup Groups and confirm current behavior/ 1. Set the " LocalHoldsPriority " system preference to "Give", "LocalHoldsPriorityPatronControl" to "home library" and "LocalHoldsPriorityItemControl" to "home library" 2. Create 2 Library hold Groups - I called mine group 1 & group 2 3. Add 2 libraries each to each group. - Group 1 - Centerville - Fairfield - Group 2 - Fairview - Franklin 4. Find a patron for each branch in the groups - Centerville - 23529000035676 (Henry) - Fairfield - Changed 23529000050113 - Fairview - Changed 23529001000463 (Edna) - Franklin - 23529000121682 5. Find a record with at least 2 items 6. If needed change the home and holding libraries so you have at least one item for each hold group - Centerville - 39999000000252 - Fairview - Changed 39999000000238 7. Place 2 record level holds for the record. - One for 23529000035676 for pickup at Centerville (Priority 1) - One for 23529001000463 for pickup at fairview (Priority 2) 8. Check in 39999000000238. The hold popup should be for the second hold, not the first. /apply patch and confirm behavior still works/ 9. Apply patch 10. Rebuild the database then restart_all (in sandboxes it's an action, in ktd " dbic && updatedatabase && restart_all ") 11. Confirm that " LocalHoldsPriority " is set to "Give Library" 12. Repeat steps 7-8, behavior should be the same. / check library then library group setting/ 13. Change " LocalHoldsPriority " to "Give library then library group" 14. Set the following record level holds for the record: - Pickup at Fairfield - 23529000050113 - Pickup at Franklin - 23529000121682 - Pickup at Centerville - 23529000035676 (Henry) - Pickup at Fairview - 23529001000463 (Edna) 15. Check in 39999000000252 - should try and fill to Centerville - 23529000035676 (Henry) 16. Check in 39999000000238 - should try and fill to Fairview - 23529001000463 (Edna) 17. Cancel the hold for 23529001000463 18. Check in 39999000000238 should try and fill to 23529000121682 / check library group setting / 19. Reset the holds to match step 14. 20. Check in 39999000000252 - should try and fill to Fairfield 21. Check in 39999000000238 - should try and fill to Franklin /check no priority / 22. Reset the holds to match step 14. 23. Check in 39999000000238 - Should fill the Fairfield hold 24. Check in 39999000000252 - Should fill the Franklin hold /Also check/ Item level holds behave as expected Different combinations of LocalHoldsPriorityItemControl and LocalHoldsPriorityPatronControl Sponsored by: Cape Libraries Automated Materials Sharing Sponsored by: Northeast Kansas Library System (NEKLS) Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182050|0 |1 is obsolete| | --- Comment #37 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182192&action=edit Bug 20747: DB Rev This patch adds a DB rev to update the system preference in existing installations. # Please enter the commit message for your changes. Lines starting Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182051|0 |1 is obsolete| | --- Comment #38 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182193&action=edit Bug 20747: (follow-up) fix atomic update This update moves the atomic update to the correct place, updates permissions, and fixes an error in the original patch. Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182052|0 |1 is obsolete| | --- Comment #39 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182194&action=edit Bug 20747: (follow-up) Fix hold queue to work with LocalHoldPriority Group options This fixes the holds queue and associated tests. I also updated the sql file to fix an issue and the LocalHoldsPriority tests to fix a typo. I'm working on final unit tests for the holds queue for all the options for QA but I wanted to get the queue changes ready for sign-off. UPDATED TEST PLAN This patch adds new options to the LocalHoldsPriority system preference to allow for the following options: 'None' the equivalent to 'Don't' pre-patch 'GiveLibrary' the equivalent to 'Do' pre-patch 'GiveLibraryAndGroup' Allows for checking the library first, then hold groups 'GiveGroup' Allows to prioritize within a group without prioritizing any library first. The included patches will update the preference in existing installations to maintain current behavior. To Test: BEFORE APPLYING THE PATCH /Tip/ I kept the following tabs open: -The holds screen (for suspending, checking order, etc) -Check in screen (can ignore holds to keep them all in place) -Holds to Pull with "All" for Libraries -System Preferences /Setup Groups and confirm current behavior/ 1. Set the following system preferences: -" LocalHoldsPriority " system preference to "Give" -"LocalHoldsPriorityPatronControl" to "home library" -"LocalHoldsPriorityItemControl" to "home library" -"RealTimeHoldsQueue" to "Enable" 2. Create 2 Library Groups - Set them to be hold groups - I called mine group 1 & group 2 3. Add 2 libraries each to each group. - Group 1 - Centerville - Fairfield - Group 2 - Fairview - Franklin 4. Find a patron for each branch in the groups - Centerville - Changed 23529000035676 (Henry) - Fairfield - Changed 23529000050113 (Jordan) - Fairview - Changed 23529001000463 (Edna) - Franklin - 23529000121682 (Nicole) 5. Find a record with at least 2 items 6. If needed change the home and holding libraries so you have at least one item for each hold group - Centerville - 39999000000252 - Fairview - Changed 39999000000238 7. Place 2 record level holds for the record. - One for 23529000035676 (Henry) for pickup at Centerville (Priority 1) - One for 23529001000463 (Edna) for pickup at Fairview (Priority 2) 8. Check in 39999000000238. The hold popup should be for the second hold (Henry), not the first (Edna.) Ignore the hold 9. Edit the record then save to trigger real time queue update 10. On the Holds Queue (submit after each set of changes): - Centerville should be for Henry - Fairview should be for Edna /apply patch and confirm behavior still works/ 10. Apply patch 11. Rebuild the database then restart_all (in sandboxes it's an action, in ktd " dbic && updatedatabase && restart_all ") 12. Confirm that " LocalHoldsPriority " is set to "Give Library" 13. Repeat steps 8-10, behavior should be the same. / check library then library group setting/ 14. Change " LocalHoldsPriority " to "Give library then library group" 15. Set the following record level holds for the record in the following order: *You can add Jordan and Nicole's, then rearrange the order. - Pickup at Fairfield - 23529000050113 (Jordan) - Pickup at Franklin - 23529000121682 (Nicole) - Pickup at Centerville - 23529000035676 (Henry) - Pickup at Fairview - 23529001000463 (Edna) 17. Check in 39999000000252 - should try and fill to Centerville - 23529000035676 (Henry) 17. Check in 39999000000238 - should try and fill to Fairview - 23529001000463 (Edna) 18. On the Hold Queue: - Centerville should be for Henry - Fairview should be for Edna 19. Suspend the hold for 23529001000463 (Edna) 20. Check in 39999000000238 should try and fill to 23529000121682 (Nicole) (ignore the hold) 21. On the Holds Queue: - Centerville should be for Henry - Fairview should be for Nicole / check library group setting / 22. Reset the holds to match step 15. 23. Change " LocalHoldsPriority " to "Give group" 24. Check in 39999000000252 - should try and fill to Fairfield (Jordan) (ignore the hold) 25. Check in 39999000000238 - should try and fill to Franklin (Nicole) (ignore the hold) 26. On the Holds Queue: - Centerville should be for Jordan - Fairview should be for Nicole /check no priority / 27. Change " LocalHoldsPriority " to "Don't give" 28. Reset the holds to match step 15. 29. Check in 39999000000238 - Should fill to Fairfield (Jordan) (ignore the hold) 30. Check in 39999000000252 - Should fill to Fairfield hold (Jordan) (ignore the hold) 31. On the Holds Queue: - Centerville should be for Jordan - Fairview should be for Nicole /Also check/ Item level holds behave as expected Different combinations of LocalHoldsPriorityItemControl and LocalHoldsPriorityPatronControl Sponsored by: Cape Libraries Automated Materials Sharing Sponsored by: Northeast Kansas Library System (NEKLS) Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #40 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182195&action=edit Bug 20747: (QA follow-up) Fix sysprefs.sql The SQL file doesn't load properly due to a missing comma - this patch fixes that Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 trevor.diamond@mainlib.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |trevor.diamond@mainlib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Kris <kbecker@jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kbecker@jcls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39989 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39989 [Bug 39989] Expand LocalHoldsPriority groups to allow different settings by group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39990 [Bug 39990] Expand library group feature 'Is local hold' group to subgroups for local holds priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #42 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |loreganlloyd@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43378 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43378 [Bug 43378] Wrong hold can be selected when LocalHoldsPriority set to GiveLibraryAndGroup -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org