[Bug 24171] New: Cannot do on-site checkouts/automatic renewal with Itemfallbacksearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Bug ID: 24171 Summary: Cannot do on-site checkouts/automatic renewal with Itemfallbacksearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When using Itemfallbacksearch for checking out items without barcode, the checkboxes for automatic-renewal and on-site checkout are ignored. To test: - Turn on OnSiteCheckouts and Itemfallbacksearch - Open a patron account - Check the checkboxes for automatic-renewal and on-site checkout - Search for a title keyword in the checkout input box - Verify that the item checked out is not checked out as on-site and no auto-renewal flag was set -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Summary|Cannot do on-site |Cannot do automatic renewal |checkouts/automatic renewal |with |with Itemfallbacksearch |itemBarcodeFallbackSearch --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- on-site checkout works for me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96361&action=edit Bug 24171: Preserve auto_renew when triggering itemBarcodeFallbackSearch The auto_renew parameter is not sent to the template when the popup triggered by itemBarcodeFallbackSearch is displayed. Test plan: - Turn on OnSiteCheckouts and Itemfallbacksearch - Open a patron account - Check the checkboxes for automatic-renewal and on-site checkout - Search for a title keyword in the checkout input box - Verify that auto-renewal flag is set Note for QA: The auto_renew flag will be set in any cases. Should we expect regression? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96361|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96362&action=edit Bug 24171: Preserve auto_renew when triggering itemBarcodeFallbackSearch The auto_renew parameter is not sent to the template when the popup triggered by itemBarcodeFallbackSearch is displayed. Test plan: - Turn on itemBarcodeFallbackSearch - Open a patron account - Check the checkboxes for automatic-renewal - Search for a title keyword in the checkout input box - Verify that auto-renewal flag is set Note for QA: The auto_renew flag will be set in any cases. Should we expect regression? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Might be a version thing - thx Joubu! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This almost works perfectly, but there is one thing that is confusing: When there is a dialog (patron has some fines or more checked out than allowed override) the checkbox appears "unchecked", which is confusing. Could this be improved? Also tested in combination with OnSiteCheckoutAutoCheck. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96603&action=edit Bug 24171: Check auto_renew if confirmation is needed Test plan: Add some fines Check auto_renew and check an item out, using a title keyword Pick one item You get the confirmation box => Notice that the auto_renew checkbox is checked -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Still not perfect, the "on-site checkout" is not disabled. But I would move that to its own bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96362|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96726&action=edit Bug 24171: Preserve auto_renew when triggering itemBarcodeFallbackSearch The auto_renew parameter is not sent to the template when the popup triggered by itemBarcodeFallbackSearch is displayed. Test plan: - Turn on itemBarcodeFallbackSearch - Open a patron account - Check the checkboxes for automatic-renewal - Search for a title keyword in the checkout input box - Verify that auto-renewal flag is set Note for QA: The auto_renew flag will be set in any cases. Should we expect regression? Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96603|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96727&action=edit Bug 24171: Check auto_renew if confirmation is needed Test plan: Add some fines Check auto_renew and check an item out, using a title keyword Pick one item You get the confirmation box => Notice that the auto_renew checkbox is checked Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In Firefox the option appears as disabled without the 'checked', but I think this is a browser issue and disabling it makes sense when you can't remove the option in that moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96726|0 |1 is obsolete| | --- Comment #11 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 98254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98254&action=edit Bug 24171: Preserve auto_renew when triggering itemBarcodeFallbackSearch The auto_renew parameter is not sent to the template when the popup triggered by itemBarcodeFallbackSearch is displayed. Test plan: - Turn on itemBarcodeFallbackSearch - Open a patron account - Check the checkboxes for automatic-renewal - Search for a title keyword in the checkout input box - Verify that auto-renewal flag is set Note for QA: The auto_renew flag will be set in any cases. Should we expect regression? Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96727|0 |1 is obsolete| | --- Comment #12 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 98255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98255&action=edit Bug 24171: Check auto_renew if confirmation is needed Test plan: Add some fines Check auto_renew and check an item out, using a title keyword Pick one item You get the confirmation box => Notice that the auto_renew checkbox is checked Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #14 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org