[Bug 38293] New: Cannot add Specific OPAC JS or CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 Bug ID: 38293 Summary: Cannot add Specific OPAC JS or CSS Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org I just noticed in ktd that trying to add Specific OPAC JS or Specific OPAC CSS won't work and causes a Javascript error to appear in the console -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |System Administration CC| |gmcharlt@gmail.com Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 173697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173697&action=edit Bug 38293: Fix setting branch-level JS and CSS Test plan: 1. Apply the patch 2. Go to http://localhost:8081/cgi-bin/koha/admin/branches.pl? op=add_form&branchcode=CPL 3. Scroll to bottom of the page and click "Edit" then "Collapse" next to Specific OPAC JS and Specific OPAC CSS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 173698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173698&action=edit Bug 38293: (alternate) Fix setting branch-level JS and CSS Test plan: 1. Apply the patch 2. Go to http://localhost:8081/cgi-bin/koha/admin/branches.pl? op=add_form&branchcode=CPL 3. Scroll to bottom of the page and click "Edit" then "Collapse" next to Specific OPAC JS and Specific OPAC CSS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | CC| |oleonard@myacpl.org --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I've got 2 possible fixes here, and copying in Owen as I'm not 100% sure what the right one is. I think the right one is probably the "alternate", or maybe a variation on the alternate. Basically, I don't think Bootstrap is involved with these textareas, so I think it was probably just updated by accident. But maybe we should change the attribute from "target" to something else, so it doesn't get confused with a Bootstrap control. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression, RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173697|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173698|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173707&action=edit Bug 38293: (alternate) Fix setting branch-level JS and CSS Test plan: 1. Apply the patch 2. Go to http://localhost:8081/cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=CPL 3. Scroll to bottom of the page and click "Edit" then "Collapse" next to Specific OPAC JS and Specific OPAC CSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Cook from comment #3)
Basically, I don't think Bootstrap is involved with these textareas, so I think it was probably just updated by accident.
This is correct. Thanks for finding it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173707|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 173726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173726&action=edit Bug 38293: (alternate) Fix setting branch-level JS and CSS Test plan: 1. Apply the patch 2. Go to http://localhost:8081/cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=CPL 3. Scroll to bottom of the page and click "Edit" then "Collapse" next to Specific OPAC JS and Specific OPAC CSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes adding Specific release notes| |OPAC JS and Specific OPAC | |CSS for libraries - you can | |now add or edit these | |settings. (This is related | |to the OPAC and staff | |interface Bootstrap 5 | |upgrade in Koha 24.11.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173726|0 |1 is obsolete| | --- Comment #7 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 173737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173737&action=edit Bug 38293: (alternate) Fix setting branch-level JS and CSS Test plan: 1. Apply the patch 2. Go to http://localhost:8081/cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=CPL 3. Scroll to bottom of the page and click "Edit" then "Collapse" next to Specific OPAC JS and Specific OPAC CSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC| |emily.lamancusa@montgomeryc | |ountymd.gov Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 Bug 38293 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38293 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org