[Bug 38619] New: UNIMARC prices should also be extracted from 073d
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 Bug ID: 38619 Summary: UNIMARC prices should also be extracted from 073d Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org When adding a document that does not use 010d as price document, but 071d, the price is not imported from koha since it only checks 010d and 345d. To reproduce: 1 - Create a Koha item, make sure there is neither 010d or 345d 2 - Add a 071d and fill a price 3 - Export the item as marcxml 4 - If you do not have one: in acquisition, create a vendor, a basket associated to this vendor, and a line associated to this vendor 5 - Add a line to any open basket, select: import "from a new file" and select the exported marcxml 6 - The price in 071 is not exported -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|UNIMARC prices should also |UNIMARC prices should also |be extracted from 073d |be extracted from 071d -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 175169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175169&action=edit Bug 38619: UNIMARC prices should also be extracted from 071d When adding a document that does not use 010d as price document, but 071d, the price is not imported from koha since it only checks 010d and 345d. To reproduce: 1 - Create a Koha item, make sure there is neither 010d or 345d 2 - Add a 071d and fill a price 3 - Export the item as marcxml 4 - If you do not have one: in acquisition, create a vendor, a basket associated to this vendor, and a line associated to this vendor 5 - Add a line to any open basket, select: import "from a new file" and select the exported marcxml -> The price in 071 is not imported 6 - Apply patch 7 - Repeat 5 -> the price is properly imported -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #2 from Mathieu Saby <mathsabypro@gmail.com> --- Does the function extract also price from 073$d and 072$d? It can be there too -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 --- Comment #3 from Mathieu Saby <mathsabypro@gmail.com> --- For information, this 071 fied contains an editorial reference number that is not governed by an international standard. These numbers are generally used for sound recordings, printed music publications, videograms and electronic resources. The UNIMARC standard indicates that a $d is possible, with the same type of information as would be found in a 010$d for an ISBN. So it is legitimate do collect the price from this field. Question for Baptiste : what happens if a price is also present in 010 field, and if the 2 prices are not the same ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- All the field are parsed in the order of the array, so it will search the 345$d, if it doesn't find, it will search the 010$d. With this patch, after searching the 010$d, it will search the 071$d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- The patch no longer applies: git bz apply 38619 Bug 38619 - UNIMARC prices should also be extracted from 071d 175169 - Bug 38619: UNIMARC prices should also be extracted from 071d Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38619: UNIMARC prices should also be extracted from 071d Using index info to reconstruct a base tree... M C4/Biblio.pm Falling back to patching base and 3-way merge... Auto-merging C4/Biblio.pm CONFLICT (content): Merge conflict in C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 38619: UNIMARC prices should also be extracted from 071d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175169|0 |1 is obsolete| | --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 182651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182651&action=edit Bug 38619: UNIMARC prices should also be extracted from 071d When adding a document that does not use 010d as price document, but 071d, the price is not imported from koha since it only checks 010d and 345d. To reproduce: 1 - Create a Koha item, make sure there is neither 010d or 345d 2 - Add a 071d and fill a price 3 - Export the item as marcxml 4 - If you do not have one: in acquisition, create a vendor, a basket associated to this vendor, and a line associated to this vendor 5 - Add a line to any open basket, select: import "from a new file" and select the exported marcxml -> The price in 071 is not imported 6 - Apply patch 7 - Repeat 5 -> the price is properly imported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182651|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 182712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182712&action=edit Bug 38619: UNIMARC prices should also be extracted from 071d When adding a document that does not use 010d as price document, but 071d, the price is not imported from koha since it only checks 010d and 345d. To reproduce: 1 - Create a Koha item, make sure there is neither 010d or 345d 2 - Add a 071d and fill a price 3 - Export the item as marcxml 4 - If you do not have one: in acquisition, create a vendor, a basket associated to this vendor, and a line associated to this vendor 5 - Add a line to any open basket, select: import "from a new file" and select the exported marcxml -> The price in 071 is not imported 6 - Apply patch 7 - Repeat 5 -> the price is properly imported Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement imports release notes| |the value in 071$d to the | |price field when adding an | |item to a basket using the | |"From a new file" option. | |Before this, it only | |imported the value from | |010$d and 345$d. --- Comment #8 from David Nind <david@davidnind.com> --- I've signed off. When testing, I noted that: 1. The 071$d value (such as 50.00) needs the decimal places. 2. If there are no decimal places, for example just 50, then the value is not imported. This was the same behavour as 010$d and 345$d. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182712|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 185268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185268&action=edit Bug 38619: UNIMARC prices should also be extracted from 071d When adding a document that does not use 010d as price document, but 071d, the price is not imported from koha since it only checks 010d and 345d. To reproduce: 1 - Create a Koha item, make sure there is neither 010d or 345d 2 - Add a 071d and fill a price 3 - Export the item as marcxml 4 - If you do not have one: in acquisition, create a vendor, a basket associated to this vendor, and a line associated to this vendor 5 - Add a line to any open basket, select: import "from a new file" and select the exported marcxml -> The price in 071 is not imported 6 - Apply patch 7 - Repeat 5 -> the price is properly imported Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Given time elapsed, not going to ask for a test on this trivial oneliner. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.04 |25.11.00,25.05.04,24.11.10 released in| | --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38619 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org