[Bug 14839] New: 'anonymous' purchase suggestions are created with 'Anon' user's branchcode ignored, (NULL branchcode)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14839 Bug ID: 14839 Summary: 'anonymous' purchase suggestions are created with 'Anon' user's branchcode ignored, (NULL branchcode) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org if an anonymous purchase suggestion is created from the OPAC, it's branchcode is NULL, despite the 'Anon' user having a valid branchcode this bug makes any 'Anon' suggestion invisible in the staff interface more info to come... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14839 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14830 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14839 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10753 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14839 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I don't think we should be using the Anon user's branchcode - we only have one AnonymousPatron account, even for very big systems with multiple branches. Using an empty branchcode would be better and make that show up correctly again in the interface. It used to be a string - I think __ANY__ or similar, but there was a patch that changed it to be empty, which makes more sense, but might have missed something. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14839 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Mason, If you plan to work on it, please assign you the bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14839 --- Comment #3 from Mason James <mtj@kohaaloha.com> --- (In reply to Katrin Fischer from comment #1)
I don't think we should be using the Anon user's branchcode - we only have one AnonymousPatron account, even for very big systems with multiple branches. Using an empty branchcode would be better and make that show up correctly again in the interface. It used to be a string - I think __ANY__ or similar, but there was a patch that changed it to be empty, which makes more sense, but might have missed something.
hiya, yes - I do agree with you Cait :0) I think a better fix would be to modify the staff suggestions page, to display all NULL suggestions ^ i do have a small SQL patch for this, that i'll attach -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14839 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtj@kohaaloha.com |ity.org | Status|NEW |In Discussion --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #2)
Mason, If you plan to work on it, please assign you the bug.
yes, will do -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14839 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14830 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830 [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14839 --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #4)
(In reply to Jonathan Druart from comment #2)
Mason, If you plan to work on it, please assign you the bug.
yes, will do
i've attached my patch to BZ 14830 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14839 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org