[Bug 20102] New: Remove attribute "text/css" for <style> element used in staff client templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20102 Bug ID: 20102 Summary: Remove attribute "text/css" for <style> element used in staff client templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. The type attribute is optional, and when none is provided it defaults to "text/css" - https://www.w3.org/TR/html5/document-metadata.html#element-attrdef-style-typ.... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20102 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20102 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82759&action=edit Bug 20102: Remove attribute "text/css" for <style> element used in staff client templates This patch modifies staff client templates to remove the "type" attribute from <style> tags. The attribute is no longer valid. To test, apply the patch and confirm the changes to the templates. The appearance of the staff client should be unchanged. Validating pages from the staff client should not return any errors related to the <style> "type" attribute. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20102 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82759|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84703&action=edit Bug 20102: Remove attribute "text/css" for <style> element used in staff client templates This patch modifies staff client templates to remove the "type" attribute from <style> tags. The attribute is no longer valid. To test, apply the patch and confirm the changes to the templates. The appearance of the staff client should be unchanged. Validating pages from the staff client should not return any errors related to the <style> "type" attribute. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20102 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84703|0 |1 is obsolete| | --- Comment #3 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> --- Created attachment 84902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84902&action=edit Bug 20102: Remove attribute "text/css" for <style> element used in staff client templates This patch modifies staff client templates to remove the "type" attribute from <style> tags. The attribute is no longer valid. To test, apply the patch and confirm the changes to the templates. The appearance of the staff client should be unchanged. Validating pages from the staff client should not return any errors related to the <style> "type" attribute. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20102 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20102 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20102 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84902|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84905&action=edit Bug 20102: Remove attribute "text/css" for <style> element used in staff client templates This patch modifies staff client templates to remove the "type" attribute from <style> tags. The attribute is no longer valid. To test, apply the patch and confirm the changes to the templates. The appearance of the staff client should be unchanged. Validating pages from the staff client should not return any errors related to the <style> "type" attribute. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20102 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove attribute "text/css" |Remove attribute "text/css" |for <style> element used in |for style element used in |staff client templates |staff client templates --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The <style> in the title broke display of the release notes on gitlab. Removing the <>. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20102 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |minor Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It's good to be conformant, pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20102 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org