[Bug 19714] New: 2 occurrences of memberofinstitution have not been removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714 Bug ID: 19714 Summary: 2 occurrences of memberofinstitution have not been removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 11751 C4/UsageStats.pm: memberofinstitution t/db_dependent/UsageStats.t: memberofinstitution Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11751 [Bug 11751] Some code related to "institution" is unused and obsolete -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714 --- Comment #1 from Jessica <jessicafreeman@catalyst.net.nz> --- Created attachment 69868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69868&action=edit Bug: 19714 - Removing 2 occurrences of memberofinstitution To Test: 1/grep for memberofinstitution 2/Notice it occurs in C4/UsageStats.pm and t/db_dependent/UsageStats.t 3/grep again, notice they have been removed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714 --- Comment #2 from Jessica <jessicafreeman@catalyst.net.nz> --- Created attachment 69869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69869&action=edit Bug: 19714 - Removing 2 occurrences of memberofinstitution To Test: 1/grep for memberofinstitution 2/Notice it occurs in C4/UsageStats.pm and t/db_dependent/UsageStats.t 3/grep again, notice they have been removed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714 Jessica <jessicafreeman@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jessicafreeman@catalyst.net | |.nz Attachment #69868|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714 Jessica <jessicafreeman@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69869|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 69894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69894&action=edit Bug: 19714 - Removing 2 occurrences of memberofinstitution To Test: 1/grep for memberofinstitution 2/Notice it occurs in C4/UsageStats.pm and t/db_dependent/UsageStats.t 3/grep again, notice they have been removed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you, Jessica! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69894|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69897&action=edit Bug: 19714 - Removing 2 occurrences of memberofinstitution To Test: 1/grep for memberofinstitution 2/Notice it occurs in C4/UsageStats.pm and t/db_dependent/UsageStats.t 3/grep again, notice they have been removed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | Assignee|koha-bugs@lists.koha-commun |jessicafreeman@catalyst.net |ity.org |.nz CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patch pushed to master for 18.05. Thanks Jessica and congrats for your first patch in! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org