https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124322&action=edit Bug 28934: Correct markup of GDPR consent in OPAC patron entry This patch makes changes to the markup around the GDPR consent checkbox in the OPAC self-registration / update page to make it more consistent with other form fields on the page. The patch also adds some missing attributes which are required to enable JavaScript validation of the checkbox. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Administration -> System preferences and Enable the system preference PatronSelfRegistration. - Set the system preference GDPR_Policy to "Enforce". - Go to the OPAC and click the "Register here" link. - Under the "GDPR consent" heading near the bottom of the page, confirm that the "I agree" checkbox lines up with other form fields on the page, and that the "Required" label lines up below it. - Submit the form without checking the GDPR consent checkbox. - The form should not be submitted, and a "This field is required" message should appear next to the checkbox label. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Hayley Pelham <hayleypelham@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Hayley Pelham <hayleypelham@catalyst.net.nz> --- Hi Owen, This looks good at larger browser widths and the checkbox and Required text lines up with the rest of the form, but at smaller browser widths the checkbox becomes misaligned, and when the form is submitted without checking the checkbox and the This field is required text appears, some weird interaction happens. I have attached a screenshot illustrating this issue. Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124322|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124830&action=edit Bug 28934: Correct markup of GDPR consent in OPAC patron entry This patch makes changes to the markup around the GDPR consent checkbox in the OPAC self-registration / update page to make it more consistent with other form fields on the page. The patch also adds some missing attributes which are required to enable JavaScript validation of the checkbox. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Administration -> System preferences and Enable the system preference PatronSelfRegistration. - Set the system preference GDPR_Policy to "Enforce". - Go to the OPAC and click the "Register here" link. - Under the "GDPR consent" heading near the bottom of the page, confirm that the "I agree" checkbox lines up with other form fields on the page, and that the "Required" label lines up below it. - Submit the form without checking the GDPR consent checkbox. - The form should not be submitted, and a "This field is required" message should appear next to the checkbox label. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Hayley Pelham <hayleypelham@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124830|0 |1 is obsolete| | --- Comment #5 from Hayley Pelham <hayleypelham@catalyst.net.nz> --- Created attachment 124852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124852&action=edit Bug 28934: Correct markup of GDPR consent in OPAC patron entry This patch makes changes to the markup around the GDPR consent checkbox in the OPAC self-registration / update page to make it more consistent with other form fields on the page. The patch also adds some missing attributes which are required to enable JavaScript validation of the checkbox. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Administration -> System preferences and Enable the system preference PatronSelfRegistration. - Set the system preference GDPR_Policy to "Enforce". - Go to the OPAC and click the "Register here" link. - Under the "GDPR consent" heading near the bottom of the page, confirm that the "I agree" checkbox lines up with other form fields on the page, and that the "Required" label lines up below it. - Submit the form without checking the GDPR consent checkbox. - The form should not be submitted, and a "This field is required" message should appear next to the checkbox label. Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |joonas.kylmala@iki.fi -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124852|0 |1 is obsolete| | --- Comment #7 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125032&action=edit Bug 28934: Make the OPAC registration form design consistent The gender/sex and GDPR inputs were slightly misaligned (by 1.5em). Now they are aligned with the other inputs which have a width of 10em (9em width + margin 1em). The label assignments and required attributes for input elements are made also consistent. To test: 1) Enable GDPR_Policy syspref 2) Apply patch, run "yarn build --view opac", restart plack 3) Go to /cgi-bin/koha/opac-memberentry.pl 3) Check that the GDPR input box shows the required text now in red color 3) Check that the alignment of sex/gender and GDPR input matches with the other inputs perfectly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 --- Comment #9 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- (In reply to Hayley Pelham from comment #8)

Hi Joonas,

The alignment is much closer to the other form elements now, which is great.

However, if all required fields are completed except the GDPR checkbox, we don't get the 'This field is required' text and highlighting like we do for other elements.

Should this be present?

It should be. I will revise this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 --- Comment #11 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- (In reply to Joonas Kylmälä from comment #9)

However, if all required fields are completed except the GDPR checkbox, we

...

don't get the 'This field is required' text and highlighting like we do for other elements.

Should this be present?

It should be. I will revise this.

Done. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Hayley Pelham <hayleypelham@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125117|0 |1 is obsolete| | --- Comment #12 from Hayley Pelham <hayleypelham@catalyst.net.nz> --- Created attachment 125123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125123&action=edit Bug 28934: Make the OPAC registration form design consistent The gender/sex and GDPR inputs were slightly misaligned (by 1.5em). Now they are aligned with the other inputs which have a width of 10em (9em width + margin 1em). The label assignments and required attributes for input elements are made also consistent. To test: 1) Enable GDPR_Policy syspref 2) Apply patch, run "yarn build --view opac", restart plack 3) Go to /cgi-bin/koha/opac-memberentry.pl 4) Check that the GDPR input box shows the required text now in red color 5) Check that the alignment of sex/gender and GDPR input matches with the other inputs perfectly. Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125123|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125334&action=edit Bug 28934: Make the OPAC registration form design consistent The gender/sex and GDPR inputs were slightly misaligned (by 1.5em). Now they are aligned with the other inputs which have a width of 10em (9em width + margin 1em). The label assignments and required attributes for input elements are made also consistent. To test: 1) Enable GDPR_Policy syspref 2) Apply patch, run "yarn build --view opac", restart plack 3) Go to /cgi-bin/koha/opac-memberentry.pl 4) Check that the GDPR input box shows the required text now in red color 5) Check that the alignment of sex/gender and GDPR input matches with the other inputs perfectly. Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply in 20.11.x, maybe another dependancy -- You are receiving this mail because: You are watching all bug changes.