[Bug 13501] New: Allow autocompletion on drop-down lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Bug ID: 13501 Summary: Allow autocompletion on drop-down lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Some users have very long lists of authorised values. It could be painful to pick a value in such lists with a simple drop-down list. Following patches will allow to type some text in order to filter these values and pick the good one easily. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 34830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34830&action=edit Bug 13501: Add jQuery UI plugin combobox It allows autocompletion on selects. Based on http://jqueryui.com/autocomplete/#combobox Note: This patch reset $.fn.button to the jQuery UI one (was overwritten by Bootstrap) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 34831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34831&action=edit Bug 13501: Use combobox plugin on cataloguing and batch items edit pages -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34831|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 34855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34855&action=edit Bug 13501: Use combobox plugin on cataloguing and batch items edit pages Tested with drop downs in cataloguing (edit and new record/item) and batch item editing. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34830|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 34856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34856&action=edit Bug 13501: Add jQuery UI plugin combobox It allows autocompletion on selects. Based on http://jqueryui.com/autocomplete/#combobox Note: This patch reset $.fn.button to the jQuery UI one (was overwritten by Bootstrap) Tested together with patch #2 Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34855|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 34857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34857&action=edit Bug 13501: Use combobox plugin on cataloguing and batch items edit pages Tested with drop downs in cataloguing (edit and new record/item) and batch item editing. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34856|0 |1 is obsolete| | Attachment #34857|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34897&action=edit [PASSED QA] Bug 13501: Add jQuery UI plugin combobox It allows autocompletion on selects. Based on http://jqueryui.com/autocomplete/#combobox Note: This patch reset $.fn.button to the jQuery UI one (was overwritten by Bootstrap) Tested together with patch #2 Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34898&action=edit [PASSED QA] Bug 13501: Use combobox plugin on cataloguing and batch items edit pages Tested with drop downs in cataloguing (edit and new record/item) and batch item editing. Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Looks good, but could perhaps use some styling, as the box is the same color as the background on the edit items page. Of course, it used to be the same color as the background on the edit record page, so it's kind of a wash in that respect ; ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- I think this is a useful enhancement, but I think in its current state it removes some of the built-in usability of a default HTML dropdown. The new dropdown has a fixed width, which in my system means it is not wide enough to show the complete description for some of my codes. After I have selected an item from the dropdown, I expect to be able to see the full description of the selected item by opening the dropdown again. In a <select>, expanding a dropdown with a selected item will scroll the list to the selected item and show it highlighted. In this version it expands the list but doesn't scroll or indicate in any way that it was selected. I think those are issues which ought to be addressed. It works fairly well with keyboard navigation, but it now takes more clicks to choose an item via keyboard. Old: Tab to <select>, type the first letters of the item you're looking for. Item is selected. New: Tab to combobox, type the word you're looking for. Use arrow key to select the item you want. That may not be a deal-breaker for the feature, but I know the different will be noticeable to catalogers. Another problematic difference: After you select an item from the list, if you hit ENTER the form submits. We have been working to eliminate that behavior from forms in Koha, so I would consider it a regression to introduce a feature that brings it back. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34897|0 |1 is obsolete| | Attachment #34898|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 40654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40654&action=edit Bug 13501: Add JS library select2, use it on cataloguing and batch items edit pages -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Select2's selects behaviour is closer to native selects and I think it addresses all Owen's issues. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40654|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 40708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40708&action=edit Bug 13501: Add JS library select2, use it on cataloguing and batch items edit pages Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I would like to get another signoff to confirm that the concerns raised in comment 11 are fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |koha@univ-lyon3.fr --- Comment #14 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Tested in cataloguing (edit and new record/item) and also in batch modification. I had a filter where I can type a part of the authorized value : it works as expected. I can also use the dropdown to select a value and this one is highlighted when I'm on it. When choosing a value in the list, I can see the full description but after have chose, long descriptions are cut (We can have full description when passing mouse over). When using keybord, I have to use enter to select a value. For what I see, this feature works only in cataloguing (I haven't understand at the beginning because I didn't see it in the description). It would be wonderful if we can also have it in acquisitions or patrons) For me, it works functionnaly so I will sign it off but I can't answer to Owen's questions about regresion. Sonia -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tested on batchMod.pl: 1/ The "required" is before the select. 2/ After selecting a value, the description is truncated (see comment 9). 3/ (In reply to Owen Leonard from comment #9)
Old: Tab to <select>, type the first letters of the item you're looking for. Item is selected.
New: Tab to combobox, type the word you're looking for. Use arrow key to select the item you want.
Still valid. Maybe something like http://stackoverflow.com/questions/20989458/select2-open-dropdown-on-focus 4/ Add the new JS plugin to the about page. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 44213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44213&action=edit Bug 13501: Indentation fix (batchMod-edit.tt) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 44214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44214&action=edit Bug 13501: Move "Required" and checkbox after input/select -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 44215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44215&action=edit Bug 13501: Downgrade Select2 to version 3.5.4 version 3.5.4 is more "keyboard-friendly" than version 4.0.0 + add Select2 to the about page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40708|0 |1 is obsolete| | Attachment #44215|0 |1 is obsolete| | --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 44216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44216&action=edit Bug 13501: Add JS library select2 3.5.4 use it on cataloguing and batch items edit pages Note: this is a squash of two commits: - Add JS library select2, use it on cataloguing and batch items edit pages - Downgrade Select2 to version 3.5.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44213|0 |1 is obsolete| | --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 44217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44217&action=edit Bug 13501: Indentation fix (batchMod-edit.tt) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44214|0 |1 is obsolete| | --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 44218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44218&action=edit Bug 13501: Move "Required" and checkbox after input/select -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44218|0 |1 is obsolete| | --- Comment #22 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 45966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45966&action=edit Bug 13501: Move "Required" and checkbox after input/select Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Aleisha, you have only signed off the last patch, could you confirm you have tested the whole feature? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia@hotmail.com Status|Needs Signoff |Signed Off --- Comment #24 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Jonathan Druart from comment #23)
Aleisha, you have only signed off the last patch, could you confirm you have tested the whole feature?
Yes I have! sorry, meant to sign off on all of the patches -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, I would like to get your signoff on this one. I am ready to pass QA it as I think the behavior is consistent and it could be very useful for users. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Julian, maybe it would be better to use a minified version of select2.css. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org