[Bug 19725] New: OAI-PMH ListRecords and ListIdentifiers should use biblio_metadata.timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Bug ID: 19725 Summary: OAI-PMH ListRecords and ListIdentifiers should use biblio_metadata.timestamp Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Depends on: 19724 Since bug 17196, biblioitems.timestamp is not always updated after a change in the MARC record. Filtering should be based on biblio_metadata.timestamp instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724 [Bug 19724] Add timestamp to biblio_metadata and deletedbiblio_metadata -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 69437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69437&action=edit Bug 19725: Add failing test Also fix tests for UNIMARC Test plan: 1. prove t/db_dependent/OAI/Server.t 2. Verify that it FAILS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 69438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69438&action=edit Bug 19725: OAI-PMH - Use biblio_metadata.timestamp Since bug 17196, biblioitems.timestamp is not always updated after a change in the MARC record. Filtering should be based on biblio_metadata.timestamp instead. Test plan: 1. prove t/db_dependent/OAI/Server.t 2. Verify that it SUCCEEDS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominic.pichette@inlibro.co | |m --- Comment #3 from Dominic Pichette <dominic.pichette@inlibro.com> --- Sorry, prove t/db_dependent/OAI/Server.t t/db_dependent/OAI/Server.t .. 1/29 Can't locate object method "xslt" via package "Koha::OAI::Server::ListMetadataFormats" at Koha/OAI/Server/Repository.pm line 147. # Looks like your test exited with 2 just after 12. t/db_dependent/OAI/Server.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 17/29 subtests Test Summary Report ------------------- t/db_dependent/OAI/Server.t (Wstat: 512 Tests: 12 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 29 tests but ran 12. Files=1, Tests=12, 72 wallclock secs ( 0.03 usr 0.01 sys + 1.27 cusr 0.10 csys = 1.41 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- This error is caused by a too recent version of HTTP::OAI. See bug 19732 Quick fix: sudo cpanm https://cpan.metacpan.org/authors/id/T/TI/TIMBRODY/HTTP-OAI-3.28.tar.gz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69437|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69627&action=edit Bug 19725: Add failing test Also fix tests for UNIMARC Test plan: 1. prove t/db_dependent/OAI/Server.t 2. Verify that it FAILS Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69438|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69628&action=edit Bug 19725: OAI-PMH - Use biblio_metadata.timestamp Since bug 17196, biblioitems.timestamp is not always updated after a change in the MARC record. Filtering should be based on biblio_metadata.timestamp instead. Test plan: 1. prove t/db_dependent/OAI/Server.t 2. Verify that it SUCCEEDS Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69627|0 |1 is obsolete| | Attachment #69628|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 69997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69997&action=edit Bug 19725: Add failing test Also fix tests for UNIMARC Test plan: 1. prove t/db_dependent/OAI/Server.t 2. Verify that it FAILS Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 69998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69998&action=edit Bug 19725: OAI-PMH - Use biblio_metadata.timestamp Since bug 17196, biblioitems.timestamp is not always updated after a change in the MARC record. Filtering should be based on biblio_metadata.timestamp instead. Test plan: 1. prove t/db_dependent/OAI/Server.t 2. Verify that it SUCCEEDS Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Bug 19725 depends on bug 19724, which changed state. Bug 19724 Summary: Add timestamp to biblio_metadata and deletedbiblio_metadata https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org