[Bug 39246] New: Patron category charge limit inputs should be longer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39246 Bug ID: 39246 Summary: Patron category charge limit inputs should be longer Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: ephetteplace@cca.edu QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The various charge limit settings for a patron category (noissuescharge, noissueschargeguarantees, and noissueschargeguarantorswithguarantees) are too short. The size of all these inputs is only 3 characters and their max length is 4. This is too small for many of the valid values that might be chosen. For instance, if you want to set a charge limit over 100 currency units, you will not be able to use decimals (because "100." takes up the maximum of four characters). This won't work well for currencies where an individual unit is low value. It's awkward for us if I want to write "50.00" in. These are INT 10 fields in the database so I think it shouldn't cause any problems to lengthen the inputs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39246 --- Comment #1 from Eric Phetteplace <ephetteplace@cca.edu> --- The class for these inputs is "decimal" but they are an integer field in the database. If you input "50.5", which the decimal class makes it looks like is a valid choice, it is rounded up to "51" in the database which seems like very unexpected behavior. I am going to broaden the scope of this bug rather than create a new one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39246 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron category charge |Issues with patron category |limit inputs should be |charge limit inputs |longer |(length, decimals) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39246 --- Comment #2 from Eric Phetteplace <ephetteplace@cca.edu> --- Never mind, the decimal issue runs deeper, because the $Price on_editing filter makes these integers look like decimals in HTML. The decimal class itself appears to do nothing. I think the fields need to be decimals in the database but that is a more sophisticated change than I am capable of making at the moment so I'm narrowing the scope of the bug again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39246 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Issues with patron category |Patron category charge |charge limit inputs |limit inputs should be |(length, decimals) |larger -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39246 --- Comment #3 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 179005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179005&action=edit Bug 39246: Patron category charge limit inputs should be larger To test: - From /cgi-bin/koha/admin/categories.pl open a patron category to editing - Note the short length of the three consecutive 'charge limit' inputs - Apply patch - Edit a patron category; there is no space to put in a limit like 100.00 Sponsored-By: California College of the Arts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39246 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39246 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39246 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179005|0 |1 is obsolete| | --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- Created attachment 179149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179149&action=edit Bug 39246: Patron category charge limit inputs should be larger To test: - From /cgi-bin/koha/admin/categories.pl open a patron category to editing - Note the short length of the three consecutive 'charge limit' inputs - Apply patch - Edit a patron category; there is no space to put in a limit like 100.00 Sponsored-By: California College of the Arts Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39246 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Assignee|koha-bugs@lists.koha-commun |ephetteplace@cca.edu |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39246 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39246 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179149|0 |1 is obsolete| | --- Comment #5 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 179350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179350&action=edit Bug 39246: Patron category charge limit inputs should be larger To test: - From /cgi-bin/koha/admin/categories.pl open a patron category to editing - Note the short length of the three consecutive 'charge limit' inputs - Apply patch - Edit a patron category; there is no space to put in a limit like 100.00 Sponsored-By: California College of the Arts Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39246 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39246 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39246 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39246 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not impact 24.11.x for UI stability -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org